Skip to contentSkip to conversation

crypto: talitos: request irq after tasklet_init()

PATCH In review Rosen Penev 2 participants 2 messages Sep 4 – Sep 16 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: talitos: request irq after tasklet_init()

The talitos interrupt handlers schedule priv->done_task[] via tasklet_schedule(). In probe(), talitos_probe_irq() ran before tasklet_init(), so an interrupt arriving during that window (a shared IRQ, or a completion pending from an earlier transmission) would schedule an uninitialized tasklet.

Move talitos_probe_irq() after the tasklet_init() calls so the tasklets are fully set up before interrupts are enabled. This matches remove(), which frees the IRQs before killing the tasklets.

Assisted-by opencode:big-pickle
---
 drivers/crypto/talitos.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/crypto/talitos.c +4 -4
index 41a87d7c30a0..da08cf9615c9 100644
@@ -3481,10 +3481,6 @@ static int talitos_probe(struct platform_device *ofdev)
 		stride = TALITOS2_CH_STRIDE;
 	}
 
-	err = talitos_probe_irq(ofdev);
-	if (err)
-		goto err_out;
-
 	if (has_ftr_sec1(priv)) {
 		if (priv->num_channels == 1)
 			tasklet_init(&priv->done_task[0], talitos1_done_ch0,
@@ -3507,6 +3503,10 @@ static int talitos_probe(struct platform_device *ofdev)
 		}
 	}
 
+	err = talitos_probe_irq(ofdev);
+	if (err)
+		goto err_out;
+
 	priv->fifo_len = roundup_pow_of_two(priv->chfifo_len);
 
 	for (i = 0; i < priv->num_channels; i++) {
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 10 lines · Rosen Penev

The talitos interrupt handlers schedule priv->done_task[] via tasklet_schedule(). In probe(), talitos_probe_irq() ran before tasklet_init(), so an interrupt arriving during that window (a shared IRQ, or a completion pending from an earlier transmission) would schedule an uninitialized tasklet.

Move talitos_probe_irq() after the tasklet_init() calls so the tasklets are fully set up before interrupts are enabled. This matches remove(), which frees the IRQs before killing the tasklets.

Quoted 5 lines
Assisted-by opencode:big-pickle

---
drivers/crypto/talitos.c | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)

Please have a look at

https://sashiko.dev/#/patchset/20260904211230.81963-1-rosenp%40gmail.com

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt