staging: rtl8723bs: align AES function parameters with open parenthesis
PATCH 1/1 staging: rtl8723bs: align AES function parameters with open parenthesis
Align the continuation lines of the aes_cipher()
parameter lists with their opening parenthesis,
and replace the stray tab between the uint type
and the hdrlen argument with a single space.
This addresses the "Alignment should match open parenthesis" check reported by checkpatch.pl --strict.
No functional change.
--- drivers/staging/rtl8723bs/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_security.c +2 -2
@@ -765,8 +765,8 @@ static void construct_ctr_preload(u8 *ctr_preload, ctr_preload[15 ] = (unsigned char )(c %256 ); } -static signed int aes_cipher (u8 *key,uint hdrlen, -u8 *pframe,uint plen) +static signed int aes_cipher (u8 *key,uint hdrlen, +u8 *pframe,uint plen) {uint qc_exists, a4_exists, i, j, payload_remainder, num_blocks, payload_index;
Signature · 1 line
2.43.0
Quoted 4 lines · JunHyeok Seo
Align the continuation lines of the
aes_cipher()
parameter lists with their opening parenthesis,
and replace the stray tab between the uint type
and the hdrlen argument with a single space.
This paragraph should be wrapped at 72 characters.
Quoted 16 lines
This addresses the "Alignment should match open parenthesis" check reported by checkpatch.pl --strict.
No functional change.
Signed-off-by JunHyeok Seo <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8723bs/core/rtw_security.c +0
-0
drivers/staging/rtl8723bs/core/rtw_security.c static void construct_ctr_preload(u8 *ctr_preload, · line 769
Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_security.c +2
-2@@ -765,8 +765,8 @@ static void construct_ctr_preload(u8 *ctr_preload, ctr_preload[15 ] = (unsigned char )(c %256 ); } -static signed int aes_cipher (u8 *key,uint hdrlen, -u8 *pframe,uint plen) +static signed int aes_cipher (u8 *key,uint hdrlen, +u8 *pframe,uint plen)
Unless it's specified by the protocol spec, then "signed int" is nonsense. Plus the caller doesn't check so it might as well be void.
regards,
dan carpenter