Skip to contentSkip to conversation

KVM: selftests: Fix reg_list and VM leak in get_reg_list test

PATCH New Tharit Tangkijwanichakul 1 participant 1 message Sep 6

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: selftests: Fix reg_list and VM leak in get_reg_list test

Calling the test with --list or --list-filtered causes an early return in run_test() which skips freeing the reg_list and vm.

Use a goto so that the early return joins the common exit path.

Fixes 17da79e009c3 ("KVM: arm64: selftests: Split get-reg-list test code")

---
Tested on a Rock 5B (RK3588). Running the test with --list and --list-filtered now exercises the goto path added by this fix and exits cleanly.

---
 tools/testing/selftests/kvm/get-reg-list.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tools/testing/selftests/kvm/get-reg-list.c +3 -1
index 216f10644c1a..6eb91d5c739e 100644
@@ -189,7 +189,7 @@ static void run_test(struct vcpu_reg_list *c)
 				print_reg(config_name(c), id);
 		}
 		putchar('\n');
-		return;
+		goto free_reg_list;
 	}
 
 	for_each_sublist(c, s)
@@ -306,6 +306,8 @@ static void run_test(struct vcpu_reg_list *c)
 	pr_info("%s: PASS\n", config_name(c));
 	blessed_n = 0;
 	free(blessed_reg);
+
+free_reg_list:
 	free(reg_list);
 	kvm_vm_free(vm);
 }
Signature · 1 line
2.47.3