Skip to contentSkip to conversation

ext4: fix typos in comments

PATCH In review Hemanth Selam 3 participants 3 messages Sep 7 ext4 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4: fix typos in comments

Fix typos in comments, reported by scripts/checkpatch.pl using the misspelling list in scripts/spelling.txt. Only touches comments, no code changes.

Assisted-by Cursor:claude-opus-5
---
 fs/ext4/extents.c | 2 +-
 fs/ext4/inode.c   | 2 +-
 fs/ext4/mballoc.c | 8 ++++----
 fs/ext4/mballoc.h | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
fs/ext4/extents.c +1 -1
index 76038b6c3655..d5d7ee229e4a 100644
@@ -3186,7 +3186,7 @@ int ext4_ext_zeroout(struct inode *inode, struct ext4_extent *ex)
  * @handle: the journal handle
  * @inode: the file inode
  * @path: the path to the extent
- * @split: the logical block where the extent is splitted.
+ * @split: the logical block where the extent is split.
  * @flags: flags used to insert new extent to extent tree.
  *
  *
fs/ext4/inode.c +1 -1
index bd4b778df9eb..e719fa3cbaaf 100644
@@ -2163,7 +2163,7 @@ static bool mpage_add_bh_to_extent(struct mpage_da_data *mpd, ext4_lblk_t lblk,
  * @bh - buffer we should start processing from
  * @lblk - logical number of the block in the file corresponding to @bh
  *
- * Walk through page buffers from @bh upto @head (exclusive) and either submit
+ * Walk through page buffers from @bh up to @head (exclusive) and either submit
  * the page for IO if all buffers in this page were mapped and there's no
  * accumulated extent of buffers to map or add buffers in the page to the
  * extent of buffers to map. The function returns 1 if the caller can continue
fs/ext4/mballoc.c +4 -4
index 06171a11db12..47156ce9e5c0 100644
@@ -234,7 +234,7 @@
  *
  * there are two types of preallocations:
  *  - inode
- *    assiged to specific inode and can be used for this inode only.
+ *    assigned to specific inode and can be used for this inode only.
  *    it describes part of inode's space preallocated to specific
  *    physical blocks. any block from that preallocated can be used
  *    independent. the descriptor just tracks number of blocks left
@@ -2326,11 +2326,11 @@ static void ext4_mb_check_limits(struct ext4_allocation_context *ac,
  *   stop the scan and use it immediately
  *
  * * If free extent found is smaller than goal, then keep retrying
- *   upto a max of sbi->s_mb_max_to_scan times (default 200). After
+ *   up to a max of sbi->s_mb_max_to_scan times (default 200). After
  *   that stop scanning and use whatever we have.
  *
  * * If free extent found is bigger than goal, then keep retrying
- *   upto a max of sbi->s_mb_min_to_scan times (default 10) before
+ *   up to a max of sbi->s_mb_min_to_scan times (default 10) before
  *   stopping the scan and using the extent.
  *
  *
@@ -3029,7 +3029,7 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
 	 * is greater than equal to the sbi_s_mb_order2_reqs
 	 * You can tune it via /sys/fs/ext4/<partition>/mb_order2_req
 	 * We also support searching for power-of-two requests only for
-	 * requests upto maximum buddy size we have constructed.
+	 * requests up to maximum buddy size we have constructed.
 	 */
 	if (i >= sbi->s_mb_order2_reqs && i <= MB_NUM_ORDERS(sb)) {
 		if (is_power_of_2(ac->ac_g_ex.fe_len))
fs/ext4/mballoc.h +2 -2
index 39333ce72cbd..571d9bd93810 100644
@@ -86,9 +86,9 @@
 #define MB_DEFAULT_LINEAR_SCAN_THRESHOLD	16
 
 /*
- * The maximum order upto which CR_BEST_AVAIL_LEN can trim a particular
+ * The maximum order up to which CR_BEST_AVAIL_LEN can trim a particular
  * allocation request. Example, if we have an order 7 request and max trim order
- * of 3, we can trim this request upto order 4.
+ * of 3, we can trim this request up to order 4.
  */
 #define MB_DEFAULT_BEST_AVAIL_TRIM_ORDER	3
 
Signature · 1 line
2.48.1
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines

Fix typos in comments, reported by scripts/checkpatch.pl using the misspelling list in scripts/spelling.txt. Only touches comments, no code changes.

Assisted-by Cursor:claude-opus-5

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Hemanth Selam
Quoted 6 lines · Hemanth Selam

Fix typos in comments, reported by scripts/checkpatch.pl using the misspelling list in scripts/spelling.txt. Only touches comments, no code changes.

Assisted-by Cursor:claude-opus-5

Looks good. Feel free to add:

Honza

Quoted 88 lines
---
 fs/ext4/extents.c | 2 +-
 fs/ext4/inode.c   | 2 +-
 fs/ext4/mballoc.c | 8 ++++----
 fs/ext4/mballoc.h | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
fs/ext4/extents.c +1 -1
index 76038b6c3655..d5d7ee229e4a 100644
@@ -3186,7 +3186,7 @@ int ext4_ext_zeroout(struct inode *inode, struct ext4_extent *ex)
  * @handle: the journal handle
  * @inode: the file inode
  * @path: the path to the extent
- * @split: the logical block where the extent is splitted.
+ * @split: the logical block where the extent is split.
  * @flags: flags used to insert new extent to extent tree.
  *
  *
fs/ext4/inode.c +1 -1
index bd4b778df9eb..e719fa3cbaaf 100644
@@ -2163,7 +2163,7 @@ static bool mpage_add_bh_to_extent(struct mpage_da_data *mpd, ext4_lblk_t lblk,
  * @bh - buffer we should start processing from
  * @lblk - logical number of the block in the file corresponding to @bh
  *
- * Walk through page buffers from @bh upto @head (exclusive) and either submit
+ * Walk through page buffers from @bh up to @head (exclusive) and either submit
  * the page for IO if all buffers in this page were mapped and there's no
  * accumulated extent of buffers to map or add buffers in the page to the
  * extent of buffers to map. The function returns 1 if the caller can continue
fs/ext4/mballoc.c +4 -4
index 06171a11db12..47156ce9e5c0 100644
@@ -234,7 +234,7 @@
  *
  * there are two types of preallocations:
  *  - inode
- *    assiged to specific inode and can be used for this inode only.
+ *    assigned to specific inode and can be used for this inode only.
  *    it describes part of inode's space preallocated to specific
  *    physical blocks. any block from that preallocated can be used
  *    independent. the descriptor just tracks number of blocks left
@@ -2326,11 +2326,11 @@ static void ext4_mb_check_limits(struct ext4_allocation_context *ac,
  *   stop the scan and use it immediately
  *
  * * If free extent found is smaller than goal, then keep retrying
- *   upto a max of sbi->s_mb_max_to_scan times (default 200). After
+ *   up to a max of sbi->s_mb_max_to_scan times (default 200). After
  *   that stop scanning and use whatever we have.
  *
  * * If free extent found is bigger than goal, then keep retrying
- *   upto a max of sbi->s_mb_min_to_scan times (default 10) before
+ *   up to a max of sbi->s_mb_min_to_scan times (default 10) before
  *   stopping the scan and using the extent.
  *
  *
@@ -3029,7 +3029,7 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
 	 * is greater than equal to the sbi_s_mb_order2_reqs
 	 * You can tune it via /sys/fs/ext4/<partition>/mb_order2_req
 	 * We also support searching for power-of-two requests only for
-	 * requests upto maximum buddy size we have constructed.
+	 * requests up to maximum buddy size we have constructed.
 	 */
 	if (i >= sbi->s_mb_order2_reqs && i <= MB_NUM_ORDERS(sb)) {
 		if (is_power_of_2(ac->ac_g_ex.fe_len))
fs/ext4/mballoc.h +2 -2
index 39333ce72cbd..571d9bd93810 100644
@@ -86,9 +86,9 @@
 #define MB_DEFAULT_LINEAR_SCAN_THRESHOLD	16
 
 /*
- * The maximum order upto which CR_BEST_AVAIL_LEN can trim a particular
+ * The maximum order up to which CR_BEST_AVAIL_LEN can trim a particular
  * allocation request. Example, if we have an order 7 request and max trim order
- * of 3, we can trim this request upto order 4.
+ * of 3, we can trim this request up to order 4.
  */
 #define MB_DEFAULT_BEST_AVAIL_TRIM_ORDER	3
 
Signature · 1 line
2.48.1
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR