drm/bridge: tc358768: Enforce input bus flags via atomic_check
Subsystems (4)
PATCH RESEND 1/1 drm/bridge: tc358768: Enforce input bus flags via atomic_check
From: Leonardo Costa <[email protected]>
The tc358768 declares static bridge timings requiring pixel data to be sampled on the positive clock edge.
However, the DRM core default propagation simply copies the output-side bus flags, coming from the next bridge, connector or panel, to the input side. If the propagated flags are incompatible with the bridge ones, the data is wrongly sampled, typically resulting in visual artifacts on the panel.
Implement the atomic_check hook, replacing the mutually exclusive mode_fixup, and set the bridge state input bus flags to the ones required by the tc358768. The sync polarity defaulting previously done in mode_fixup is carried over into atomic_check unchanged.
--- drivers/gpu/drm/bridge/tc358768.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
drivers/gpu/drm/bridge/tc358768.c +10 -5
@@ -1262,10 +1262,13 @@ tc358768_atomic_get_input_bus_fmts(struct drm_bridge *bridge,return input_fmts; } -static bool tc358768_mode_fixup (struct drm_bridge *bridge, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) +static int tc358768_bridge_atomic_check (struct drm_bridge *bridge, +struct drm_bridge_state *bridge_state, +struct drm_crtc_state *crtc_state, +struct drm_connector_state *conn_state) { +struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; +/* Default to positive sync */ if (!(adjusted_mode->flags &
@@ -1276,13 +1279,15 @@ static bool tc358768_mode_fixup(struct drm_bridge *bridge, (DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC))) adjusted_mode->flags |=DRM_MODE_FLAG_PVSYNC ; -return true; + bridge_state->input_bus_cfg.flags = bridge->timings->input_bus_flags; + +return 0 ; }static const struct drm_bridge_funcs tc358768_bridge_funcs = { .attach = tc358768_bridge_attach, .mode_valid = tc358768_bridge_mode_valid, - .mode_fixup = tc358768_mode_fixup, + .atomic_check = tc358768_bridge_atomic_check, .atomic_pre_enable = tc358768_bridge_atomic_pre_enable, .atomic_enable = tc358768_bridge_atomic_enable, .atomic_disable = tc358768_bridge_atomic_disable,
Quoted 11 lines · Leonardo Costa
From: Leonardo Costa <[email protected]>
The tc358768 declares static bridge timings requiring pixel data to be sampled on the positive clock edge.
However, the DRM core default propagation simply copies the output-side bus flags, coming from the next bridge, connector or panel, to the input side. If the propagated flags are incompatible with the bridge ones, the data is wrongly sampled, typically resulting in visual artifacts on the panel.
Quoted 8 lines
Implement the
atomic_checkhook, replacing the mutually exclusivemode_fixup, and set the bridge state input bus flags to the ones required by the tc358768. The sync polarity defaulting previously done inmode_fixupis carried over intoatomic_checkunchanged.Fixes ff1ca6397b1d ("drm/bridge: Add tc358768 driver")Signed-off-by Leonardo Costa <[email protected]>
Quoted 16 lines · Leonardo Costa
From: Leonardo Costa <[email protected]>
The tc358768 declares static bridge timings requiring pixel data to be sampled on the positive clock edge.
However, the DRM core default propagation simply copies the output-side bus flags, coming from the next bridge, connector or panel, to the input side. If the propagated flags are incompatible with the bridge ones, the data is wrongly sampled, typically resulting in visual artifacts on the panel.
Implement the
atomic_checkhook, replacing the mutually exclusivemode_fixup, and set the bridge state input bus flags to the ones required by the tc358768. The sync polarity defaulting previously done inmode_fixupis carried over intoatomic_checkunchanged.
Quoted 4 lines
Fixes ff1ca6397b1d ("drm/bridge: Add tc358768 driver")Signed-off-by Leonardo Costa <[email protected]>---
[...]
Hello DRM bridge maintainers,
Quoted 11 lines · Leonardo Costa
From: Leonardo Costa <[email protected]>
The tc358768 declares static bridge timings requiring pixel data to be sampled on the positive clock edge.
However, the DRM core default propagation simply copies the output-side bus flags, coming from the next bridge, connector or panel, to the input side. If the propagated flags are incompatible with the bridge ones, the data is wrongly sampled, typically resulting in visual artifacts on the panel.
Quoted 8 lines
Implement the
atomic_checkhook, replacing the mutually exclusivemode_fixup, and set the bridge state input bus flags to the ones required by the tc358768. The sync polarity defaulting previously done inmode_fixupis carried over intoatomic_checkunchanged.Fixes ff1ca6397b1d ("drm/bridge: Add tc358768 driver")Signed-off-by Leonardo Costa <[email protected]>
Just a gentle ping, can this fix be merged?
Francesco
Quoted 11 lines · Leonardo Costa
From: Leonardo Costa <[email protected]>
The tc358768 declares static bridge timings requiring pixel data to be sampled on the positive clock edge.
However, the DRM core default propagation simply copies the output-side bus flags, coming from the next bridge, connector or panel, to the input side. If the propagated flags are incompatible with the bridge ones, the data is wrongly sampled, typically resulting in visual artifacts on the panel.
Quoted 8 lines
Implement the
atomic_checkhook, replacing the mutually exclusivemode_fixup, and set the bridge state input bus flags to the ones required by the tc358768. The sync polarity defaulting previously done inmode_fixupis carried over intoatomic_checkunchanged.Fixes ff1ca6397b1d ("drm/bridge: Add tc358768 driver")Signed-off-by Leonardo Costa <[email protected]>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Quoted 10 lines · Leonardo Costa
The tc358768 declares static bridge timings requiring pixel data to be sampled on the positive clock edge.
However, the DRM core default propagation simply copies the output-side bus flags, coming from the next bridge, connector or panel, to the input side. If the propagated flags are incompatible with the bridge ones, the data is wrongly sampled, typically resulting in visual artifacts on the panel.
[...]
Applied, thanks!
[1/1] drm/bridge: tc358768: Enforce input bus flags via atomic_check
commit: ed761e0693950fcb4f6b0f60387a3961b972adf3
Best regards,
Signature · 3 lines
Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com