Skip to contentSkip to conversation

dmaengine: bestcomm: ata: drop unused local variable 'inc'

PATCH Applied Rosen Penev 2 participants 2 messages Sep 8 – Sep 10 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dmaengine: bestcomm: ata: drop unused local variable 'inc'

bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that was never read, tripping clang -Wunused-but-set-variable:

drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not used [-Werror,-Wunused-but-set-variable]

     58 |         struct bcom_ata_inc *inc;
        |                              ^

Drop the declaration and the bcom_task_inc() call that fed it.

---
v2: use suggested title

 drivers/dma/bestcomm/ata.c | 2 --
 1 file changed, 2 deletions(-)
drivers/dma/bestcomm/ata.c +0 -2
index 502a45d76adc..40126f3f189e 100644
@@ -55,7 +55,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
 {
 	struct bcom_task *tsk;
 	struct bcom_ata_var *var;
-	struct bcom_ata_inc *inc;
 
 	/* Prefetch breaks ATA DMA.  Turn it off for ATA DMA */
 	bcom_disable_prefetch();
@@ -69,7 +68,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
 	bcom_ata_reset_bd(tsk);
 
 	var = (struct bcom_ata_var *) bcom_task_var(tsk->tasknum);
-	inc = (struct bcom_ata_inc *) bcom_task_inc(tsk->tasknum);
 
 	if (bcom_load_image(tsk->tasknum, bcom_ata_task)) {
 		bcom_task_free(tsk);
Signature · 1 line
2.55.0
maintainer Applied
#1 lore raw
Quoted 9 lines · Rosen Penev

bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that was never read, tripping clang -Wunused-but-set-variable:

drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not used [-Werror,-Wunused-but-set-variable]

     58 |         struct bcom_ata_inc *inc;
        |                              ^

[...]

Applied, thanks!

[1/1] dmaengine: bestcomm: ata: drop unused local variable 'inc'

      commit: db1a748a3509da959c547689af40e8a064a19c6b

Best regards,

Signature · 1 line
~Vinod