Skip to contentSkip to conversation

media: i2c: isl7998x: Inline i2c_check_functionality() check

PATCH RESEND Superseded Thorsten Blum 1 participant 2 messages Sep 9

Subsystems (2)
Media (V4L/DVB) Intersil ISL7998X video decoder driver
lore
Share & tools
lore

Thorsten Blum

author
#0 lore raw

PATCH RESEND 1/1 media: i2c: isl7998x: Inline i2c_check_functionality() check

Inline the i2c_check_functionality() check, since the function returns a boolean status rather than an error code.

Reviewed-by Michael Tretter <[email protected]>
Signed-off-by Thorsten Blum <[email protected]>
---
 drivers/media/i2c/isl7998x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/i2c/isl7998x.c +1 -2
index a77538d2343c..8244d4296a02 100644
@@ -1460,8 +1460,7 @@ static int isl7998x_probe(struct i2c_client *client)
 	int nr_inputs;
 	int ret;
 
-	ret = i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA);
-	if (!ret) {
+	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) {
 		dev_warn(&adapter->dev,
 			 "I2C-Adapter doesn't support I2C_FUNC_SMBUS_WORD\n");
 		return -EIO;
author
#1 lore raw
Quoted 8 lines · Thorsten Blum

Inline the i2c_check_functionality() check, since the function returns a boolean status rather than an error code.

Reviewed-by Michael Tretter <[email protected]>
Signed-off-by Thorsten Blum <[email protected]>
---
 drivers/media/i2c/isl7998x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

I just sent this to Wolfram directly as part of a small series [1] for him to apply. Please ignore this earlier resend from today.

[1] https://lore.kernel.org/r/[email protected]/