Skip to contentSkip to conversation

net/txgbe: fix FDIR devarg integer width

PATCH Applied Zhang Tengfei 2 participants 2 messages Sep 9 Network drivers

lore
Share & tools
lore

Zhang Tengfei

author
#0 lore raw

PATCH 1/1 net/txgbe: fix FDIR devarg integer width

txgbe_handle_devarg() stores a uint16_t through extra_args, but pballoc and drop_queue were u8. Setting pkt-filter-size overwrote the adjacent drop_queue default.

Fixes 7e18be9beef2 ("net/txgbe: add device arguments for FDIR")
Cc [email protected]
Signed-off-by Zhang Tengfei <[email protected]>
---
 drivers/net/txgbe/txgbe_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/txgbe/txgbe_ethdev.c +2 -2
index 4d2746371b..814840b3f5 100644
@@ -533,8 +533,8 @@ txgbe_parse_devargs(struct rte_eth_dev *dev)
 	u16 ffe_pre = 8;
 	u16 ffe_post = 44;
 	/* FDIR args */
-	u8 pballoc = 0;
-	u8 drop_queue = 127;
+	u16 pballoc = 0;
+	u16 drop_queue = 127;
 	/* New devargs for amberlite config */
 	u16 tx_headwb = 1;
 	u16 tx_headwb_size = 16;
Signature · 1 line
2.55.0
Applied
#1 lore raw
Quoted 9 lines · On Thu, 10 Sep 2026 01:39:46 +0800 Zhang Tengfei <[email protected]> wrote:

txgbe_handle_devarg() stores a uint16_t through extra_args, but pballoc and drop_queue were u8. Setting pkt-filter-size overwrote the adjacent drop_queue default.

Fixes 7e18be9beef2 ("net/txgbe: add device arguments for FDIR")
Cc [email protected]
Signed-off-by Zhang Tengfei <[email protected]>

---

Applied to next-net.
Review saw another issue in devarg handling, sent followup patch for that.