MMC pinmux configuration fixes
Subsystems (2)
v4 cover MMC pinmux configuration fixes
This series fixes MMC pin input/output and pullup/pulldown settings across AM62*, AM62AX, and AM62LX boards.
All patches have been tested on their appropriate SK & EVM boards. BeaglePlay and Pocketbeagle boards have also been tested.
Changes since v3:
- Include PIN_OUTPUT fixes for missing third-party boards as per Sashiko review [0]
- Split out squashed patches into separate commits as per Nishanth's review [1]
[0] https://lore.kernel.org/linux-devicetree/[email protected]/
& https://lore.kernel.org/linux-devicetree/[email protected]/
[1] https://lore.kernel.org/linux-devicetree/20260904151335.fi5mvjpvziw2g3r2@exemption/
Link to v1:
https://lore.kernel.org/linux-devicetree/[email protected]/
Link to v2:
https://lore.kernel.org/linux-devicetree/[email protected]/
Link to v3:
https://lore.kernel.org/linux-devicetree/[email protected]/
Judith Mendez (15):
arm64: dts: ti: k3-am62a: Fix MMC0_CLK register address
arm64: dts: ti: k3-am62l-evm: Remove unnecessary internal pullups for
MMC0
arm64: dts: ti: k3-am62a7-sk: Set eMMC clock pin as OUTPUT
arm64: dts: ti: k3-am62a7-sk: Set SD clock pin as OUTPUT
arm64: dts: ti: k3-am62a-phycore-som: Set eMMC clock pin as OUTPUT
arm64: dts: ti: k3-am62-lp-sk: Set eMMC clock pins as OUTPUT
arm64: dts: ti: k3-am62-pocketbeagle2: Set SD clock pin as OUTPUT
arm64: dts: ti: k3-am625-beagleplay: Set MMC clock pins as OUTPUT
arm64: dts: ti: k3-am62x-sk-common: Set SD clock pin as OUTPUT
arm64: dts: ti: k3-am625-sk-common: Set eMMC clock pin as OUTPUT
arm64: dts: ti: k3-am62-phycore-som: Set eMMC clock pin as OUTPUT
arm64: dts: ti: k3-am625-tqma62xx: Set MMC clock pins as OUTPUT
arm64: dts: ti: k3-am625-var-som-symphony: Set SD clock pins as OUTPUT
arm64: dts: ti: k3-am625-var-som: Set MMC clock pins as OUTPUT
arm64: dts: ti: k3-am62x-phyboard-lyra: Set SD clock pin as OUTPUT
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 2 +- arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts | 2 +- arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 6 +++--- arch/arm64/boot/dts/ti/k3-am625-sk-common.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am625-tqma62xx-mba62xx.dts | 4 ++-- arch/arm64/boot/dts/ti/k3-am625-tqma62xx.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am625-var-som-symphony.dts | 2 +- arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi | 4 ++-- arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 5 ++--- arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++-- arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 +- 14 files changed, 20 insertions(+), 21 deletions(-)
Signature · 1 line
2.34.1
PATCH v4 1/15 arm64: dts: ti: k3-am62a: Fix MMC0_CLK register address
MMC0_CLKLB and MMC0_CLK have incorrectly swapped register addresses as per datasheet [0]. Set the correct MMC0_CLK address and drop the unneeded MMC0_CLKLB pin configuration.
[0] https://www.ti.com/lit/gpn/am62a7 Rev. E: Table 5-1. Pin Attributes
--- arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +1 -2
@@ -328,8 +328,7 @@ AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24) GPMC0_CSn3.I2C2_SDA */ main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = < AM62AX_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ - AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLKLB */ - AM62AX_IOPAD(0x21c, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ + AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ AM62AX_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1) MMC0_DAT1 */ AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3) MMC0_DAT2 */
Signature · 1 line
2.34.1
Re: [PATCH v4 01/15] arm64: dts: ti: k3-am62a: Fix MMC0_CLK register address
Quoted 19 lines · Judith Mendez
MMC0_CLKLBandMMC0_CLKhave incorrectly swapped register addresses as per datasheet [0]. Set the correctMMC0_CLKaddress and drop the unneededMMC0_CLKLBpin configuration.[0] https://www.ti.com/lit/gpn/am62a7 Rev. E: Table 5-1. Pin Attributes
Fixes e041ec6e86e7 ("arm64: dts: ti: k3-am62a7-sk: Enable eMMC support")Cc <[email protected]>Signed-off-by Judith Mendez <[email protected]>Reviewed-by Moteen Shah <[email protected]>--- arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +0
-0
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24) GPMC0_CSn3.I2C2_SDA */ · line 331
Quoted 6 lines
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +1
-2@@ -328,8 +328,7 @@ AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24) GPMC0_CSn3.I2C2_SDA */ main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = < AM62AX_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ - AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLKLB */ - AM62AX_IOPAD(0x21c, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ + AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */
Shouldn't be MMC0_CLK be o/p, instead of PIN_INPUT Similar to patch [0]
[0] https://lore.kernel.org/all/[email protected]/
Quoted 3 lines
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +0
-0AM62AX_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1) MMC0_DAT1 */ AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3) MMC0_DAT2 */
Re: [PATCH v4 01/15] arm64: dts: ti: k3-am62a: Fix MMC0_CLK register address
Hi Udit,
Quoted 17 lines · Udit
Quoted 14 lines · Judith Mendez
MMC0_CLKLBandMMC0_CLKhave incorrectly swapped register addresses as per datasheet [0]. Set the correctMMC0_CLKaddress and drop the unneededMMC0_CLKLBpin configuration.[0] https://www.ti.com/lit/gpn/am62a7 Rev. E: Table 5-1. Pin Attributes
Fixes e041ec6e86e7 ("arm64: dts: ti: k3-am62a7-sk: Enable eMMC support")Cc <[email protected]>Signed-off-by Judith Mendez <[email protected]>Reviewed-by Moteen Shah <[email protected]>--- arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 15 lines
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24) GPMC0_CSn3.I2C2_SDA */ · line 331
Quoted 11 lines
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +1
-2@@ -328,8 +328,7 @@ AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24) GPMC0_CSn3.I2C2_SDA */ main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = < AM62AX_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ - AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLKLB */ - AM62AX_IOPAD(0x21c, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ + AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */Shouldn't be
MMC0_CLKbe o/p, instead ofPIN_INPUTSimilar to patch [0]
[0] https://lore.kernel.org/all/[email protected]/
Yes it should, and it is in the same series as you pointed out. This current patch only fixes register address as per commit description. (:
~ Judith
Quoted 7 lines
Quoted 6 lines
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +0
-0AM62AX_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1) MMC0_DAT1 */ AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3) MMC0_DAT2 */
Kumar, Udit
Acked-byRe: [PATCH v4 01/15] arm64: dts: ti: k3-am62a: Fix MMC0_CLK register address
Thanks Judith
Quoted 39 lines · Judith Mendez
Hi Udit,
Quoted 27 lines · Udit
Quoted 24 lines · Judith Mendez
MMC0_CLKLBandMMC0_CLKhave incorrectly swapped register addresses as per datasheet [0]. Set the correctMMC0_CLKaddress and drop the unneededMMC0_CLKLBpin configuration.[0] https://www.ti.com/lit/gpn/am62a7 Rev. E: Table 5-1. Pin Attributes
Fixes e041ec6e86e7 ("arm64: dts: ti: k3-am62a7-sk: Enable eMMCsupport")
Cc <[email protected]>Signed-off-by Judith Mendez <[email protected]>Reviewed-by Moteen Shah <[email protected]>---
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts| 3 +--1 file changed, 1 insertion(+), 2 deletions(-)arch/arm64/ renamed from arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +0
-0
boot/dts/ti/k3-am62a7-sk.dts
indexd3b3675e7a8fc..b04636cab71c7100644arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +0
-0@@ -328,8 +328,7 @@ AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24)GPMC0_CSn3.I2C2_SDA */
main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = <Quoted 8 lines
Quoted 4 lines
AM62AX_IOPAD(0x220, PIN_INPUT, 0)/* (Y3)MMC0_CMD*/ -AM62AX_IOPAD(0x218, PIN_INPUT, 0)/* (AB1)MMC0_CLKLB*/ -AM62AX_IOPAD(0x21c, PIN_INPUT, 0)/* (AB1)MMC0_CLK*/ +AM62AX_IOPAD(0x218, PIN_INPUT, 0)/* (AB1)MMC0_CLK*/Shouldn't be
MMC0_CLKbe o/p, instead ofPIN_INPUTSimilar to patch [0]
[0] https://lore.kernel.org/all/[email protected]/
Quoted 3 lines
Yes it should, and it is in the same series as you pointed out. This current patch only fixes register address as per commit description. (:
I see. These can be merged into one patch,
Anyway,
Quoted 12 lines
~ Judith
Quoted 9 lines
Quoted 8 lines
AM62AX_IOPAD(0x214, PIN_INPUT, 0)/* (AA2)MMC0_DAT0*/AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0)/* (AA1)MMC0_DAT1*/
AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0)/* (AA3)MMC0_DAT2*/
PATCH v4 2/15 arm64: dts: ti: k3-am62l-evm: Remove unnecessary internal pullups for MMC0
In reply to Judith MendezAM62L EVM has external pullups on MMC0 CMD and D0 pins [0]. Remove internal pullups considering:
- Internal pullups are not required, without internal pullups, RDAT and RCMD values of 47K are within spec
- having both pullups (stronger pull) results in unnecessary power consumption
[0] https://www.ti.com/lit/zip/SPRCAL6
--- arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am62l3-evm.dts +2 -2
@@ -253,9 +253,9 @@ AM62LX_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (D8) I2C2_SDA */ mmc0_pins_default: mmc0-default-pins { pinctrl-single,pins = < - AM62LX_IOPAD(0x0214, PIN_INPUT_PULLUP, 0) /* (D2) MMC0_CMD */ + AM62LX_IOPAD(0x0214, PIN_INPUT, 0) /* (D2) MMC0_CMD */ AM62LX_IOPAD(0x020c, PIN_OUTPUT, 0) /* (B2) MMC0_CLK */ - AM62LX_IOPAD(0x0208, PIN_INPUT_PULLUP, 0) /* (D3) MMC0_DAT0 */ + AM62LX_IOPAD(0x0208, PIN_INPUT, 0) /* (D3) MMC0_DAT0 */ AM62LX_IOPAD(0x0204, PIN_INPUT_PULLUP, 0) /* (D4) MMC0_DAT1 */ AM62LX_IOPAD(0x0200, PIN_INPUT_PULLUP, 0) /* (C1) MMC0_DAT2 */ AM62LX_IOPAD(0x01fc, PIN_INPUT_PULLUP, 0) /* (C2) MMC0_DAT3 */
Signature · 1 line
2.34.1
PATCH v4 3/15 arm64: dts: ti: k3-am62a7-sk: Set eMMC clock pin as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruj16 Rev. C: Table 12-257. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +1 -1
@@ -328,7 +328,7 @@ AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24) GPMC0_CSn3.I2C2_SDA */ main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = < AM62AX_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ - AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ + AM62AX_IOPAD(0x218, PIN_OUTPUT, 0) /* (AB1) MMC0_CLK */ AM62AX_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1) MMC0_DAT1 */ AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3) MMC0_DAT2 */
Signature · 1 line
2.34.1
PATCH v4 4/15 arm64: dts: ti: k3-am62a7-sk: Set SD clock pin as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruj16 Rev. C: Table 12-257. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts +1 -1
@@ -344,7 +344,7 @@ AM62AX_IOPAD(0x1f8, PIN_INPUT_PULLUP, 0) /* (AC2) MMC0_DAT7 */ main_mmc1_pins_default: main-mmc1-default-pins { pinctrl-single,pins = < AM62AX_IOPAD(0x23c, PIN_INPUT, 0) /* (A21) MMC1_CMD */ - AM62AX_IOPAD(0x234, PIN_INPUT, 0) /* (B22) MMC1_CLK */ + AM62AX_IOPAD(0x234, PIN_OUTPUT, 0) /* (B22) MMC1_CLK */ AM62AX_IOPAD(0x230, PIN_INPUT, 0) /* (A22) MMC1_DAT0 */ AM62AX_IOPAD(0x22c, PIN_INPUT, 0) /* (B21) MMC1_DAT1 */ AM62AX_IOPAD(0x228, PIN_INPUT, 0) /* (C21) MMC1_DAT2 */
Signature · 1 line
2.34.1
PATCH v4 5/15 arm64: dts: ti: k3-am62a-phycore-som: Set eMMC clock pin as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruj16 Rev. C: Table 12-257. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi +1 -1
@@ -120,7 +120,7 @@ AM62AX_IOPAD(0x15c, PIN_INPUT, 0) /* (V13) MDIO0_MDIO */ main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = < AM62AX_IOPAD(0x220, PIN_INPUT_PULLUP, 0) /* (Y6) MMC0_CMD */ - AM62AX_IOPAD(0x218, PIN_INPUT_PULLDOWN, 0) /* (AB7) MMC0_CLK */ + AM62AX_IOPAD(0x218, PIN_OUTPUT_PULLDOWN, 0) /* (AB7) MMC0_CLK */ AM62AX_IOPAD(0x214, PIN_INPUT_PULLUP, 0) /* (AA6) MMC0_DAT0 */ AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AB6) MMC0_DAT1 */ AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (Y7) MMC0_DAT2 */
Signature · 1 line
2.34.1
Re: [PATCH v4 05/15] arm64: dts: ti: k3-am62a-phycore-som: Set eMMC clock pin as OUTPUT
Quoted 9 lines · Judith Mendez
MMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from
PIN_INPUTtoPIN_OUTPUTto match documentation.[0] https://www.ti.com/lit/pdf/spruj16 Rev. C: Table 12-257. MMCSDi I/O Signals
Fixes d69383885576 ("arm64: dts: ti: Add basic support for phyBOARD-Lyra-AM62Ax")Cc <[email protected]>Signed-off-by Judith Mendez <[email protected]>
Quoted 17 lines
--- arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi +1
-1@@ -120,7 +120,7 @@ AM62AX_IOPAD(0x15c, PIN_INPUT, 0) /* (V13) MDIO0_MDIO */ main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = < AM62AX_IOPAD(0x220, PIN_INPUT_PULLUP, 0) /* (Y6) MMC0_CMD */ - AM62AX_IOPAD(0x218, PIN_INPUT_PULLDOWN, 0) /* (AB7) MMC0_CLK */ + AM62AX_IOPAD(0x218, PIN_OUTPUT_PULLDOWN, 0) /* (AB7) MMC0_CLK */ AM62AX_IOPAD(0x214, PIN_INPUT_PULLUP, 0) /* (AA6) MMC0_DAT0 */ AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AB6) MMC0_DAT1 */ AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (Y7) MMC0_DAT2 */
PATCH v4 6/15 arm64: dts: ti: k3-am62-lp-sk: Set eMMC clock pins as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts +1 -1
@@ -86,7 +86,7 @@ main_mmc0_pins_default: main-mmc0-default-pins { bootph-all; pinctrl-single,pins = < AM62X_IOPAD(0x220, PIN_INPUT, 0) /* (V3) MMC0_CMD */ - AM62X_IOPAD(0x218, PIN_INPUT, 0) /* (Y1) MMC0_CLK */ + AM62X_IOPAD(0x218, PIN_OUTPUT, 0) /* (Y1) MMC0_CLK */ AM62X_IOPAD(0x214, PIN_INPUT, 0) /* (V2) MMC0_DAT0 */ AM62X_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (V1) MMC0_DAT1 */ AM62X_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (W2) MMC0_DAT2 */
Signature · 1 line
2.34.1
PATCH v4 7/15 arm64: dts: ti: k3-am62-pocketbeagle2: Set SD clock pin as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts +1 -1
@@ -235,7 +235,7 @@ AM62X_IOPAD(0x0020, PIN_OUTPUT, 3) /* (J25) OSPI0_D5.UART6_TXD */ main_mmc1_pins_default: main-mmc1-default-pins { pinctrl-single,pins = < AM62X_IOPAD(0x23c, PIN_INPUT, 0) /* (A21/C18) MMC1_CMD */ - AM62X_IOPAD(0x234, PIN_INPUT, 0) /* (B22/A20) MMC1_CLK */ + AM62X_IOPAD(0x234, PIN_OUTPUT, 0) /* (B22/A20) MMC1_CLK */ AM62X_IOPAD(0x230, PIN_INPUT, 0) /* (A22/A19) MMC1_DAT0 */ AM62X_IOPAD(0x22c, PIN_INPUT, 0) /* (B21/B19) MMC1_DAT1 */ AM62X_IOPAD(0x228, PIN_INPUT, 0) /* (C21/B20) MMC1_DAT2 */
Signature · 1 line
2.34.1
PATCH v4 8/15 arm64: dts: ti: k3-am625-beagleplay: Set MMC clock pins as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts +3 -3
@@ -323,7 +323,7 @@ emmc_pins_default: emmc-default-pins { bootph-all; pinctrl-single,pins = < AM62X_IOPAD(0x0220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ - AM62X_IOPAD(0x0218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ + AM62X_IOPAD(0x0218, PIN_OUTPUT, 0) /* (AB1) MMC0_CLK */ AM62X_IOPAD(0x0214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ AM62X_IOPAD(0x0210, PIN_INPUT, 0) /* (AA1) MMC0_DAT1 */ AM62X_IOPAD(0x020c, PIN_INPUT, 0) /* (AA3) MMC0_DAT2 */
@@ -346,7 +346,7 @@ sd_pins_default: sd-default-pins { bootph-all; pinctrl-single,pins = < AM62X_IOPAD(0x023c, PIN_INPUT, 0) /* (A21) MMC1_CMD */ - AM62X_IOPAD(0x0234, PIN_INPUT, 0) /* (B22) MMC1_CLK */ + AM62X_IOPAD(0x0234, PIN_OUTPUT, 0) /* (B22) MMC1_CLK */ AM62X_IOPAD(0x0230, PIN_INPUT, 0) /* (A22) MMC1_DAT0 */ AM62X_IOPAD(0x022c, PIN_INPUT, 0) /* (B21) MMC1_DAT1 */ AM62X_IOPAD(0x0228, PIN_INPUT, 0) /* (C21) MMC1_DAT2 */
@@ -358,7 +358,7 @@ AM62X_IOPAD(0x0240, PIN_INPUT, 7) /* (D17) MMC1_SDCD.GPIO1_48 */ wifi_pins_default: wifi-default-pins { pinctrl-single,pins = < AM62X_IOPAD(0x0120, PIN_INPUT, 0) /* (C24) MMC2_CMD */ - AM62X_IOPAD(0x0118, PIN_INPUT, 0) /* (D25) MMC2_CLK */ + AM62X_IOPAD(0x0118, PIN_OUTPUT, 0) /* (D25) MMC2_CLK */ AM62X_IOPAD(0x0114, PIN_INPUT, 0) /* (B24) MMC2_DAT0 */ AM62X_IOPAD(0x0110, PIN_INPUT, 0) /* (C25) MMC2_DAT1 */ AM62X_IOPAD(0x010c, PIN_INPUT, 0) /* (E23) MMC2_DAT2 */
Signature · 1 line
2.34.1
PATCH v4 9/15 arm64: dts: ti: k3-am62x-sk-common: Set SD clock pin as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi +1 -1
@@ -194,7 +194,7 @@ main_mmc1_pins_default: main-mmc1-default-pins { bootph-all; pinctrl-single,pins = < AM62X_IOPAD(0x23c, PIN_INPUT, 0) /* (A21/C18) MMC1_CMD */ - AM62X_IOPAD(0x234, PIN_INPUT, 0) /* (B22/A20) MMC1_CLK */ + AM62X_IOPAD(0x234, PIN_OUTPUT, 0) /* (B22/A20) MMC1_CLK */ AM62X_IOPAD(0x230, PIN_INPUT, 0) /* (A22/A19) MMC1_DAT0 */ AM62X_IOPAD(0x22c, PIN_INPUT, 0) /* (B21/B19) MMC1_DAT1 */ AM62X_IOPAD(0x228, PIN_INPUT, 0) /* (C21/B20) MMC1_DAT2 */
Signature · 1 line
2.34.1
PATCH v4 10/15 arm64: dts: ti: k3-am625-sk-common: Set eMMC clock pin as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am625-sk-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am625-sk-common.dtsi +1 -1
@@ -98,7 +98,7 @@ main_mmc0_pins_default: main-mmc0-default-pins { bootph-all; pinctrl-single,pins = < AM62X_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ - AM62X_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ + AM62X_IOPAD(0x218, PIN_OUTPUT, 0) /* (AB1) MMC0_CLK */ AM62X_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ AM62X_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1) MMC0_DAT1 */ AM62X_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3) MMC0_DAT2 */
Signature · 1 line
2.34.1
PATCH v4 11/15 arm64: dts: ti: k3-am62-phycore-som: Set eMMC clock pin as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi +1 -1
@@ -153,7 +153,7 @@ AM62X_IOPAD(0x15c, PIN_INPUT, 0) /* (AB22) MDIO0_MDIO */ main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = < AM62X_IOPAD(0x220, PIN_INPUT_PULLUP, 0) /* (Y3) MMC0_CMD */ - AM62X_IOPAD(0x218, PIN_INPUT_PULLDOWN, 0) /* (AB1) MMC0_CLK */ + AM62X_IOPAD(0x218, PIN_OUTPUT_PULLDOWN, 0) /* (AB1) MMC0_CLK */ AM62X_IOPAD(0x214, PIN_INPUT_PULLUP, 0) /* (AA2) MMC0_DAT0 */ AM62X_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1) MMC0_DAT1 */ AM62X_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3) MMC0_DAT2 */
Signature · 1 line
2.34.1
Re: [PATCH v4 11/15] arm64: dts: ti: k3-am62-phycore-som: Set eMMC clock pin as OUTPUT
Quoted 9 lines · Judith Mendez
MMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from
PIN_INPUTtoPIN_OUTPUTto match documentation.[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
Fixes 3443c1c4ed61 ("arm64: dts: ti: Add basic support for phyBOARD-Lyra-AM625")Cc <[email protected]>Signed-off-by Judith Mendez <[email protected]>
Quoted 17 lines
--- arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi +1
-1@@ -153,7 +153,7 @@ AM62X_IOPAD(0x15c, PIN_INPUT, 0) /* (AB22) MDIO0_MDIO */ main_mmc0_pins_default: main-mmc0-default-pins { pinctrl-single,pins = < AM62X_IOPAD(0x220, PIN_INPUT_PULLUP, 0) /* (Y3) MMC0_CMD */ - AM62X_IOPAD(0x218, PIN_INPUT_PULLDOWN, 0) /* (AB1) MMC0_CLK */ + AM62X_IOPAD(0x218, PIN_OUTPUT_PULLDOWN, 0) /* (AB1) MMC0_CLK */ AM62X_IOPAD(0x214, PIN_INPUT_PULLUP, 0) /* (AA2) MMC0_DAT0 */ AM62X_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1) MMC0_DAT1 */ AM62X_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3) MMC0_DAT2 */
PATCH v4 12/15 arm64: dts: ti: k3-am625-tqma62xx: Set MMC clock pins as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am625-tqma62xx-mba62xx.dts | 4 ++-- arch/arm64/boot/dts/ti/k3-am625-tqma62xx.dtsi | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am625-tqma62xx-mba62xx.dts +2 -2
@@ -735,7 +735,7 @@ main_mmc1_pins: main-mmc1-pins { /* (A21) MMC1_CMD */ AM62X_IOPAD(0x23c, PIN_INPUT, 0) /* (B22) MMC1_CLK */ - AM62X_IOPAD(0x234, PIN_INPUT, 0) + AM62X_IOPAD(0x234, PIN_OUTPUT, 0) /* (A22) MMC1_DAT0 */ AM62X_IOPAD(0x230, PIN_INPUT, 0) /* (B21) MMC1_DAT1 */
@@ -755,7 +755,7 @@ main_mmc2_pins: main-mmc2-pins { /* (C24) MMC2_CMD */ AM62X_IOPAD(0x120, PIN_INPUT, 0) /* (D25) MMC2_CLK */ - AM62X_IOPAD(0x118, PIN_INPUT, 0) + AM62X_IOPAD(0x118, PIN_OUTPUT, 0) /* (B24) MMC2_DAT0 */ AM62X_IOPAD(0x114, PIN_INPUT, 0) /* (C25) MMC2_DAT1 */
arch/arm64/boot/dts/ti/k3-am625-tqma62xx.dtsi +1 -1
@@ -299,7 +299,7 @@ main_mmc0_pins: main-mmc0-pins { /* (Y3) MMC0_CMD */ AM62X_IOPAD(0x220, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ - AM62X_IOPAD(0x218, PIN_INPUT, 0) + AM62X_IOPAD(0x218, PIN_OUTPUT, 0) /* (AA2) MMC0_DAT0 */ AM62X_IOPAD(0x214, PIN_INPUT, 0) /* (AA1) MMC0_DAT1 */
Signature · 1 line
2.34.1
PATCH v4 13/15 arm64: dts: ti: k3-am625-var-som-symphony: Set SD clock pins as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am625-var-som-symphony.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am625-var-som-symphony.dts +1 -1
@@ -391,7 +391,7 @@ pinctrl_mmc1: main-mmc1-default-pins { bootph-all; pinctrl-single,pins = < AM62X_IOPAD(0x23c, PIN_INPUT, 0) /* (A21) MMC1_CMD */ - AM62X_IOPAD(0x234, PIN_INPUT, 0) /* (B22) MMC1_CLK */ + AM62X_IOPAD(0x234, PIN_OUTPUT, 0) /* (B22) MMC1_CLK */ AM62X_IOPAD(0x230, PIN_INPUT, 0) /* (A22) MMC1_DAT0 */ AM62X_IOPAD(0x22c, PIN_INPUT, 0) /* (B21) MMC1_DAT1 */ AM62X_IOPAD(0x228, PIN_INPUT, 0) /* (C21) MMC1_DAT2 */
Signature · 1 line
2.34.1
Re: [PATCH v4 13/15] arm64: dts: ti: k3-am625-var-som-symphony: Set SD clock pins as OUTPUT
Quoted 20 lines
MMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from
PIN_INPUTtoPIN_OUTPUTto match documentation.[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
Fixes acb4cd35dbd2 ("arm64: dts: ti: var-som-am62: Add support for Variscite Symphony Board")Cc <[email protected]>Signed-off-by Judith Mendez <[email protected]>---
arch/arm64/boot/dts/ti/k3-am625-var-som-symphony.dts | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/ti/k3-am625-var-som-symphony.dts +0
-0@@ -391,7 +391,7 @@ pinctrl_mmc1: main-mmc1-default-pins { bootph-all;pinctrl-single,pins = <
Quoted 8 lines
AM62X_IOPAD(0x23c, PIN_INPUT, 0)/* (A21)MMC1_CMD*/ -AM62X_IOPAD(0x234, PIN_INPUT, 0)/* (B22)MMC1_CLK*/ +AM62X_IOPAD(0x234, PIN_OUTPUT, 0)/* (B22)MMC1_CLK*/AM62X_IOPAD(0x230, PIN_INPUT, 0)/* (A22)MMC1_DAT0*/AM62X_IOPAD(0x22c, PIN_INPUT, 0)/* (B21)MMC1_DAT1*/AM62X_IOPAD(0x228, PIN_INPUT, 0)/* (C21)MMC1_DAT2*/ --
2.34.1
Thanks!
PATCH v4 14/15 arm64: dts: ti: k3-am625-var-som: Set MMC clock pins as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi +2 -2
@@ -277,7 +277,7 @@ pinctrl_mmc0: main-mmc0-default-pins { bootph-all; pinctrl-single,pins = < AM62X_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ - AM62X_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ + AM62X_IOPAD(0x218, PIN_OUTPUT, 0) /* (AB1) MMC0_CLK */ AM62X_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ AM62X_IOPAD(0x210, PIN_INPUT, 0) /* (AA1) MMC0_DAT1 */ AM62X_IOPAD(0x20c, PIN_INPUT, 0) /* (AA3) MMC0_DAT2 */
@@ -292,7 +292,7 @@ AM62X_IOPAD(0x1f8, PIN_INPUT, 0) /* (AC2) MMC0_DAT7 */ pinctrl_mmc2: main-mmc2-default-pins { pinctrl-single,pins = < AM62X_IOPAD(0x120, PIN_INPUT_PULLUP, 0) /* (C24) MMC2_CMD */ - AM62X_IOPAD(0x118, PIN_INPUT_PULLDOWN, 0) /* (D25) MMC2_CLK */ + AM62X_IOPAD(0x118, PIN_OUTPUT_PULLDOWN, 0) /* (D25) MMC2_CLK */ AM62X_IOPAD(0x114, PIN_INPUT_PULLUP, 0) /* (B24) MMC2_DAT0 */ AM62X_IOPAD(0x110, PIN_INPUT_PULLUP, 0) /* (C25) MMC2_DAT1 */ AM62X_IOPAD(0x10c, PIN_INPUT_PULLUP, 0) /* (E23) MMC2_DAT2 */
Signature · 1 line
2.34.1
Re: [PATCH v4 14/15] arm64: dts: ti: k3-am625-var-som: Set MMC clock pins as OUTPUT
Quoted 5 lines
MMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from
PIN_INPUTtoPIN_OUTPUTto match documentation.[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
---
arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi +0 -0
@@ -277,7 +277,7 @@ pinctrl_mmc0: main-mmc0-default-pins {
bootph-all;
pinctrl-single,pins = <
AM62X_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ - AM62X_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ + AM62X_IOPAD(0x218, PIN_OUTPUT, 0) /* (AB1) MMC0_CLK */ AM62X_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ AM62X_IOPAD(0x210, PIN_INPUT, 0) /* (AA1) MMC0_DAT1 */ AM62X_IOPAD(0x20c, PIN_INPUT, 0) /* (AA3) MMC0_DAT2 */ @@ -292,7 +292,7 @@ AM62X_IOPAD(0x1f8, PIN_INPUT, 0) /* (AC2) MMC0_DAT7 */
pinctrl_mmc2: main-mmc2-default-pins {
pinctrl-single,pins = <
AM62X_IOPAD(0x120, PIN_INPUT_PULLUP, 0) /* (C24) MMC2_CMD */ - AM62X_IOPAD(0x118, PIN_INPUT_PULLDOWN, 0) /* (D25) MMC2_CLK */ + AM62X_IOPAD(0x118, PIN_OUTPUT_PULLDOWN, 0) /* (D25) MMC2_CLK */ AM62X_IOPAD(0x114, PIN_INPUT_PULLUP, 0) /* (B24) MMC2_DAT0 */ AM62X_IOPAD(0x110, PIN_INPUT_PULLUP, 0) /* (C25) MMC2_DAT1 */ AM62X_IOPAD(0x10c, PIN_INPUT_PULLUP, 0) /* (E23) MMC2_DAT2 */ --
2.34.1
Thanks!
PATCH v4 15/15 arm64: dts: ti: k3-am62x-phyboard-lyra: Set SD clock pin as OUTPUT
In reply to Judith MendezMMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from PIN_INPUT to PIN_OUTPUT to match documentation.
[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
--- arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra.dtsi +1 -1
@@ -227,7 +227,7 @@ AM62X_IOPAD(0x068, PIN_INPUT, 3) /* (R21) GPMC0_AD11.MCASP2_AXR3 */ main_mmc1_pins_default: main-mmc1-default-pins { pinctrl-single,pins = < AM62X_IOPAD(0x23c, PIN_INPUT_PULLUP, 0) /* (A21) MMC1_CMD */ - AM62X_IOPAD(0x234, PIN_INPUT_PULLDOWN, 0) /* (B22) MMC1_CLK */ + AM62X_IOPAD(0x234, PIN_OUTPUT_PULLDOWN, 0) /* (B22) MMC1_CLK */ AM62X_IOPAD(0x230, PIN_INPUT_PULLUP, 0) /* (A22) MMC1_DAT0 */ AM62X_IOPAD(0x22c, PIN_INPUT_PULLUP, 0) /* (B21) MMC1_DAT1 */ AM62X_IOPAD(0x228, PIN_INPUT_PULLUP, 0) /* (C21) MMC1_DAT2 */
Signature · 1 line
2.34.1
Re: [PATCH v4 15/15] arm64: dts: ti: k3-am62x-phyboard-lyra: Set SD clock pin as OUTPUT
Quoted 9 lines · Judith Mendez
MMC clock pins must be configured as OUTPUT-only per TRM [0] with receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from
PIN_INPUTtoPIN_OUTPUTto match documentation.[0] https://www.ti.com/lit/pdf/spruiv7 Rev. C: Table 12-246. MMCSDi I/O Signals
Fixes f1b3adade045 ("arm64: dts: ti: Add am62x-phyboard-lyra carrier board")Cc <[email protected]>Signed-off-by Judith Mendez <[email protected]>
Quoted 17 lines
--- arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra.dtsi +1
-1@@ -227,7 +227,7 @@ AM62X_IOPAD(0x068, PIN_INPUT, 3) /* (R21) GPMC0_AD11.MCASP2_AXR3 */ main_mmc1_pins_default: main-mmc1-default-pins { pinctrl-single,pins = < AM62X_IOPAD(0x23c, PIN_INPUT_PULLUP, 0) /* (A21) MMC1_CMD */ - AM62X_IOPAD(0x234, PIN_INPUT_PULLDOWN, 0) /* (B22) MMC1_CLK */ + AM62X_IOPAD(0x234, PIN_OUTPUT_PULLDOWN, 0) /* (B22) MMC1_CLK */ AM62X_IOPAD(0x230, PIN_INPUT_PULLUP, 0) /* (A22) MMC1_DAT0 */ AM62X_IOPAD(0x22c, PIN_INPUT_PULLUP, 0) /* (B21) MMC1_DAT1 */ AM62X_IOPAD(0x228, PIN_INPUT_PULLUP, 0) /* (C21) MMC1_DAT2 */
Hey Judith,
Thanks for the series.
Quoted 41 lines · Judith Mendez
This series fixes MMC pin input/output and pullup/pulldown settings across AM62*, AM62AX, and AM62LX boards.
All patches have been tested on their appropriate SK & EVM boards. BeaglePlay and Pocketbeagle boards have also been tested.
Changes since v3:
- IncludePIN_OUTPUTfixes for missing third-party boards as per Sashiko review [0]
- Split out squashed patches into separate commits as per Nishanth's review [1][0] https://lore.kernel.org/linux-devicetree/[email protected]/
& https://lore.kernel.org/linux-devicetree/[email protected]/[1] https://lore.kernel.org/linux-devicetree/20260904151335.fi5mvjpvziw2g3r2@exemption/
Link to v1:
https://lore.kernel.org/linux-devicetree/[email protected]/
Link to v2:
https://lore.kernel.org/linux-devicetree/[email protected]/
Link to v3:
https://lore.kernel.org/linux-devicetree/[email protected]/Judith Mendez (15):
arm64: dts: ti: k3-am62a: FixMMC0_CLKregister address
arm64: dts: ti: k3-am62l-evm: Remove unnecessary internal pullups for
MMC0
arm64: dts: ti: k3-am62a7-sk: Set eMMC clock pin as OUTPUT
arm64: dts: ti: k3-am62a7-sk: Set SD clock pin as OUTPUT
arm64: dts: ti: k3-am62a-phycore-som: Set eMMC clock pin as OUTPUT
arm64: dts: ti: k3-am62-lp-sk: Set eMMC clock pins as OUTPUT
arm64: dts: ti: k3-am62-pocketbeagle2: Set SD clock pin as OUTPUT
arm64: dts: ti: k3-am625-beagleplay: Set MMC clock pins as OUTPUT
arm64: dts: ti: k3-am62x-sk-common: Set SD clock pin as OUTPUT
arm64: dts: ti: k3-am625-sk-common: Set eMMC clock pin as OUTPUT
arm64: dts: ti: k3-am62-phycore-som: Set eMMC clock pin as OUTPUT
arm64: dts: ti: k3-am625-tqma62xx: Set MMC clock pins as OUTPUT
arm64: dts: ti: k3-am625-var-som-symphony: Set SD clock pins as OUTPUT
arm64: dts: ti: k3-am625-var-som: Set MMC clock pins as OUTPUT
arm64: dts: ti: k3-am62x-phyboard-lyra: Set SD clock pin as OUTPUT
Quoted 15 lines
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 2 +- arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts | 2 +- arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 6 +++--- arch/arm64/boot/dts/ti/k3-am625-sk-common.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am625-tqma62xx-mba62xx.dts | 4 ++-- arch/arm64/boot/dts/ti/k3-am625-tqma62xx.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am625-var-som-symphony.dts | 2 +- arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi | 4 ++-- arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 5 ++--- arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++-- arch/arm64/boot/dts/ti/k3-am62x-phyboard-lyra.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 +- 14 files changed, 20 insertions(+), 21 deletions(-)
For the whole series:
Regards,
Moteen
Hi Judith Mendez,
Quoted 6 lines · Judith Mendez
This series fixes MMC pin input/output and pullup/pulldown settings across AM62*, AM62AX, and AM62LX boards.
All patches have been tested on their appropriate SK & EVM boards. BeaglePlay and Pocketbeagle boards have also been tested.
Quoted 7 lines
Changes since v3:
- IncludePIN_OUTPUTfixes for missing third-party boards as per Sashiko review [0]
- Split out squashed patches into separate commits as per Nishanth's review [1][...]
I have applied the following to branch ti-k3-dts-next on [1].
Just a future note for cover-letter $subject, use "arm64: dts: ti:" as prefix
Thank you!
[01/15] arm64: dts: ti: k3-am62a: Fix MMC0_CLK register address
commit: 9852f2badc438de82b6828c11c80ef0a656f1d4d
[02/15] arm64: dts: ti: k3-am62l-evm: Remove unnecessary internal pullups for MMC0
commit: dfba8329b8ebd49807ed1c1b336992e5791c7e48
[03/15] arm64: dts: ti: k3-am62a7-sk: Set eMMC clock pin as OUTPUT
commit: aa7d5b1efa75e58c9d440dfd720205045fe6a806
[04/15] arm64: dts: ti: k3-am62a7-sk: Set SD clock pin as OUTPUT
commit: cfad4f39124b218c2cbbbe17e742971abc9ac8b4
[05/15] arm64: dts: ti: k3-am62a-phycore-som: Set eMMC clock pin as OUTPUT
commit: 4834050197f205a649e36661ca150e6ac8295008
[06/15] arm64: dts: ti: k3-am62-lp-sk: Set eMMC clock pins as OUTPUT
commit: 156f4c2208c8e5e04002402494de28c21c0afcbc
[07/15] arm64: dts: ti: k3-am62-pocketbeagle2: Set SD clock pin as OUTPUT
commit: 843c4d171975059eaa1436c8403d9a29f677a75c
[08/15] arm64: dts: ti: k3-am625-beagleplay: Set MMC clock pins as OUTPUT
commit: c074abebc76f0e59d13dea499f582806c6a3d94d
[09/15] arm64: dts: ti: k3-am62x-sk-common: Set SD clock pin as OUTPUT
commit: 1e2e5016bda94b2bcd86258b5eb77fe3006639a0
[10/15] arm64: dts: ti: k3-am625-sk-common: Set eMMC clock pin as OUTPUT
commit: 8ef8a0e38d1377c6d51c06f95c64d87641b2c717
[11/15] arm64: dts: ti: k3-am62-phycore-som: Set eMMC clock pin as OUTPUT
commit: a3c2b6c52e02d58941c0b91bfba052788aeff890
[12/15] arm64: dts: ti: k3-am625-tqma62xx: Set MMC clock pins as OUTPUT
commit: f9a93fe78d8737860a8fb786d17c9dff20782b7d
[13/15] arm64: dts: ti: k3-am625-var-som-symphony: Set SD clock pins as OUTPUT
commit: dbe55d5f2930b27e9a3ce71f0c9b1bb0ad91a012
[14/15] arm64: dts: ti: k3-am625-var-som: Set MMC clock pins as OUTPUT
commit: b489fa1808ea807c4467def7947c83d896dfc355
[15/15] arm64: dts: ti: k3-am62x-phyboard-lyra: Set SD clock pin as OUTPUT
commit: 1d62ef8d47b535d31fb9cf38e5c36eb55b0189a4All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
Signature · 4 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D https://ti.com/opensource