Skip to contentSkip to conversation

liveupdate: Add documentation for file dependencies

PATCH Applied Samiullah Khawaja 3 participants 4 messages Sep 10 – Sep 14

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover liveupdate: Add documentation for file dependencies

I sent out v3 of liveupdate_get_file_incoming() and liveupdate_get_token_outgoing() series to add documentation for dependencies.

https://lore.kernel.org/all/[email protected]/

But since v2 of that series is already merged into kho/next, I am sending the documentation as a separate patch.

Changelog:

v2:
- Rebased on liveupdate next branch.
- Fixed documentation.

Samiullah Khawaja (1):
liveupdate: luo_file: Add documentation for dependencies

 kernel/liveupdate/luo_file.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

base-commit: 945d61765894dda2f0344de50cb1ade2e51b66fd

Signature · 1 line
2.55.0.1032.g73a4cd73de-goog
#1 lore raw

PATCH v2 1/1 liveupdate: luo_file: Add documentation for dependencies

Add documentation for dependencies between FDs preserved by file handlers. This supplements the previously added liveupdate_get_token_outgoing() and liveupdate_get_file_incoming() internal APIs to allow file handlers to resolve dependencies.

---
 kernel/liveupdate/luo_file.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
kernel/liveupdate/luo_file.c +15 -0
index dbae0715220b..a39992da504f 100644
@@ -91,6 +91,21 @@
  *    again later. If the issue cannot be resolved, these resources will be held
  *    by LUO until the next live update cycle, at which point they will be
  *    discarded.
+ *
+ * Dependencies:
+ *
+ * Preserved files may have dependencies on other files that also need to be
+ * preserved during a live update. A file handler can resolve these dependencies
+ * by querying the token of the dependency. That token can then be serialized
+ * and used to fetch the dependency during the .retrieve() callback in the next
+ * kernel.
+ *
+ * Some of these dependencies can be resolved late during file handler's
+ * .freeze() callback, but some of these might need resolution during file
+ * handler's .preserve() callback based on constraints such as immutability and
+ * performance. This introduces an order of preservation. Note that the order of
+ * preservation of dependencies can be safely relaxed later, but it cannot be
+ * enforced later.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Signature · 1 line
2.55.0.1032.g73a4cd73de-goog
#2 lore raw

Re: [PATCH v2 1/1] liveupdate: luo_file: Add documentation for dependencies

Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines

Add documentation for dependencies between FDs preserved by file handlers. This supplements the previously added liveupdate_get_token_outgoing() and liveupdate_get_file_incoming() internal APIs to allow file handlers to resolve dependencies.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
maintainer Applied
#3 lore raw
In reply to Samiullah Khawaja
Quoted 9 lines · Samiullah Khawaja

liveupdate: Add documentation for file dependencies

I sent out v3 of liveupdate_get_file_incoming() and liveupdate_get_token_outgoing() series to add documentation for dependencies.

https://lore.kernel.org/all/[email protected]/

[...]

Applied to luo-internal-api branch of liveupdate/linux.git tree, thanks!

[1/1] liveupdate: luo_file: Add documentation for dependencies

      commit: 38dd32f08d19beb441f202e61d9dfede3b7f055b

tree: https://git.kernel.org/pub/scm/linux/kernel/git/liveupdate/linux
branch: luo-internal-api

--
Sincerely yours,
Mike.