dt-bindings: display: panel: mipi-dbi-spi: add st7789v-tft28
Subsystems (5)
PATCH 1/1 dt-bindings: display: panel: mipi-dbi-spi: add st7789v-tft28
This is a generic 2.8" 240x320 RGB LCD panel with a MIPI DBI compatible SPI interface, based on the Sitronix ST7789V controller. It is commonly sold by various resellers without an identifiable original manufacturer name printed on the PCB.
A basic mipi-dbi-cmd[1] script to get the display running looks like this:
$ cat st7789v-tft28.txt command 0x11 delay 120 command 0x3a 0x55 command 0xb2 0x05 0x05 0x00 0x33 0x33 command 0xb7 0x75 command 0xc2 0x01 0xff command 0xc3 0x13 command 0xc4 0x20 command 0xbb 0x22 command 0xc5 0x20 command 0xd0 0xa4 0xa1 command 0xe0 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x44 0x45 0x0f 0x17 0x16 0x2b 0x33 command 0xe1 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x43 0x45 0x0f 0x16 0x16 0x2b 0x33 command 0x36 0x00 command 0x29 command 0x21
$ mipi-dbi-cmd st7789v-tft28.bin st7789v-tft28.txt
Tested on a Raspberry Pi 4B using the panel-mipi-dbi driver.
[1]: https://github.com/notro/panel-mipi-dbi
--- .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +1 -0
@@ -75,6 +75,7 @@ properties: - saef,sftc154b - sainsmart18 - shineworld,lh133k + - st7789v-tft28 - const: panel-mipi-dbi-spi reg:
Signature · 1 line
2.43.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added compatible string `st7789v-tft28` lacks a mandatory vendor prefix, violating…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added compatible string st7789v-tft28 lacks a mandatory vendor prefix, violating Devicetree specification rules. --
commit b9c6f3f7002bdc4087c21d6e0612fcb912f52747
Author: Enzo Frese <[email protected]>
dt-bindings: display: panel: mipi-dbi-spi: add st7789v-tft28
This commit adds a generic 2.8" 240x320 RGB LCD panel using the Sitronix ST7789V controller to the panel-mipi-dbi-spi binding.
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml properties: · line 78
Quoted 9 lines
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +1
-0@@ -75,6 +75,7 @@ properties: - saef,sftc154b - sainsmart18 - shineworld,lh133k + - st7789v-tft28
[Severity: Low]
Does this compatible string violate the Devicetree specification rules by missing a mandatory vendor prefix?
Modern dt-schema checks require compatible strings to be in the format <vendor>,<device> to prevent global namespace pollution. Since this string lacks a comma and an approved vendor prefix (such as sitronix,st7789v-tft28 or panel,st7789v-tft28), will this cause dt_binding_check to fail validation?
Quoted 3 lines
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +0
-0- const: panel-mipi-dbi-spi reg:
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 42 lines · Enzo Frese
This is a generic 2.8" 240x320 RGB LCD panel with a MIPI DBI compatible SPI interface, based on the Sitronix ST7789V controller. It is commonly sold by various resellers without an identifiable original manufacturer name printed on the PCB.
A basic mipi-dbi-cmd[1] script to get the display running looks like this:
$ cat st7789v-tft28.txt command 0x11 delay 120 command 0x3a 0x55 command 0xb2 0x05 0x05 0x00 0x33 0x33 command 0xb7 0x75 command 0xc2 0x01 0xff command 0xc3 0x13 command 0xc4 0x20 command 0xbb 0x22 command 0xc5 0x20 command 0xd0 0xa4 0xa1 command 0xe0 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x44 0x45 0x0f 0x17 0x16 0x2b 0x33 command 0xe1 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x43 0x45 0x0f 0x16 0x16 0x2b 0x33 command 0x36 0x00 command 0x29 command 0x21$ mipi-dbi-cmd st7789v-tft28.bin st7789v-tft28.txtTested on a Raspberry Pi 4B using the panel-mipi-dbi driver.
[1]: https://github.com/notro/panel-mipi-dbi
Signed-off-by Enzo Frese <[email protected]>--- .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +0
-0
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml properties: · line 78
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +1
-0@@ -75,6 +75,7 @@ properties: - saef,sftc154b - sainsmart18 - shineworld,lh133k + - st7789v-tft28
1. Where is any user of this? Why are you sending binding alone?
2. Does not follow compatible style at all - missing vendor prefix.
Best regards,
Krzysztof