hwmon: (gpio-fan) return IRQ_HANDLED from the shared alarm IRQ handler
PATCH v2 1/1 hwmon: (gpio-fan) return IRQ_HANDLED from the shared alarm IRQ handler
fan_alarm_irq_handler() always schedules alarm_work but returns IRQ_NONE, so the kernel treats every alarm interrupt as unhandled. On a shared line that risks the whole line being disabled as spurious.
v1 just fixed that, but it was still IRQF_SHARED, and always returning IRQ_HANDLED there defeats spurious-interrupt detection for the line -- if the interrupt ever fires without a real event, nothing catches it, and a fault could spin the CPU in the handler.
Sashiko flagged this in v1, and Guenter confirmed: this interrupt must not be shared. So v2 drops IRQF_SHARED too.
---
Changes in v2:
- Also drop IRQF_SHARED (Guenter): always returning IRQ_HANDLED on a still-shared line defeats spurious-interrupt detection for it. v2 is a full patch with both fixes, not a delta on top of v1.
drivers/hwmon/gpio-fan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/gpio-fan.c +2 -2
@@ -67,7 +67,7 @@ static irqreturn_t fan_alarm_irq_handler(int irq, void *dev_id)schedule_work (&fan_data->alarm_work); -return IRQ_NONE ; +return IRQ_HANDLED ; } static ssize_t fan1_alarm_show(struct device *dev,
@@ -97,7 +97,7 @@ static int fan_alarm_init(struct gpio_fan_data *fan_data)INIT_WORK (&fan_data->alarm_work, fan_alarm_notify);irq_set_irq_type (alarm_irq,IRQ_TYPE_EDGE_BOTH );return devm_request_irq (dev, alarm_irq, fan_alarm_irq_handler, -IRQF_SHARED ,"GPIO fan alarm" , fan_data); +0 ,"GPIO fan alarm" , fan_data); }/*
Signature · 1 line
2.25.1
Quoted 9 lines · Cong Nguyen
fan_alarm_irq_handler()always schedulesalarm_workbut returnsIRQ_NONE, so the kernel treats every alarm interrupt as unhandled. On a shared line that risks the whole line being disabled as spurious.v1 just fixed that, but it was still
IRQF_SHARED, and always returningIRQ_HANDLEDthere defeats spurious-interrupt detection for the line -- if the interrupt ever fires without a real event, nothing catches it, and a fault could spin the CPU in the handler.
Quoted 8 lines
Sashiko flagged this in v1, and Guenter confirmed: this interrupt must not be shared. So v2 drops
IRQF_SHAREDtoo.Fixes d6fe1360f42e ("hwmon: add generic GPIO fan driver")Reported-by Sashiko AI review <[email protected]>Assisted-by Claude:claude-opus-4Signed-off-by Cong Nguyen <[email protected]>
Applied.
Thanks,
Guenter