rapidio: mport_cdev: fix use-after-free in mport_mm_close()
Subsystems (2)
PATCH 1/1 rapidio: mport_cdev: fix use-after-free in mport_mm_close()
A use-after-free vulnerability was identified in mport_mm_close() in drivers/rapidio/devices/rio_mport_cdev.c, identical to the pattern previously addressed in dma_req_free().
This is observable from userspace when an application creates an mmap mapping via the RapidIO character device and subsequently unmaps it (or terminates, triggering exit_mmap()). During munmap, mport_mm_close() is invoked and drops the mapping reference via kref_put().
If kref_put() drops the last reference, mport_release_mapping() is called, which frees the underlying rio_mport_mapping structure. The subsequent mutex_unlock() then dereferences map->md to unlock buf_mutex, leading to a use-after-free:
mport_mm_close()
-> mutex_lock(&map->md->buf_mutex);
...
-> kref_put(&map->ref, mport_release_mapping); /* map is freed */
-> mutex_unlock(&map->md->buf_mutex); /* UAF: map used */Fix this by caching map->md before kref_put() and using the cached pointer for mutex unlocking, ensuring that freed memory is not accessed.
---
Note for Andrew:
Following up on the Sashiko review results you shared in the dma_req_free() thread (https://sashiko.dev/#/patchset/[email protected]),
I audited the reported pre-existing flaws and verified that this UAF in mport_mm_close() is a genuine bug with the identical locking pattern.
drivers/rapidio/devices/rio_mport_cdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/rapidio/devices/rio_mport_cdev.c +3 -2
@@ -2167,11 +2167,12 @@ static void mport_mm_open(struct vm_area_struct *vma)static void mport_mm_close (struct vm_area_struct *vma) {struct rio_mport_mapping *map = vma->vm_private_data; +struct mport_dev *md = map->md;rmcd_debug (MMAP ,"%pad" , &map->phys_addr); -mutex_lock (&map->md->buf_mutex); +mutex_lock (&md->buf_mutex);kref_put (&map->ref, mport_release_mapping); -mutex_unlock (&map->md->buf_mutex); +mutex_unlock (&md->buf_mutex); }static const struct vm_operations_struct vm_ops = {
Signature · 1 line
2.43.0
Quoted 14 lines · On Mon, 14 Sep 2026 13:23:27 +0900 James Kim <[email protected]> wrote:
A use-after-free vulnerability was identified in
mport_mm_close()indrivers/rapidio/devices/rio_mport_cdev.c, identical to the pattern previously addressed indma_req_free().This is observable from userspace when an application creates an mmap mapping via the RapidIO character device and subsequently unmaps it (or terminates, triggering
exit_mmap()). During munmap,mport_mm_close()is invoked and drops the mapping reference viakref_put().If
kref_put()drops the last reference,mport_release_mapping()is called, which frees the underlyingrio_mport_mappingstructure. The subsequentmutex_unlock()then dereferencesmap->mdto unlockbuf_mutex, leading to a use-after-free:
Quoted 9 lines
mport_mm_close() -> mutex_lock(&map->md->buf_mutex); ... -> kref_put(&map->ref, mport_release_mapping); /* map is freed */ -> mutex_unlock(&map->md->buf_mutex); /* UAF: map used */Fix this by caching
map->mdbeforekref_put()and using the cached pointer for mutex unlocking, ensuring that freed memory is not accessed.
Thanks.
Quoted 6 lines
Note for Andrew:
Following up on the Sashiko review results you shared in thedma_req_free()thread (https://sashiko.dev/#/patchset/[email protected]),
I audited the reported pre-existing flaws and verified that this UAF inmport_mm_close()is a genuine bug with the identical locking pattern.
Thanks again.
Sashiko blew another fuse over the rapidio driver:
https://sashiko.dev/#/patchset/[email protected]