Skip to contentSkip to conversation

package/rpi-rgb-led-matrix: propagate BR2_PACKAGE_GRAPHICSMAGICK dependency

PATCH Applied Thomas Petazzoni via buildroot 1 participant 3 messages Sep 14 – Sep 25

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rpi-rgb-led-matrix: propagate BR2_PACKAGE_GRAPHICSMAGICK dependency

BR2_PACKAGE_RPI_RGB_LED_MATRIX_IMAGE_VIEWER selects BR2_PACKAGE_GRAPHICSMAGICK, but did not propagate its BR2_USE_MMU dependency. This issue exists since the package was introduced in commit e821078031e14df69e5142f23e9cb7b5a1ea0e77.

It fixes the following Kconfig warning:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_GRAPHICSMAGICK
Depends on [n]: BR2_USE_MMU [=n] && BR2_TOOLCHAIN_HAS_THREADS [=y] Selected by [y]:
- BR2_PACKAGE_RPI_RGB_LED_MATRIX_IMAGE_VIEWER [=y] && BR2_PACKAGE_RPI_RGB_LED_MATRIX [=y]

which occurs when you configure an ARM noMMU FDPIC toolchain (because we have noMMU, but shared libraries, so rpi-rgb-led-matrix can be enabled).

Fixes e821078031e14df69e5142f23e9cb7b5a1ea0e77 ("package/rpi-rgb-led-matrix: new package")
---
 package/rpi-rgb-led-matrix/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/rpi-rgb-led-matrix/Config.in +1 -0
index ca945a92af..5088af3bf1 100644
@@ -16,6 +16,7 @@ if BR2_PACKAGE_RPI_RGB_LED_MATRIX
 
 config BR2_PACKAGE_RPI_RGB_LED_MATRIX_IMAGE_VIEWER
 	bool "Build led-image-viewer"
+	depends on BR2_USE_MMU
 	select BR2_PACKAGE_GRAPHICSMAGICK
 	help
 	  The image viewer reads all kinds of image formats,
Signature · 6 lines
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 13 lines · Thomas Petazzoni via buildroot

BR2_PACKAGE_RPI_RGB_LED_MATRIX_IMAGE_VIEWER selects BR2_PACKAGE_GRAPHICSMAGICK, but did not propagate its BR2_USE_MMU dependency. This issue exists since the package was introduced in commit e821078031e14df69e5142f23e9cb7b5a1ea0e77.

It fixes the following Kconfig warning:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_GRAPHICSMAGICK
Depends on [n]: BR2_USE_MMU [=n] && BR2_TOOLCHAIN_HAS_THREADS [=y] Selected by [y]:
- BR2_PACKAGE_RPI_RGB_LED_MATRIX_IMAGE_VIEWER [=y] &&
BR2_PACKAGE_RPI_RGB_LED_MATRIX [=y]

Quoted 6 lines

which occurs when you configure an ARM noMMU FDPIC toolchain (because we have noMMU, but shared libraries, so rpi-rgb-led-matrix can be enabled).

Fixes e821078031e14df69e5142f23e9cb7b5a1ea0e77 ("package/rpi-rgb-led-matrix: new package")

Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Thomas Petazzoni via buildroot

In reply of:

Quoted 12 lines

BR2_PACKAGE_RPI_RGB_LED_MATRIX_IMAGE_VIEWER selects BR2_PACKAGE_GRAPHICSMAGICK, but did not propagate its BR2_USE_MMU dependency. This issue exists since the package was introduced in commit e821078031e14df69e5142f23e9cb7b5a1ea0e77.

It fixes the following Kconfig warning:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_GRAPHICSMAGICK
Depends on [n]: BR2_USE_MMU [=n] && BR2_TOOLCHAIN_HAS_THREADS [=y] Selected by [y]:
- BR2_PACKAGE_RPI_RGB_LED_MATRIX_IMAGE_VIEWER [=y] && BR2_PACKAGE_RPI_RGB_LED_MATRIX [=y]

Quoted 6 lines

which occurs when you configure an ARM noMMU FDPIC toolchain (because we have noMMU, but shared libraries, so rpi-rgb-led-matrix can be enabled).

Fixes e821078031e14df69e5142f23e9cb7b5a1ea0e77 ("package/rpi-rgb-led-matrix: new package")

Applied to 2025.02.x, 2026.08.x. Thanks

Quoted 9 lines
---
 package/rpi-rgb-led-matrix/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/rpi-rgb-led-matrix/Config.in +0 -0
index ca945a92af..5088af3bf1 100644

package/rpi-rgb-led-matrix/Config.in if BR2_PACKAGE_RPI_RGB_LED_MATRIX · line 22

Quoted 7 lines
package/rpi-rgb-led-matrix/Config.in +1 -0
@@ -16,6 +16,7 @@ if BR2_PACKAGE_RPI_RGB_LED_MATRIX
 
 config BR2_PACKAGE_RPI_RGB_LED_MATRIX_IMAGE_VIEWER
 	bool "Build led-image-viewer"
+	depends on BR2_USE_MMU
 	select BR2_PACKAGE_GRAPHICSMAGICK
 	help
 	  The image viewer reads all kinds of image formats,

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot