Skip to contentSkip to conversation

scsi: devinfo: add BLIST_SKIP_IO_HINTS for EMC Symmetrix

PATCH Applied Ewan D. Milne 3 participants 3 messages Sep 15 – Sep 17 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: devinfo: add BLIST_SKIP_IO_HINTS for EMC Symmetrix

EMC Symmetrix returns an error on MODE SENSE for page 0Ah subpage 05h because it does not implement the SBC-5 I/O hints. These commands began to be sent as a result of commit 4f53138fffc2 ("scsi: sd: Translate data lifetime information"). Add BLIST_SKIP_IO_HINTS to avoid sending these commands because in large configurations the failed commands are displacing other useful information in internal error logs.

---
 drivers/scsi/scsi_devinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_devinfo.c +1 -1
index 2bccadf4f22f..cfc259fd0141 100644
@@ -161,7 +161,7 @@ static struct {
 	{"DGC", "DISK", NULL, BLIST_SPARSELUN},	/* EMC CLARiiON, no storage on LUN 0 */
 	{"EMC",  "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 	{"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN |
-	 BLIST_REPORTLUN2 | BLIST_RETRY_ITF},
+	 BLIST_REPORTLUN2 | BLIST_RETRY_ITF | BLIST_SKIP_IO_HINTS},
 	{"EMULEX", "MD21/S2     ESDI", NULL, BLIST_SINGLELUN},
 	{"easyRAID", "16P", NULL, BLIST_NOREPORTLUN},
 	{"easyRAID", "X6P", NULL, BLIST_NOREPORTLUN},
Signature · 1 line
2.47.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Ewan D. Milne

EMC Symmetrix returns an error on MODE SENSE for page 0Ah subpage 05h because it does not implement the SBC-5 I/O hints.  These commands began to be sent as a result of commit 4f53138fffc2 ("scsi: sd:
Translate
data lifetime information").  Add BLIST_SKIP_IO_HINTS to avoid sending
these commands because in large configurations the failed commands are
displacing other useful information in internal error logs.

---
 drivers/scsi/scsi_devinfo.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_devinfo.c +0 -0
index 2bccadf4f22f..cfc259fd0141 100644
@@ -161,7 +161,7 @@ static struct {

  {"DGC", "DISK", NULL, BLIST_SPARSELUN}, /* EMC
CLARiiON, no storage on LUN 0 */
  {"EMC",  "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN |

drivers/scsi/scsi_devinfo.c +1 -1
-	 BLIST_REPORTLUN2 | BLIST_RETRY_ITF},
+	 BLIST_REPORTLUN2 | BLIST_RETRY_ITF | BLIST_SKIP_IO_HINTS},
Quoted 3 lines

  {"EMULEX", "MD21/S2     ESDI", NULL, BLIST_SINGLELUN}, {"easyRAID", "16P", NULL, BLIST_NOREPORTLUN}, {"easyRAID", "X6P", NULL, BLIST_NOREPORTLUN},

Looks good

maintainer Applied
#2 lore raw
In reply to Ewan D. Milne
Quoted 8 lines · Ewan D. Milne

EMC Symmetrix returns an error on MODE SENSE for page 0Ah subpage 05h because it does not implement the SBC-5 I/O hints. These commands began to be sent as a result of commit 4f53138fffc2 ("scsi: sd: Translate data lifetime information"). Add BLIST_SKIP_IO_HINTS to avoid sending these commands because in large configurations the failed commands are displacing other useful information in internal error logs.

[...]

Applied to 7.3/scsi-fixes, thanks!

[1/1] scsi: devinfo: add BLIST_SKIP_IO_HINTS for EMC Symmetrix

      https://git.kernel.org/mkp/scsi/c/f06a44e235ef
Signature · 1 line
Martin K. Petersen