Skip to contentSkip to conversation

dmaengine: ste_dma40: allow COMPILE_TEST

PATCH Superseded Rosen Penev 3 participants 3 messages Sep 16 – Sep 17 dmaengine

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rosen Penev

author
#0 lore raw

PATCH 1/1 dmaengine: ste_dma40: allow COMPILE_TEST

The driver only uses portable kernel APIs and AMBA bit-field macros from <linux/amba/bus.h>. Allow building on other architectures via COMPILE_TEST for wider compile coverage.

Signed-off-by Rosen Penev <[email protected]>
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/Kconfig +1 -1
index ae6a682c9f76..f16bd4059d84 100644
@@ -559,7 +559,7 @@ config SOPHGO_CV1800B_DMAMUX
 
 config STE_DMA40
 	bool "ST-Ericsson DMA40 support"
-	depends on ARCH_U8500
+	depends on ARCH_U8500 || COMPILE_TEST
 	select DMA_ENGINE
 	select SRAM
 	help
Signature · 1 line
2.55.0
AI review
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] kconfig: STE_DMA40 missing HAS_IOMEM dependency for COMPILE_TEST --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: STE_DMA40 missing HAS_IOMEM dependency for COMPILE_TEST
--

commit f5b43b7cb15b71f44f87940150c9d52817cad404
Author: Rosen Penev <[email protected]>

dmaengine: ste_dma40: allow COMPILE_TEST

This commit loosens the Kconfig dependencies for STE_DMA40 to allow building on other architectures via COMPILE_TEST. It aims to increase compile coverage by exposing the driver to more build configurations.

drivers/dma/Kconfig config SOPHGO_CV1800B_DMAMUX · line 564

Quoted 12 lines
drivers/dma/Kconfig +1 -1
index ae6a682c9f769..f16bd4059d84a 100644
@@ -559,7 +559,7 @@ config SOPHGO_CV1800B_DMAMUX
 
 config STE_DMA40
 	bool "ST-Ericsson DMA40 support"
-	depends on ARCH_U8500
+	depends on ARCH_U8500 || COMPILE_TEST
 	select DMA_ENGINE
 	select SRAM

[Severity: Low]
Does this also need a dependency on HAS_IOMEM?

By allowing COMPILE_TEST in drivers/dma/Kconfig for STE_DMA40 and keeping the select for SRAM, architectures without HAS_IOMEM (like User-Mode Linux or some s390 configurations) will trigger unmet dependency build warnings for SRAM when COMPILE_TEST is enabled.

This can also lead to compilation failures on those architectures due to missing I/O memory accessors like readl or writel that SRAM might depend on.

Could this be resolved by making STE_DMA40 depend on HAS_IOMEM?

Quoted 1 line
drivers/dma/Kconfig +0 -0
 	help
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rosen Penev
Quoted 6 lines · Rosen Penev

The driver only uses portable kernel APIs and AMBA bit-field macros from <linux/amba/bus.h>. Allow building on other architectures via COMPILE_TEST for wider compile coverage.

Signed-off-by Rosen Penev <[email protected]>

---

Reviewed-by Frank Li <[email protected]>
Quoted 19 lines
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/Kconfig +1 -2
index ae6a682c9f76..f16bd4059d84 100644
@@ -559,7 +559,7 @@ config SOPHGO_CV1800B_DMAMUX
 
 config STE_DMA40
 	bool "ST-Ericsson DMA40 support"
-	depends on ARCH_U8500
+	depends on ARCH_U8500 || COMPILE_TEST
 	select DMA_ENGINE
 	select SRAM
 	help
--

2.55.0