wifi: mt76: Fix of_node reference leak in mt76_get_rate_power_limits()
Subsystems (3)
PATCH 1/1 wifi: mt76: Fix of_node reference leak in mt76_get_rate_power_limits()
mt76_find_power_limits_node() and mt76_find_channel_node() return nodes with the reference held, but mt76_get_rate_power_limits() overwrites the "txpower-<band>" node reference and never releases the channel node reference, leaking both.
Drop the intermediate and the channel node reference on every exit path, and take a reference on the fallback node returned by mt76_find_power_limits_node() so the caller's of_node_put() is balanced.
Fixes 22b980badc0f ("mt76: add functions for parsing rate power limits from DT")
Signed-off-by Wentao Liang <[email protected]>
--- drivers/net/wireless/mediatek/mt76/eeprom.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-)
drivers/net/wireless/mediatek/mt76/eeprom.c +11 -5
@@ -231,7 +231,8 @@ mt76_find_power_limits_node(struct mt76_dev *dev)struct property *regd =of_find_property (cur,"regdomain" ,NULL );if (!country && !regd) { - fallback = cur; +of_node_put (fallback); + fallback =of_node_get (cur);continue ; }
@@ -429,7 +430,7 @@ s8 mt76_get_rate_power_limits(struct mt76_phy *phy, s8 target_power) {struct mt76_dev *dev = phy->dev; -struct device_node *np; +struct device_node *np, *band_np;const s8 *val;char name[16 ];char band;
@@ -459,15 +460,18 @@ s8 mt76_get_rate_power_limits(struct mt76_phy *phy, band ='6' ;break ;default : +of_node_put (np);return target_power; }snprintf (name,sizeof (name),"txpower-%cg" , band); - np =of_get_child_by_name (np, name); -if (!np) + band_np =of_get_child_by_name (np, name); +of_node_put (np); +if (!band_np)return target_power; - np =mt76_find_channel_node (np, chan); + np =mt76_find_channel_node (band_np, chan); +of_node_put (band_np);if (!np)return target_power;
@@ -514,6 +518,8 @@ s8 mt76_get_rate_power_limits(struct mt76_phy *phy,ARRAY_SIZE (dest->path.ru_bf), val, len, target_power, txs_delta, &max_power, n_chains, MT76_SKU_BACKOFF); +of_node_put (np); +return max_power; }EXPORT_SYMBOL_GPL (mt76_get_rate_power_limits);
Signature · 1 line
2.34.1