Skip to contentSkip to conversation

gawk: skip clos1way2/clos1way6 in ptest suite

PATCH New Pratik Farkase 1 participant 1 message Sep 17

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gawk: skip clos1way2/clos1way6 in ptest suite

clos1way2 and clos1way6 drive a two-way coprocess (|&) and expect a fixed interleaving of the child process's stderr and gawk's own warning/error output. That ordering is not guaranteed: the child (cat) and gawk write to stderr independently, so on loaded CI/autobuilder hosts the lines race and the output no longer matches the .ok file.

clos1way6 was previously skipped for musl only; the failure also occurs on glibc and clos1way2 exhibits the same race, so skip both for all libcs, consistent with how time, timeout and randtest are already handled.

[YOCTO #15477]

---
 meta/recipes-extended/gawk/gawk_5.4.1.bb | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
meta/recipes-extended/gawk/gawk_5.4.1.bb +10 -4
index 89b73a1641..d3bf532528 100644
@@ -83,14 +83,20 @@ do_install_ptest() {
 	# randtest is a statistical test that intermittently fails on overloaded systems
 	# https://bugzilla.yoctoproject.org/show_bug.cgi?id=16254
 	rm -f ${D}${PTEST_PATH}/test/randtest.*
-	for t in time timeout randtest; do
+	# clos1way2/clos1way6 drive a two-way coprocess (|&) and expect a fixed
+	# interleaving of the child's stderr and gawk's own warning/error output.
+	# That ordering is not guaranteed and races on loaded hosts, failing
+	# intermittently across arches and libcs.
+	# https://bugzilla.yoctoproject.org/show_bug.cgi?id=15477
+	# Reported upstream: https://lists.gnu.org/archive/html/bug-gawk/2021-02/msg00005.html
+	rm -f ${D}${PTEST_PATH}/test/clos1way2.*
+	rm -f ${D}${PTEST_PATH}/test/clos1way6.*
+	for t in time timeout randtest clos1way2 clos1way6; do
 		echo $t >> ${D}${PTEST_PATH}/test/skipped.txt
 	done
 }
 
 do_install_ptest:append:libc-musl() {
-	# Reported  https://lists.gnu.org/archive/html/bug-gawk/2021-02/msg00005.html
-	rm -f ${D}${PTEST_PATH}/test/clos1way6.*
 	# Needs en_US.UTF-8 but then does not work with musl
 	rm -f ${D}${PTEST_PATH}/test/backsmalls1.*
 	# Needs en_US.UTF-8 but then does not work with musl
@@ -98,7 +104,7 @@ do_install_ptest:append:libc-musl() {
 	# The below two need LANG=C inside the make rule for musl
 	rm -f ${D}${PTEST_PATH}/test/rebt8b1.*
 	rm -f ${D}${PTEST_PATH}/test/regx8bit.*
-	for t in clos1way6 backsmalls1 commas rebt8b1 regx8bit; do
+	for t in backsmalls1 commas rebt8b1 regx8bit; do
 		echo $t >> ${D}${PTEST_PATH}/test/skipped.txt
 	done
 }
Signature · 1 line
2.43.0