Skip to contentSkip to conversation

media: radio-maxiradio: balance PCI device enable on cleanup

PATCH New Myeonghun Pak 1 participant 1 message Sep 17

Subsystems (3)
Stable branch Media (V4L/DVB) Maxiradio FM radio receiver driver
lore
Share & tools
lore

Myeonghun Pak

author
#0 lore raw

PATCH v2 1/1 media: radio-maxiradio: balance PCI device enable on cleanup

The tuner initialization failure and remove paths omit the matching pci_disable_device() after a successful pci_enable_device(). Disable the device on both paths, after the final hardware access on removal.

This issue was identified during our ongoing static-analysis research while reviewing kernel code.

Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc [email protected]
Assisted-by LLM
Co-developed-by Ijae Kim <[email protected]>
Signed-off-by Ijae Kim <[email protected]>
Signed-off-by Myeonghun Pak <[email protected]>

---
Changes in v2:
- Add a Fixes tag for the initial Git import, where the PCI enable imbalance is already present. No code changes from v1.

drivers/media/radio/radio-maxiradio.c +4 -1
@@ -159,10 +159,12 @@
 	dev->io = pci_resource_start(pdev, 0);
 	if (snd_tea575x_init(&dev->tea, THIS_MODULE)) {
 		printk(KERN_ERR "radio-maxiradio: Unable to detect TEA575x tuner\n");
-		goto err_out_free_region;
+		goto err_disable_device;
 	}
 	return 0;
 
+err_disable_device:
+	pci_disable_device(pdev);
 err_out_free_region:
 	release_region(pci_resource_start(pdev, 0), pci_resource_len(pdev, 0));
 err_hdl:

@@ -180,6 +182,7 @@
 	snd_tea575x_exit(&dev->tea);
 	/* Turn off power */
 	outb(0, dev->io);
+	pci_disable_device(pdev);
 	v4l2_device_unregister(v4l2_dev);
 	release_region(pci_resource_start(pdev, 0), pci_resource_len(pdev, 0));
 	kfree(dev);