Skip to contentSkip to conversation

gpio: it87: Remove const from labels_table allocation type

PATCH Applied Kees Cook 2 participants 2 messages Sep 17 – Sep 21 GPIO

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 gpio: it87: Remove const from labels_table allocation type

From: Kees Cook <[email protected]>

In preparation for converting the kmalloc family of allocators to the type-aware kmalloc_obj family, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (The kmalloc family returns "void *", which can be implicitly cast to any pointer type.)

The assigned type is "char **", but the converted allocation type would be "const char **", which is const qualified. As there is no general way to remove const qualifiers, take the size from the assignment target instead. No change in allocation size results.

Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
drivers/gpio/gpio-it87.o

Assisted-by LLM coccinelle

---
Cc: Linus Walleij <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: <[email protected]>

---
 drivers/gpio/gpio-it87.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-it87.c +1 -1
index 2ad3c239367b..699325129a7d 100644
@@ -362,7 +362,7 @@ static int __init it87_gpio_init(void)
 	 */
 	labels = kcalloc(it87_gpio->chip.ngpio, sizeof("it87_gpXY"),
 								GFP_KERNEL);
-	labels_table = kcalloc(it87_gpio->chip.ngpio, sizeof(const char *),
+	labels_table = kcalloc(it87_gpio->chip.ngpio, sizeof(*labels_table),
 								GFP_KERNEL);
 
 	if (!labels || !labels_table) {
Signature · 1 line
2.34.1
#1 lore raw
Quoted 6 lines · Kees Cook

In preparation for converting the kmalloc family of allocators to the type-aware kmalloc_obj family, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (The kmalloc family returns "void *", which can be implicitly cast to any pointer type.)

Quoted 6 lines

The assigned type is "char **", but the converted allocation type would be "const char **", which is const qualified. As there is no general way to remove const qualifiers, take the size from the assignment target instead. No change in allocation size results.

[...]

Applied, thanks!

[1/1] gpio: it87: Remove const from labels_table allocation type

      https://git.kernel.org/brgl/c/24715edd98ba62840214a35137ed23e611348797

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>