perf: remove unused empty help-unknown-cmd.h header
PATCH 1/1 perf: remove unused empty help-unknown-cmd.h header
tools/perf/util/help-unknown-cmd.h has been empty and unused ever since it was added to the kernel in commit 5feaac248a46 ("perf tools: Move help_unknown_cmd() to its own file"). Remove it.
--- tools/perf/util/help-unknown-cmd.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 tools/perf/util/help-unknown-cmd.h
tools/perf/util/help-unknown-cmd.h deleted +0 -0
Signature · 1 line
2.43.0
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 5 lines
tools/perf/util/help-unknown-cmd.hhas been empty and unused ever since it was added to the kernel in commit5feaac248a46("perf tools: Movehelp_unknown_cmd()to its own file"). Remove it.Signed-off-by Ethan Nelson-Moore <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 6 lines · Ethan Nelson-Moore
tools/perf/util/help-unknown-cmd.hhas been empty and unused ever since it was added to the kernel in commit5feaac248a46("perf tools: Movehelp_unknown_cmd()to its own file"). Remove it.Signed-off-by Ethan Nelson-Moore <[email protected]>
This seems like an accident, the declaration has been in tools/perf/builtin.h ever since the commit above. Perhaps the header file is a more natural location, but an empty header file is clearly useless.
Thanks,
Ian
Quoted 11 lines
--- tools/perf/util/help-unknown-cmd.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 tools/perf/util/help-unknown-cmd.htools/perf/util/help-unknown-cmd.h deleted +0
-1--2.43.0
Quoted 7 lines · Ian Rogers
Quoted 5 lines · Ethan Nelson-Moore
tools/perf/util/help-unknown-cmd.hhas been empty and unused ever since it was added to the kernel in commit5feaac248a46("perf tools: Movehelp_unknown_cmd()to its own file"). Remove it.
Quoted 8 lines
Quoted 1 line
Signed-off-by Ethan Nelson-Moore <[email protected]>This seems like an accident, the declaration has been in
tools/perf/builtin.hever since the commit above. Perhaps the header file is a more natural location, but an empty header file is clearly useless.Reviewed-by Ian Rogers <[email protected]>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo