Skip to contentSkip to conversation

platform/raspberrypi: Use %p for pointer formatting

PATCH New Sebastian Andrzej Siewior 1 participant 1 message Sep 18 Broadcom BCM2711/BCM2835 Arm architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/raspberrypi: Use %p for pointer formatting

Since commit ad67b74d2469d ("printk: hash addresses printed with %p") pointers are hashed by default and the behaviour can be controller by `hash_pointers' boot argument.
The policy on %p is to not introduce new ones.
Removing %pK makes it possible to remove its handling from the library.

Ideally I would the %p usage here but can't tell how important it is for debugging.

Use %p instead %pK.

---
 drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c  | 4 ++--
 drivers/platform/raspberrypi/vchiq-interface/vchiq_core.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c +2 -2
index e786417032522..c99f63b80addf 100644
@@ -891,7 +891,7 @@ void vchiq_dump_platform_instances(struct vchiq_state *state, struct seq_file *f
 		}
 		rcu_read_unlock();
 
-		seq_printf(f, "Instance %pK: pid %d,%s completions %d/%d\n",
+		seq_printf(f, "Instance %p: pid %d,%s completions %d/%d\n",
 			   instance, instance->pid,
 			   instance->connected ? " connected, " :
 			   "",
@@ -908,7 +908,7 @@ void vchiq_dump_platform_service_state(struct seq_file *f,
 	struct user_service *user_service =
 			(struct user_service *)service->base.userdata;
 
-	seq_printf(f, "  instance %pK", service->instance);
+	seq_printf(f, "  instance %p", service->instance);
 
 	if ((service->base.callback == service_callback) && user_service->is_vchi) {
 		seq_printf(f, ", %d/%d messages",
drivers/platform/raspberrypi/vchiq-interface/vchiq_core.c +1 -1
index 48d6b1d743293..bb4e5015956d6 100644
@@ -3915,7 +3915,7 @@ void vchiq_dump_state(struct seq_file *f, struct vchiq_state *state)
 	seq_printf(f, "State %d: %s\n", state->id,
 		   conn_state_names[state->conn_state]);
 
-	seq_printf(f, "  tx_pos=0x%x(@%pK), rx_pos=0x%x(@%pK)\n",
+	seq_printf(f, "  tx_pos=0x%x(@%p), rx_pos=0x%x(@%p)\n",
 		   state->local->tx_pos,
 		   state->tx_data + (state->local_tx_pos & VCHIQ_SLOT_MASK),
 		   state->rx_pos,
Signature · 1 line
2.55.0