dmaengine: bestcomm: Enable compile testing

PATCH Applied Rosen Penev 4 participants 5 messages Sep 18 – Oct 5 dmaengine

lore

Share & tools

lore

Rosen Penev

author

2026-09-18 17:59 UTC #0 lore raw

PATCH v2 1/1 dmaengine: bestcomm: Enable compile testing

Allow the BestComm DMA engine to be selected for PowerPC compile-test builds.

The freescale ethernet and sound drivers now need a dependency on PPC_MPC52xx as they use headers/functions from that platform.

Assisted-by LLM

Signed-off-by Rosen Penev <[email protected]>

---
v2: keep it bestcomm only

 drivers/dma/bestcomm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion1(-)

drivers/dma/bestcomm/Kconfig +1 -1

index 5dd437295964..153b5492c93c 100644
@@ -5,7 +5,7 @@
 
 config PPC_BESTCOMM
 	tristate "Bestcomm DMA engine support"
-	depends on PPC_MPC52xx
+	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
 	default n
 	select PPC_LIB_RHEAP
 	help

Signature · 1 line

2.55.0

[email protected]

AI review

2026-09-18 18:10 UTC #1 lore raw

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] kconfig: missing PPC_MPC52xx dependency for SND_SOC_MPC5200_AC97 --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: missing PPC_MPC52xx dependency for SND_SOC_MPC5200_AC97
--

commit 95cb68468081de8e2880323cb63c64d9da8626b0
Author: Rosen Penev <[email protected]>

dmaengine: bestcomm: Enable compile testing

This commit relaxing the dependency for the BestComm DMA engine allows it to be selected on PowerPC for compile-test builds. It adds an alternative dependency on (PPC && COMPILE_TEST).

drivers/dma/bestcomm/Kconfig line 8

Quoted 10 lines

drivers/dma/bestcomm/Kconfig +1 -1

index 5dd437295964d..e23ba4982d7ed 100644
@@ -5,7 +5,7 @@
 
 config PPC_BESTCOMM
 	tristate "Bestcomm DMA engine support"
-	depends on PPC_MPC52xx
+	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)

[Severity: Low]
Does relaxing this dependency cause an unresolved symbol during link time for SND_SOC_MPC5200_AC97?

When COMPILE_TEST is enabled on PowerPC, PPC_BESTCOMM can be selected without PPC_MPC52xx. However, SND_SOC_MPC5200_AC97 in sound/soc/fsl/Kconfig depends on PPC_BESTCOMM but lacks an explicit dependency on PPC_MPC52xx:

sound/soc/fsl/Kconfig:
config SND_SOC_MPC5200_AC97
tristate "Freescale MPC5200 PSC in AC97 mode driver" depends on PPC_BESTCOMM

This inherits PPC_BESTCOMM's relaxation and allows the driver to be built when the platform code is absent. In psc_ac97_cold_reset(), the driver unconditionally calls a platform function:

sound/soc/fsl/mpc5200_psc_ac97.c:psc_ac97_cold_reset() {
    ...
        mpc5200_psc_ac97_gpio_reset(psc_dma->id);
    ...
}

Since mpc5200_psc_ac97_gpio_reset() is only compiled when PPC_MPC52xx is enabled, does this result in an undefined reference at link time?

Signature · 1 line

Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

Rosen Penev

author

2026-09-18 18:19 UTC #2 lore raw

Quoted 3 lines · On Fri, Sep 18, 2026 at 11:10 AM <[email protected]> wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: missing PPC_MPC52xx dependency for SND_SOC_MPC5200_AC97

This was merged:

https://lore.kernel.org/linux-sound/178967135736.285745.8925263446043052641.b4-ty@b4/

Quoted 50 lines

--
commit 95cb68468081de8e2880323cb63c64d9da8626b0
Author: Rosen Penev <[email protected]>
dmaengine: bestcomm: Enable compile testing
This commit relaxing the dependency for the BestComm DMA engine allows it to be selected on PowerPC for compile-test builds. It adds an alternative dependency on (PPC && COMPILE_TEST).
drivers/dma/bestcomm/Kconfig line 8
Quoted 10 lines
drivers/dma/bestcomm/Kconfig +1 -1
index 5dd437295964d..e23ba4982d7ed 100644
@@ -5,7 +5,7 @@
 
 config PPC_BESTCOMM
      tristate "Bestcomm DMA engine support"
-     depends on PPC_MPC52xx
+     depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
[Severity: Low]
Does relaxing this dependency cause an unresolved symbol during link time for SND_SOC_MPC5200_AC97?
When COMPILE_TEST is enabled on PowerPC, PPC_BESTCOMM can be selected without PPC_MPC52xx. However, SND_SOC_MPC5200_AC97 in sound/soc/fsl/Kconfig depends on PPC_BESTCOMM but lacks an explicit dependency on PPC_MPC52xx:
sound/soc/fsl/Kconfig:
config SND_SOC_MPC5200_AC97
tristate "Freescale MPC5200 PSC in AC97 mode driver" depends on PPC_BESTCOMM
This inherits PPC_BESTCOMM's relaxation and allows the driver to be built when the platform code is absent. In psc_ac97_cold_reset(), the driver unconditionally calls a platform function:
sound/soc/fsl/mpc5200_psc_ac97.c:psc_ac97_cold_reset() {
    ...
        mpc5200_psc_ac97_gpio_reset(psc_dma->id);
    ...
}
Since mpc5200_psc_ac97_gpio_reset() is only compiled when PPC_MPC52xx is enabled, does this result in an undefined reference at link time?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

Frank Li

Reviewed-by on v2 1/1

2026-09-18 19:41 UTC #3 lore raw

In reply to Rosen Penev

Quoted 9 lines · Rosen Penev

Allow the BestComm DMA engine to be selected for PowerPC compile-test builds.
The freescale ethernet and sound drivers now need a dependency on PPC_MPC52xx as they use headers/functions from that platform.
Assisted-by LLM
Signed-off-by Rosen Penev <[email protected]>
---

Reviewed-by Frank Li <[email protected]>

Quoted 20 lines

v2: keep it bestcomm only

 drivers/dma/bestcomm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion1(-)

drivers/dma/bestcomm/Kconfig +1 -2

index 5dd437295964..153b5492c93c 100644
@@ -5,7 +5,7 @@
 
 config PPC_BESTCOMM
 	tristate "Bestcomm DMA engine support"
-	depends on PPC_MPC52xx
+	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
 	default n
 	select PPC_LIB_RHEAP
 	help
--

2.55.0

Vinod Koul

maintainer Applied

2026-10-05 15:43 UTC #4 lore raw

In reply to Rosen Penev

Quoted 8 lines · Rosen Penev

Allow the BestComm DMA engine to be selected for PowerPC compile-test builds.
The freescale ethernet and sound drivers now need a dependency on PPC_MPC52xx as they use headers/functions from that platform.
[...]

Applied, thanks!

[1/1] dmaengine: bestcomm: Enable compile testing

      commit: 57946765c242005bdb16d17944c27662c8c5b013

Best regards,

Signature · 1 line

~Vinod