Skip to contentSkip to conversation

at-spi2-core: RDEPENDS on gsettings-desktop-schemas

PATCH Superseded [email protected] 1 participant 4 messages Sep 19

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 at-spi2-core: RDEPENDS on gsettings-desktop-schemas

From: Tim Orling <[email protected]>

at-spi-bus-launcher aborts when no compiled GSettings schema is present.

This has been a fatal error since [1]:
"26f75dc0 bus: Abort if we cannot get the default GSettingsSchemaSource"

[1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/26f75dc00eb16ccec89561aefe15f4036d45b4ec

---
 meta/recipes-support/atk/at-spi2-core_2.60.6.bb | 7 +++++++
 1 file changed, 7 insertions(+)
meta/recipes-support/atk/at-spi2-core_2.60.6.bb +7 -0
index 1e7a16d747..5c676d639f 100644
@@ -23,6 +23,13 @@ DEPENDS = " \
 PROVIDES += "atk at-spi2-atk"
 RPROVIDES:${PN} += "atk at-spi2-atk"
 
+# at-spi-bus-launcher calls g_error() -- which aborts -- when
+# g_settings_schema_source_get_default() returns NULL, which is what happens
+# when no gschemas.compiled exists anywhere in XDG_DATA_DIRS. It also reads and
+# writes org.gnome.desktop.interface's toolkit-accessibility key to persist the
+# accessibility enable/disable state across sessions.
+RDEPENDS:${PN}:append:class-target = " gsettings-desktop-schemas"
+
 inherit gnomebase gi-docgen gettext systemd upstream-version-is-even gobject-introspection python3-dir
 
 EXTRA_OEMESON = " -Dsystemd_user_dir=${systemd_user_unitdir} \
Signature · 1 line
2.47.3
#1 lore raw

PATCH 2/3 maintainers.inc: assign gsettings-desktop-schemas

From: Tim Orling <[email protected]>

gsettings-desktop-schemas is now in RDEPENDS for at-spi2-core, so assign myself as maintainer.

---
 meta/conf/distro/include/maintainers.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/distro/include/maintainers.inc +1 -1
index 783084060f..c273d2d754 100644
@@ -248,7 +248,7 @@ RECIPE_MAINTAINER:pn-groff = "Hongxu Jia <[email protected]>"
 RECIPE_MAINTAINER:pn-grub = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-grub-bootconf = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-grub-efi = "Unassigned <[email protected]>"
-RECIPE_MAINTAINER:pn-gsettings-desktop-schemas = "Unassigned <[email protected]>"
+RECIPE_MAINTAINER:pn-gsettings-desktop-schemas = "Tim Orling <[email protected]>"
 RECIPE_MAINTAINER:pn-gst-devtools = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-gst-examples = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-gstreamer1.0 = "Unassigned <[email protected]>"
Signature · 1 line
2.47.3
#2 lore raw

PATCH 3/3 at-spi2-core: upgrade 2.60.6 -> 2.62.0.1

In reply to [email protected]

From: Tim Orling <[email protected]>

What's new in at-spi2-core 2.62.0:

* atk-bridge: Release disconnected direct connections.

What's new in at-spi2-core 2.61.90:

* libatspi: Fix transfer annotation on atspi_document_get_text_selections
* Add a Ready signal to org.a11y.atspi.Cache.
* Add ATSPI_STATE_DEFAULT as an alias for ATSPI_STATE_IS_DEFAULT, so that StateChanged signals for the equivalent atk state are handled.

What's new in at-spi2-core 2.61.1:

* atk-bridge: Attempt to fix a crash in get_registered_event_listeners
* AtspiDevice: Avoid assigning 0 as a grab id
* Remove G_GNUC_CONST from *_get_type_declarations

What's new in at-spi2-core 2.61.0:

* Add atspi_set_g_main_loop_reentrancy. If this is enabled, then libatspi will use a GMainLoop when waiting for replies from DBus calls. This is off by default but can be enabled in cases where reentrancy is needed.
* at-spi-bus-launcher: Rework the way org.a11y.Status.IsEnabled is handled. At-spi-bus-launcher now listens for ATs registering events and assumes that accessibility is enabled if events are registered, rather than relying on the value of a gsettings key.
* meson: Build dbind with -DG_LOG_DOMAIN=atspi.
* libatspi: Disable direct DBus connections if ATSPI_DISABLE_P2P is set.
* Do not call GetItems if ATSPI_NO_CACHE is set.

Upstream release notes:
https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/main/NEWS

For a full comparison of changes, see:
https://github.com/GNOME/at-spi2-core/compare/2.60.6...2.62.0.1

---

NOTE: this depends on https://lore.kernel.org/openembedded-core/[email protected]/

 .../atk/{at-spi2-core_2.60.6.bb => at-spi2-core_2.62.0.1.bb}    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/atk/{at-spi2-core_2.60.6.bb => at-spi2-core_2.62.0.1.bb} (95%)
meta/recipes-support/atk/at-spi2-core_2.62.0.1.bb renamed from meta/recipes-support/atk/at-spi2-core_2.60.6.bb +1 -1
similarity index 95%
rename from meta/recipes-support/atk/at-spi2-core_2.60.6.bb
rename to meta/recipes-support/atk/at-spi2-core_2.62.0.1.bb
index 5c676d639f..0274c2de75 100644
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
 
 CVE_PRODUCT += "at-spi2-atk"
 
-SRC_URI[archive.sha256sum] = "a89b64a8b217a8042bdf0e35cbfab629ceee35640dba75df578afde9aa789d57"
+SRC_URI[archive.sha256sum] = "fa462f1834bae569c5944c34608872f9447e5a2889ba2aa4d5ff9f2d6ff8a395"
 
 DEPENDS = " \
 	dbus \
Signature · 1 line
2.47.3
#3 lore raw

PATCH v2 1/1 at-spi2-core: RDEPENDS on gsettings-desktop-schemas

In reply to [email protected]

From: Tim Orling <[email protected]>

at-spi-bus-launcher aborts when no compiled GSettings schema is present.

This has been a fatal error since [1]:
"26f75dc0 bus: Abort if we cannot get the default GSettingsSchemaSource"

[1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/26f75dc00eb16ccec89561aefe15f4036d45b4ec

---
 meta/recipes-support/atk/at-spi2-core_2.60.6.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/atk/at-spi2-core_2.60.6.bb +2 -0
index 1e7a16d747..77f0dddb0c 100644
@@ -23,6 +23,8 @@ DEPENDS = " \
 PROVIDES += "atk at-spi2-atk"
 RPROVIDES:${PN} += "atk at-spi2-atk"
 
+RDEPENDS:${PN}:append:class-target = " gsettings-desktop-schemas"
+
 inherit gnomebase gi-docgen gettext systemd upstream-version-is-even gobject-introspection python3-dir
 
 EXTRA_OEMESON = " -Dsystemd_user_dir=${systemd_user_unitdir} \
Signature · 1 line
2.47.3