Skip to contentSkip to conversation

psmisc: add ptest support

PATCH In review Pratik Farkase 3 participants 10 messages Sep 14 – Sep 21

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 psmisc: add ptest support

Add ptest support using psmisc's upstream DejaGnu testsuite, which exercises killall, pslog and fuser via their .exp scripts. The tools and the testsuite helper programs (socket_test, test-listen) are installed under a src/ layout so the scripts' ${topdir}src/<tool> paths resolve on target.

---
 .../distro/include/ptest-packagelists.inc     |  1 +
 meta/recipes-extended/psmisc/psmisc/run-ptest |  7 +++
 meta/recipes-extended/psmisc/psmisc_23.7.bb   | 45 ++++++++++++++++++-
 3 files changed, 52 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/psmisc/psmisc/run-ptest
meta/conf/distro/include/ptest-packagelists.inc +1 -0
index 4012be5f49..f01abc4a57 100644
@@ -68,6 +68,7 @@ PTESTS_FAST = "\
     opkg \
     popt \
     procps \
+    psmisc \
     python3-atomicwrites \
     python3-attrs \
     python3-bcrypt \
meta/recipes-extended/psmisc/psmisc/run-ptest new file +7 -0
new file mode 100644
index 0000000000..f4e79f5ae3
@@ -0,0 +1,7 @@
+#!/bin/sh
+
+cd ./testsuite
+for tool in @DEJATOOL@; do
+    runtest -a --tool $tool --outdir ../log
+done
+cd -
meta/recipes-extended/psmisc/psmisc_23.7.bb +44 -1

60 lines not on this page · raw message

Signature · 1 line
2.43.0
#1 lore raw

Hi,

Quoted 5 lines · Pratik Farkase

Add ptest support using psmisc's upstream DejaGnu testsuite, which exercises killall, pslog and fuser via their .exp scripts. The tools and the testsuite helper programs (socket_test, test-listen) are installed under a src/ layout so the scripts' ${topdir}src/<tool> paths resolve on target.

I'm seeing failures for these ptest on our test infrastructure:

AssertionError:
Failed ptests:
{'psmisc': ['fuser_-a_no_proc', 'fuser_-av,_no_proc', 'fuser_-va,_no_proc']}

Full log: https://autobuilder.yoctoproject.org/valkyrie/api/v2/logs/8929945/raw_inline

Similar failures:
https://autobuilder.yoctoproject.org/valkyrie/#/builders/61/builds/4533
https://autobuilder.yoctoproject.org/valkyrie/#/builders/73/builds/4560

Can you have a look at these?

Thanks,
Antonin

#2 lore raw

PATCH v2 1/1 psmisc: add ptest support

In reply to Pratik Farkase

Add ptest support using psmisc's upstream DejaGnu testsuite, which exercises killall, pslog and fuser via their .exp scripts. The tools and the testsuite helper programs (socket_test, test-listen) are installed under a src/ layout so the scripts' ${topdir}src/<tool> paths resolve on target.

---
Changes in v2:
- Point mktemp at a private, symlink-resolved TMPDIR in run-ptest so the fuser -a/-av/-va tests do not fail intermittently on the autobuilder when /tmp is a symlink or on a different mount.

 .../distro/include/ptest-packagelists.inc     |  1 +
 meta/recipes-extended/psmisc/psmisc/run-ptest | 20 +++++++++
 meta/recipes-extended/psmisc/psmisc_23.7.bb   | 45 ++++++++++++++++++-
 3 files changed, 65 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/psmisc/psmisc/run-ptest
meta/conf/distro/include/ptest-packagelists.inc +1 -0
index 4012be5f49..f01abc4a57 100644
@@ -68,6 +68,7 @@ PTESTS_FAST = "\
     opkg \
     popt \
     procps \
+    psmisc \
     python3-atomicwrites \
     python3-attrs \
     python3-bcrypt \
meta/recipes-extended/psmisc/psmisc/run-ptest new file +13 -0
new file mode 100644
index 0000000000..ca7391b172
@@ -0,0 +1,20 @@
+#!/bin/sh
+
+cd ./testsuite
+
+tmpdir="$(pwd)/tmp"
+mkdir -p "$tmpdir"
+TMPDIR="$(cd "$tmpdir" && pwd -P)"
+export TMPDIR
+
+for tool in @DEJATOOL@; do
+    runtest -a --tool $tool --outdir ../log
+done
+cd -
meta/recipes-extended/psmisc/psmisc_23.7.bb +44 -1

60 lines not on this page · raw message

Signature · 1 line
2.43.0
#3 lore raw

Patchtest results for [OE-core][PATCH v2] psmisc: add ptest support

Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:

---
Testing patch /home/patchtest/share/mboxes/v2-psmisc-add-ptest-support.patch

FAIL: test mbox format: Series has malformed diff lines. Create the series again using git-format-patch and ensure it applies using git am (test_mbox.TestMbox.test_mbox_format)

PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test auh changelog truncation notice (test_mbox.TestMbox.test_auh_changelog_truncation_notice)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: Python-unidiff parse error (test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: Patch cannot be merged (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: Parse error Unexpected hunk found: @@ -25,6 +26,48 @@ do_configure:prepend() {
SKIP: test Signed-off-by presence: Parse error Unexpected hunk found: @@ -25,6 +26,48 @@ do_configure:prepend() {
SKIP: test Upstream-Status presence: Parse error Unexpected hunk found: @@ -25,6 +26,48 @@ do_configure:prepend() {
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: Python-unidiff parse error (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!

#4 lore raw

PATCH v2 1/1 psmisc: add ptest support

In reply to Pratik Farkase

Add ptest support using psmisc's upstream DejaGnu testsuite, which exercises killall, pslog and fuser via their .exp scripts. The tools and the testsuite helper programs (socket_test, test-listen) are installed under a src/ layout so the scripts' ${topdir}src/<tool> paths resolve on target.

---

Notes:
Changes in v2:
- Point mktemp at a private, symlink-resolved TMPDIR in run-ptest so the fuser -a/-av/-va tests do not fail intermittently on the autobuilder when /tmp is a symlink or on a different mount.

 .../distro/include/ptest-packagelists.inc     |  1 +
 meta/recipes-extended/psmisc/psmisc/run-ptest | 13 ++++++
 meta/recipes-extended/psmisc/psmisc_23.7.bb   | 45 ++++++++++++++++++-
 3 files changed, 58 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/psmisc/psmisc/run-ptest
meta/conf/distro/include/ptest-packagelists.inc +1 -0
index 4012be5f49..f01abc4a57 100644
@@ -68,6 +68,7 @@ PTESTS_FAST = "\
     opkg \
     popt \
     procps \
+    psmisc \
     python3-atomicwrites \
     python3-attrs \
     python3-bcrypt \
meta/recipes-extended/psmisc/psmisc/run-ptest new file +13 -0
new file mode 100644
index 0000000000..53f7521ac1
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+cd ./testsuite
+
+tmpdir="$(pwd)/tmp"
+mkdir -p "$tmpdir"
+TMPDIR="$(cd "$tmpdir" && pwd -P)"
+export TMPDIR
+
+for tool in @DEJATOOL@; do
+    runtest -a --tool $tool --outdir ../log
+done
+cd -
meta/recipes-extended/psmisc/psmisc_23.7.bb +44 -1

60 lines not on this page · raw message

Signature · 1 line
2.43.0
#5 lore raw

Hi,

Quoted 5 lines · Pratik Farkase

Add ptest support using psmisc's upstream DejaGnu testsuite, which exercises killall, pslog and fuser via their .exp scripts. The tools and the testsuite helper programs (socket_test, test-listen) are installed under a src/ layout so the scripts' ${topdir}src/<tool> paths resolve on target.

There's still issues with this one, on musl specifically:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/109/builds/1232
https://autobuilder.yoctoproject.org/valkyrie/#/builders/110/builds/1217

Can you have a look?

Antonin

#6 lore raw

PATCH v2 1/1 psmisc: add ptest support

In reply to Pratik Farkase

Add ptest support using psmisc's upstream DejaGnu testsuite, which exercises killall, pslog and fuser via their .exp scripts. The tools and the testsuite helper programs (socket_test, test-listen) are installed under a src/ layout so the scripts' ${topdir}src/<tool> paths resolve on target.

---
 .../distro/include/ptest-packagelists.inc     |  1 +
 meta/recipes-extended/psmisc/psmisc/run-ptest | 13 ++++++
 meta/recipes-extended/psmisc/psmisc_23.7.bb   | 45 ++++++++++++++++++-
 3 files changed, 58 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/psmisc/psmisc/run-ptest
meta/conf/distro/include/ptest-packagelists.inc +1 -0
index 4012be5f49..f01abc4a57 100644
@@ -68,6 +68,7 @@ PTESTS_FAST = "\
     opkg \
     popt \
     procps \
+    psmisc \
     python3-atomicwrites \
     python3-attrs \
     python3-bcrypt \
meta/recipes-extended/psmisc/psmisc/run-ptest new file +13 -0
new file mode 100644
index 0000000000..53f7521ac1
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+cd ./testsuite
+
+tmpdir="$(pwd)/tmp"
+mkdir -p "$tmpdir"
+TMPDIR="$(cd "$tmpdir" && pwd -P)"
+export TMPDIR
+
+for tool in @DEJATOOL@; do
+    runtest -a --tool $tool --outdir ../log
+done
+cd -
meta/recipes-extended/psmisc/psmisc_23.7.bb +44 -1

60 lines not on this page · raw message

Signature · 1 line
2.43.0
#7 lore raw

PATCH v3 1/1 psmisc: add ptest support

In reply to Pratik Farkase

Add ptest support using psmisc's upstream DejaGnu testsuite, which exercises killall, pslog and fuser via their .exp scripts. The tools and the testsuite helper programs (socket_test, test-listen) are installed under a src/ layout so the scripts' ${topdir}src/<tool> paths resolve on target.

Tested on qemux86-64 with ptest-runner: glibc killall 66, pslog 2, fuser 9; musl pslog 2, fuser 9; all pass.

---
Changes in v3:
- Skip the killall DejaGnu tool on musl. killall's "-SIGNAME" shorthand depends on glibc getopt_long_only() error-recovery semantics that musl lacks, so the killall.exp signal-name loop failed on the qemux86-64 and arm64 musl autobuilders. pslog and fuser still run on musl.

Changes in v2:
- Point mktemp at a private, symlink-resolved TMPDIR in run-ptest so the fuser -a/-av/-va tests do not fail intermittently on the autobuilder when /tmp is a symlink or on a different mount.

 .../distro/include/ptest-packagelists.inc     |  1 +
 meta/recipes-extended/psmisc/psmisc/run-ptest | 13 ++++
 meta/recipes-extended/psmisc/psmisc_23.7.bb   | 62 ++++++++++++++++++-
 3 files changed, 75 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/psmisc/psmisc/run-ptest
meta/conf/distro/include/ptest-packagelists.inc +1 -0
index 4012be5f49..f01abc4a57 100644
@@ -68,6 +68,7 @@ PTESTS_FAST = "\
     opkg \
     popt \
     procps \
+    psmisc \
     python3-atomicwrites \
     python3-attrs \
     python3-bcrypt \
meta/recipes-extended/psmisc/psmisc/run-ptest new file +13 -0
new file mode 100644
index 0000000000..53f7521ac1
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+cd ./testsuite
+
+tmpdir="$(pwd)/tmp"
+mkdir -p "$tmpdir"
+TMPDIR="$(cd "$tmpdir" && pwd -P)"
+export TMPDIR
+
+for tool in @DEJATOOL@; do
+    runtest -a --tool $tool --outdir ../log
+done
+cd -
meta/recipes-extended/psmisc/psmisc_23.7.bb +56 -1

72 lines not on this page · raw message

Signature · 1 line
2.43.0
#8 lore raw

Patchtest results for [OE-core][PATCH v3] psmisc: add ptest support

Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:

---
Testing patch /home/patchtest/share/mboxes/v3-psmisc-add-ptest-support.patch

FAIL: test mbox format: Series has malformed diff lines. Create the series again using git-format-patch and ensure it applies using git am (test_mbox.TestMbox.test_mbox_format)

PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test auh changelog truncation notice (test_mbox.TestMbox.test_auh_changelog_truncation_notice)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: Python-unidiff parse error (test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: Patch cannot be merged (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: Parse error Hunk is longer than expected (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: Parse error Hunk is longer than expected (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: Parse error Hunk is longer than expected (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: Python-unidiff parse error (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!

#9 lore raw

PATCH v3 1/1 psmisc: add ptest support

In reply to Pratik Farkase

Add ptest support using psmisc's upstream DejaGnu testsuite, which exercises killall, pslog and fuser via their .exp scripts. The tools and the testsuite helper programs (socket_test, test-listen) are installed under a src/ layout so the scripts' ${topdir}src/<tool> paths resolve on target.

Tested on qemux86-64 with ptest-runner: glibc killall 66, pslog 2, fuser 9; musl pslog 2, fuser 9; all pass.

---

Changes in v3:
- Skip the killall DejaGnu tool on musl. killall's "-SIGNAME" shorthand depends on glibc getopt_long_only() error-recovery semantics that musl lacks, so the killall.exp signal-name loop failed on the qemux86-64 and arm64 musl autobuilders. pslog and fuser still run on musl.

Changes in v2:
- Point mktemp at a private, symlink-resolved TMPDIR in run-ptest so the fuser -a/-av/-va tests do not fail intermittently on the autobuilder when /tmp is a symlink or on a different mount.

 .../distro/include/ptest-packagelists.inc     |  1 +
 meta/recipes-extended/psmisc/psmisc/run-ptest | 13 +++++
 meta/recipes-extended/psmisc/psmisc_23.7.bb   | 57 ++++++++++++++++++-
 3 files changed, 70 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/psmisc/psmisc/run-ptest
meta/conf/distro/include/ptest-packagelists.inc +1 -0
index 4012be5f49..f01abc4a57 100644
@@ -68,6 +68,7 @@ PTESTS_FAST = "\
     opkg \
     popt \
     procps \
+    psmisc \
     python3-atomicwrites \
     python3-attrs \
     python3-bcrypt \
meta/recipes-extended/psmisc/psmisc/run-ptest new file +13 -0
new file mode 100644
index 0000000000..53f7521ac1
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+cd ./testsuite
+
+tmpdir="$(pwd)/tmp"
+mkdir -p "$tmpdir"
+TMPDIR="$(cd "$tmpdir" && pwd -P)"
+export TMPDIR
+
+for tool in @DEJATOOL@; do
+    runtest -a --tool $tool --outdir ../log
+done
+cd -
meta/recipes-extended/psmisc/psmisc_23.7.bb +56 -1

72 lines not on this page · raw message

Signature · 1 line
2.43.0