Skip to contentSkip to conversation

dt-bindings: remoteproc: Fix MT8188 SCP regs

PATCH Applied Rob Herring (Arm) 3 participants 3 messages Sep 21 – Sep 23

Subsystems (3)
Device tree bindings Arm MediaTek Remote processor (remoteproc)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: remoteproc: Fix MT8188 SCP regs

Allow single-register MT8188 SCP dual nodes with only the cfg region. Keep two-register and three-register requirements for the other MediaTek SCP variants that need SRAM and L1TCM regions.

Assisted-by LLM
Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../bindings/remoteproc/mtk,scp.yaml          | 22 ++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +19 -3
index bdbb12118da4..2f0a28c7a24c 100644
@@ -28,11 +28,11 @@ properties:
     description:
       Should contain the address ranges for memory regions SRAM, CFG, and,
       on some platforms, L1TCM.
-    minItems: 2
+    minItems: 1
     maxItems: 3
 
   reg-names:
-    minItems: 2
+    minItems: 1
     maxItems: 3
 
   clocks:

@@ -171,6 +171,7 @@ allOf:
     then:
       properties:
         reg:
+          minItems: 2
           maxItems: 2
         reg-names:
           items:

@@ -185,6 +186,7 @@ allOf:
     then:
       properties:
         reg:
+          minItems: 3
           maxItems: 3
         reg-names:
           items:

@@ -195,17 +197,31 @@ allOf:
       properties:
         compatible:
           enum:
-            - mediatek,mt8188-scp-dual
             - mediatek,mt8195-scp-dual
     then:
       properties:
         reg:
+          minItems: 2
           maxItems: 2
         reg-names:
           items:
             - const: cfg
             - const: l1tcm
 
+  - if:
+      properties:
+        compatible:
+          enum:
+            - mediatek,mt8188-scp-dual
+    then:
+      properties:
+        reg:
+          minItems: 1
+          maxItems: 1
+        reg-names:
+          items:
+            - const: cfg
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.53.0
maintainer Applied
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 10 lines · Rob Herring (Arm)

Allow single-register MT8188 SCP dual nodes with only the cfg region. Keep two-register and three-register requirements for the other MediaTek SCP variants that need SRAM and L1TCM regions.

Assisted-by LLM
Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../bindings/remoteproc/mtk,scp.yaml          | 22 ++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

Applied.

Thanks,
Mathieu

Quoted 70 lines
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +19 -3
index bdbb12118da4..2f0a28c7a24c 100644
@@ -28,11 +28,11 @@ properties:
     description:
       Should contain the address ranges for memory regions SRAM, CFG, and,
       on some platforms, L1TCM.
-    minItems: 2
+    minItems: 1
     maxItems: 3
 
   reg-names:
-    minItems: 2
+    minItems: 1
     maxItems: 3
 
   clocks:

@@ -171,6 +171,7 @@ allOf:
     then:
       properties:
         reg:
+          minItems: 2
           maxItems: 2
         reg-names:
           items:

@@ -185,6 +186,7 @@ allOf:
     then:
       properties:
         reg:
+          minItems: 3
           maxItems: 3
         reg-names:
           items:

@@ -195,17 +197,31 @@ allOf:
       properties:
         compatible:
           enum:
-            - mediatek,mt8188-scp-dual
             - mediatek,mt8195-scp-dual
     then:
       properties:
         reg:
+          minItems: 2
           maxItems: 2
         reg-names:
           items:
             - const: cfg
             - const: l1tcm
 
+  - if:
+      properties:
+        compatible:
+          enum:
+            - mediatek,mt8188-scp-dual
+    then:
+      properties:
+        reg:
+          minItems: 1
+          maxItems: 1
+        reg-names:
+          items:
+            - const: cfg
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.53.0