dt-bindings: iio: Add dedicated CM32181 schema
Subsystems (2)
Rob Herring (Arm)
maintainerPATCH 1/1 dt-bindings: iio: Add dedicated CM32181 schema
Add a dedicated Capella CM32181 ambient light sensor schema. The device has optional vdd-supply and interrupt properties, so it no longer fits in trivial-devices. Include both optional properties in the binding example.
--- .../bindings/iio/light/capella,cm32181.yaml | 44 +++++++++++++++++++ .../devicetree/bindings/trivial-devices.yaml | 2 - 2 files changed, 44 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml
Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml new file +44 -0
@@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/light/capella,cm32181.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Capella CM32181 ambient light sensor + +maintainers: + - Kevin Tsai <[email protected]> + +properties: + compatible: + const: capella,cm32181 + + reg: + maxItems: 1 + + vdd-supply: true + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + light-sensor@10 { + compatible = "capella,cm32181"; + reg = <0x10>; + vdd-supply = <&vdd_3v3>; + interrupt-parent = <&gpio>; + interrupts = <17 IRQ_TYPE_EDGE_RISING>; + }; + };
Documentation/devicetree/bindings/trivial-devices.yaml +0 -2
@@ -81,8 +81,6 @@ properties: - atmel,atsha204a # BPA-RS600: Power Supply - blutek,bpa-rs600 - # CM32181: Ambient Light Sensor - - capella,cm32181 # CM3232: Ambient Light Sensor - capella,cm3232 # CM3323: Ambient Light Sensor
Signature · 1 line
2.53.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: incorrect use of unevaluatedProperties --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incorrect use of unevaluatedProperties
--
commit 8c1995822038b741ca98711a9ec628a88e937b63
Author: Rob Herring (Arm) <[email protected]>
dt-bindings: iio: Add dedicated CM32181 schema
This commit adds a dedicated Capella CM32181 ambient light sensor schema. It moves the device out of trivial-devices to properly document its optional vdd-supply and interrupt properties.
Quoted 5 lines
Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml new file +0
-0
[ ... ]
Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml line 28
Quoted 5 lines
Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml new file +5
-0+required: + - compatible + - reg + +unevaluatedProperties: false
[Severity: Low]
Does this schema violate the DT authoring guidelines by using unevaluatedProperties here?
Since the schema for capella,cm32181 does not reference any external base schemas (there is no $ref keyword present), should this use
additionalProperties: false instead?
Using unevaluatedProperties without any referenced base schemas is less efficient and diverges from the standard subsystem conventions for standalone bindings.
Quoted 2 lines
Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml new file +2
-0+ +examples:
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml line 28
Quoted 5 lines · On Mon, 21 Sep 2026 18:27:51 -0500 "Rob Herring (Arm)" <[email protected]> wrote:
Documentation/devicetree/bindings/iio/light/capella,cm32181.yaml new file +5
-0+required: + - compatible + - reg + +unevaluatedProperties: false
Why not additionalProperties?
Signature · 2 lines
Kind regards, Joshua Crofts