dt-bindings: soc: hisilicon: Add HIP05 CPLD
Rob Herring (Arm)
maintainerPATCH 1/1 dt-bindings: soc: hisilicon: Add HIP05 CPLD
Add schema for the hisilicon,hip05-cpld node on the HIP05 D02 board. The node only contains the compatible string and one register window on the local bus.
--- .../soc/hisilicon/hisilicon,hip05-cpld.yaml | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml
Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml new file +35 -0
@@ -0,0 +1,35 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/hisilicon/hisilicon,hip05-cpld.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HiSilicon HIP05 CPLD registers + +maintainers: + - Wei Xu <[email protected]> + +properties: + compatible: + const: hisilicon,hip05-cpld + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + local-bus { + #address-cells = <2>; + #size-cells = <1>; + + cpld@100000000 { + compatible = "hisilicon,hip05-cpld"; + reg = <1 0x0 0x100>; + }; + };
Signature · 1 line
2.53.0
Quoted 5 lines · Rob Herring (Arm)
Add schema for the hisilicon,hip05-cpld node on the HIP05 D02 board. The node only contains the compatible string and one register window on the local bus.
Assisted-by LLM
Guidance to the LLM should probably include including the reason that this is being added to the commit message.
Quoted 35 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- .../soc/hisilicon/hisilicon,hip05-cpld.yaml | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yamlDocumentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml new file +23
-0@@ -0,0 +1,35 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/hisilicon/hisilicon,hip05-cpld.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HiSilicon HIP05 CPLD registers + +maintainers: + - Wei Xu <[email protected]> + +properties: + compatible: + const: hisilicon,hip05-cpld + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false
Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml new file +10
-0+ +examples: + - | + local-bus { + #address-cells = <2>; + #size-cells = <1>; + + cpld@100000000 { + compatible = "hisilicon,hip05-cpld"; + reg = <1 0x0 0x100>;
Also what's with this example? 1 0x0 0x100 should be 0x1 0x0 0x100?
Quoted 5 lines
Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml new file +2
-0+ }; + };Signature · 1 line
2.53.0
Rob Herring
maintainerQuoted 9 lines · Conor Dooley
Quoted 5 lines · Rob Herring (Arm)
Add schema for the hisilicon,hip05-cpld node on the HIP05 D02 board. The node only contains the compatible string and one register window on the local bus.
Assisted-by LLMGuidance to the LLM should probably include including the reason that this is being added to the commit message.
Not sure what you are looking for... I told it to convert all the .txt bindings to schema. Then I told it fix all the errors. Then I fixed some things throughout the 900 commit branch upstreaming things bit by bit. Then it mostly sat for a year and I told a new model to review them and fix these common problems a, b and c. Then I said fix all the dtbs_checks warnings on arm64. Then I said there's still warnings, do it again. Repeated that ~10 times. Now I'm going thru to weed out all the wrong and sometimes unnecessary changes.
So LLM did all the easy parts and I did everything that requires any judgement. The hardest part is typically just figuring out the correct maintainers...
Quoted 39 lines
Quoted 39 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- .../soc/hisilicon/hisilicon,hip05-cpld.yaml | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yamlDocumentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml new file +27
-0@@ -0,0 +1,35 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/hisilicon/hisilicon,hip05-cpld.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HiSilicon HIP05 CPLD registers + +maintainers: + - Wei Xu <[email protected]> + +properties: + compatible: + const: hisilicon,hip05-cpld + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + local-bus {
Quoted 8 lines
Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml line 33
Quoted 6 lines
Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml new file +6
-0+ #address-cells = <2>; + #size-cells = <1>; + + cpld@100000000 { + compatible = "hisilicon,hip05-cpld"; + reg = <1 0x0 0x100>;Also what's with this example? 1
0x00x100should be0x10x00x100?
Shrug. Sure. Honestly, I think the example can just be dropped.
I'm converting all the crap no one cares enough about to convert. That's pretty much all of the HiSilicon stuff. Mediatek needs some renewed public shaming too. I only care about getting arm64 down to no warnings.
Rob
Quoted 6 lines · Rob Herring
Quoted 5 lines · Conor Dooley
Quoted 4 lines · Rob Herring (Arm)
Add schema for the hisilicon,hip05-cpld node on the HIP05 D02 board. The node only contains the compatible string and one register window on the local bus.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Assisted-by LLMGuidance to the LLM should probably include including the reason that this is being added to the commit message.
Not sure what you are looking for... I told it to convert all the .txt bindings to schema. Then I told it fix all the errors. Then I fixed some
I meant that it should say something like "Add schema for ... node that is undocumented but appears in the ... board dts".
Otherwise this seems like a completely random addition, other than the submitter being you pointing towards it being cleanup for undocumented stuff.
Quoted 16 lines
things throughout the 900 commit branch upstreaming things bit by bit. Then it mostly sat for a year and I told a new model to review them and fix these common problems a, b and c. Then I said fix all the
dtbs_checkswarnings on arm64. Then I said there's still warnings, do it again. Repeated that ~10 times. Now I'm going thru to weed out all the wrong and sometimes unnecessary changes.So LLM did all the easy parts and I did everything that requires any judgement. The hardest part is typically just figuring out the correct maintainers...
Quoted 5 lines
Quoted 5 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- .../soc/hisilicon/hisilicon,hip05-cpld.yaml | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml
Hi Rob,
Quoted 72 lines · Rob Herring
Quoted 9 lines · Conor Dooley
Quoted 5 lines · Rob Herring (Arm)
Add schema for the hisilicon,hip05-cpld node on the HIP05 D02 board. The node only contains the compatible string and one register window on the local bus.
Assisted-by LLMGuidance to the LLM should probably include including the reason that this is being added to the commit message.
Not sure what you are looking for... I told it to convert all the .txt bindings to schema. Then I told it fix all the errors. Then I fixed some things throughout the 900 commit branch upstreaming things bit by bit. Then it mostly sat for a year and I told a new model to review them and fix these common problems a, b and c. Then I said fix all the
dtbs_checkswarnings on arm64. Then I said there's still warnings, do it again. Repeated that ~10 times. Now I'm going thru to weed out all the wrong and sometimes unnecessary changes.So LLM did all the easy parts and I did everything that requires any judgement. The hardest part is typically just figuring out the correct maintainers...
Quoted 39 lines
Quoted 39 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- .../soc/hisilicon/hisilicon,hip05-cpld.yaml | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yamlDocumentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml new file +27
-0@@ -0,0 +1,35 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/hisilicon/hisilicon,hip05-cpld.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HiSilicon HIP05 CPLD registers + +maintainers: + - Wei Xu <[email protected]> + +properties: + compatible: + const: hisilicon,hip05-cpld + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + local-bus {Quoted 8 lines
Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml line 33
Quoted 6 lines
Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml new file +6
-0+ #address-cells = <2>; + #size-cells = <1>; + + cpld@100000000 { + compatible = "hisilicon,hip05-cpld"; + reg = <1 0x0 0x100>;Also what's with this example? 1
0x00x100should be0x10x00x100?
Quoted 5 lines
Shrug. Sure. Honestly, I think the example can just be dropped.
I'm converting all the crap no one cares enough about to convert. That's pretty much all of the HiSilicon stuff. Mediatek needs some renewed public shaming too. I only care about getting arm64 down to no warnings.
My bad for the warnings!
Thanks for working on this schema cleanup!
Best Regards,
Wei
Quoted 4 lines
Rob
.