ext4: Fix sparse warning in extents kunit test when EXT4_KUNIT_TESTS=m

PATCH Superseded Ojaswin Mujoo 5 participants 6 messages Sep 22 – Sep 24 ext4 file system

lore

Share & tools

lore

Ojaswin Mujoo

author reviewer

2026-09-22 13:58 UTC #0 lore raw

PATCH 1/1 ext4: Fix sparse warning in extents kunit test when EXT4_KUNIT_TESTS=m

When kunit tests are compiled as modules, the extents kunit test emits a sparse warning:

Quoted 1 line

Quoted 1 line
fs/ext4/extents-test.c:59:3: sparse: sparse: symbol 'k_ctx' was not

declared. Should it be static?

Fix this by declaring it as static.

Fixes cb1e0c1d1fad ("ext4: kunit tests for extent splitting and conversion")

Reported-by kernel test robot <[email protected]>

Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here

---
 fs/ext4/extents-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/ext4/extents-test.c +1 -1

index bd7795a82607..9669b2197fca 100644
@@ -48,7 +48,7 @@
 #define EXT_DATA_LBLK 10
 #define EXT_DATA_LEN 3
 
-struct kunit_ctx {
+static struct kunit_ctx {
 	/*
 	 * Ext4 inode which has only 1 unwrit extent
 	 */

Signature · 1 line

2.55.0

[email protected]

AI review

2026-09-22 14:01 UTC #1 lore raw

Sashiko has reviewed this patch and found no issues. It looks great!

Quoted 11 lines

When kunit tests are compiled as modules, the extents kunit test emits a sparse warning:
Quoted 1 line
Quoted 1 line
fs/ext4/extents-test.c:59:3: sparse: sparse: symbol 'k_ctx' was not
declared. Should it be static?
Fix this by declaring it as static.
Fixes cb1e0c1d1fad ("ext4: kunit tests for extent splitting and conversion")
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line

Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

Jan Kara

reviewer Reviewed-by on v1 1/1

2026-09-23 11:38 UTC #2 lore raw

In reply to Ojaswin Mujoo

Quoted 11 lines · Ojaswin Mujoo

When kunit tests are compiled as modules, the extents kunit test emits a sparse warning:
Quoted 1 line
Quoted 1 line
fs/ext4/extents-test.c:59:3: sparse: sparse: symbol 'k_ctx' was not
declared. Should it be static?
Fix this by declaring it as static.
Fixes cb1e0c1d1fad ("ext4: kunit tests for extent splitting and conversion")
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here

Looks good. Feel free to add:

Reviewed-by Jan Kara <[email protected]>

Honza

Quoted 20 lines

---
 fs/ext4/extents-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/ext4/extents-test.c +1 -1

index bd7795a82607..9669b2197fca 100644
@@ -48,7 +48,7 @@
 #define EXT_DATA_LBLK 10
 #define EXT_DATA_LEN 3
 
-struct kunit_ctx {
+static struct kunit_ctx {
 	/*
 	 * Ext4 inode which has only 1 unwrit extent
 	 */

Signature · 1 line

2.55.0

Signature · 2 lines

Jan Kara <[email protected]>
SUSE Labs, CR

Zhang Yi

Reviewed-by on v1 1/1

2026-09-23 12:54 UTC #3 lore raw

In reply to Ojaswin Mujoo

Quoted 11 lines · Ojaswin Mujoo

When kunit tests are compiled as modules, the extents kunit test emits a sparse warning:
Quoted 1 line
Quoted 1 line
fs/ext4/extents-test.c:59:3: sparse: sparse: symbol 'k_ctx' was not
declared. Should it be static?
Fix this by declaring it as static.
Fixes cb1e0c1d1fad ("ext4: kunit tests for extent splitting and conversion")
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here

Looks good to me.

Reviewed-by Zhang Yi <[email protected]>

Quoted 17 lines

---
  fs/ext4/extents-test.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

fs/ext4/extents-test.c +1 -1

index bd7795a82607..9669b2197fca 100644
@@ -48,7 +48,7 @@
  #define EXT_DATA_LBLK 10
  #define EXT_DATA_LEN 3
 
-struct kunit_ctx {
+static struct kunit_ctx {
  	/*
  	 * Ext4 inode which has only 1 unwrit extent
  	 */

Baokun Li

reviewer Reviewed-by on v1 1/1

2026-09-24 06:57 UTC #4 lore raw

In reply to Ojaswin Mujoo

Hi Ojaswin,

Quoted 2 lines · Ojaswin Mujoo

When kunit tests are compiled as modules, the extents kunit test emits a sparse warning:

This is not module-specific, it also shows up with EXT4_KUNIT_TESTS=y, so maybe the "=m" can be dropped.

Quoted 8 lines

Quoted 1 line
Quoted 1 line
fs/ext4/extents-test.c:59:3: sparse: sparse: symbol 'k_ctx' was not
declared. Should it be static?
Fix this by declaring it as static.
Fixes cb1e0c1d1fad ("ext4: kunit tests for extent splitting and conversion")
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here

Missing Signed-off-by, otherwise looks good to me.

Reviewed-by Baokun Li <[email protected]>

Quoted 17 lines

---
 fs/ext4/extents-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/ext4/extents-test.c +1 -1

index bd7795a82607..9669b2197fca 100644
@@ -48,7 +48,7 @@
 #define EXT_DATA_LBLK 10
 #define EXT_DATA_LEN 3
 
-struct kunit_ctx {
+static struct kunit_ctx {
 	/*
 	 * Ext4 inode which has only 1 unwrit extent
 	 */

Ojaswin Mujoo

author reviewer

2026-09-24 07:35 UTC #5 lore raw

Quoted 12 lines · Baokun Li

Hi Ojaswin,
Quoted 2 lines · Ojaswin Mujoo
When kunit tests are compiled as modules, the extents kunit test emits a sparse warning:
This is not module-specific, it also shows up with EXT4_KUNIT_TESTS=y, so maybe the "=m" can be dropped.
Quoted 3 lines
Quoted 1 line
Quoted 1 line
fs/ext4/extents-test.c:59:3: sparse: sparse: symbol 'k_ctx' was not
declared. Should it be static?

Quoted 8 lines

Quoted 5 lines
Fix this by declaring it as static.
Fixes cb1e0c1d1fad ("ext4: kunit tests for extent splitting and conversion")
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Missing Signed-off-by, otherwise looks good to me.

Ahh idk how that got missed :) Thanks I'll fix it.

Regards,
ojaswin

Quoted 23 lines

Reviewed-by Baokun Li <[email protected]>

Quoted 17 lines

---
 fs/ext4/extents-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/ext4/extents-test.c +1 -1

index bd7795a82607..9669b2197fca 100644
@@ -48,7 +48,7 @@
 #define EXT_DATA_LBLK 10
 #define EXT_DATA_LEN 3
 
-struct kunit_ctx {
+static struct kunit_ctx {
 	/*
 	 * Ext4 inode which has only 1 unwrit extent
 	 */