Skip to contentSkip to conversation

perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp

PATCH Applied Dapeng Mi 4 participants 4 messages Sep 23 – Sep 24 perf events

lore
Share & tools
lore

Dapeng Mi

author
#0 lore raw

PATCH 1/1 perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp

The kernel renamed the OMR data attribute from offcore_rsp to offmodule_rsp to avoid confusion and keep the naming consistent.

So update the perf jevents msrmap accordingly.

---

Note: The dependent kernel patches have been queued into tip/perf/urgent tree.

 tools/perf/pmu-events/jevents.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
tools/perf/pmu-events/jevents.py +4 -4
index 860027bb71b2..93cf04fa8ca4 100755
@@ -249,10 +249,10 @@ class JsonEvent:
           0x3F6: 'ldlat=',
           0x1A6: 'offcore_rsp=',
           0x1A7: 'offcore_rsp=',
-          0x3E0: 'offcore_rsp=',
-          0x3E1: 'offcore_rsp=',
-          0x3E2: 'offcore_rsp=',
-          0x3E3: 'offcore_rsp=',
+          0x3E0: 'offmodule_rsp=',
+          0x3E1: 'offmodule_rsp=',
+          0x3E2: 'offmodule_rsp=',
+          0x3E3: 'offmodule_rsp=',
           0x3F7: 'frontend=',
       }
       return msrmap[int(num.split(',', 1)[0], 0)]

base-commit: edd8a9fe2eca009599e013a29c421c7a6b5ad1b9

Signature · 1 line
2.34.1
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 8 lines

The kernel renamed the OMR data attribute from offcore_rsp to offmodule_rsp to avoid confusion and keep the naming consistent.

So update the perf jevents msrmap accordingly.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Dapeng Mi
Quoted 9 lines · Dapeng Mi

The kernel renamed the OMR data attribute from offcore_rsp to offmodule_rsp to avoid confusion and keep the naming consistent.

So update the perf jevents msrmap accordingly.

Thanks,
Ian

Quoted 32 lines

---

Note: The dependent kernel patches have been queued into tip/perf/urgent tree.

 tools/perf/pmu-events/jevents.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
tools/perf/pmu-events/jevents.py +4 -4
index 860027bb71b2..93cf04fa8ca4 100755
@@ -249,10 +249,10 @@ class JsonEvent:
           0x3F6: 'ldlat=',
           0x1A6: 'offcore_rsp=',
           0x1A7: 'offcore_rsp=',
-          0x3E0: 'offcore_rsp=',
-          0x3E1: 'offcore_rsp=',
-          0x3E2: 'offcore_rsp=',
-          0x3E3: 'offcore_rsp=',
+          0x3E0: 'offmodule_rsp=',
+          0x3E1: 'offmodule_rsp=',
+          0x3E2: 'offmodule_rsp=',
+          0x3E3: 'offmodule_rsp=',
           0x3F7: 'frontend=',
       }
       return msrmap[int(num.split(',', 1)[0], 0)]

base-commit: edd8a9fe2eca009599e013a29c421c7a6b5ad1b9 --
2.34.1

maintainer Applied
#3 lore raw
Quoted 5 lines · Ian Rogers
Quoted 4 lines · Dapeng Mi

The kernel renamed the OMR data attribute from offcore_rsp to offmodule_rsp to avoid confusion and keep the naming consistent.

Quoted 7 lines
Quoted 5 lines

So update the perf jevents msrmap accordingly.

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo