bus: arm-cci: Drop cci-control-port node reference in __cci_ace_get_port()
PATCH 1/1 bus: arm-cci: Drop cci-control-port node reference in __cci_ace_get_port()
__cci_ace_get_port() looks up the device's "cci-control-port" node with of_parse_phandle(), which returns the node with its reference count raised, and only compares the pointer against the probed ports. Neither the match nor the no-match return releases it.
Drop the reference on both paths once the comparison is done.
---
Found by code review; compile-tested only (multi_v7_defconfig, W=1).
drivers/bus/arm-cci.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/bus/arm-cci.c +4 -1
@@ -167,9 +167,12 @@ static int __cci_ace_get_port(struct device_node *dn, int type) cci_portn =of_parse_phandle (dn,"cci-control-port" ,0 );for (i =0 ; i < nb_cci_ports; i++) { ace_match = ports[i].type == type; -if (ace_match && cci_portn == ports[i].dn) +if (ace_match && cci_portn == ports[i].dn) { +of_node_put (cci_portn);return i; + } } +of_node_put (cci_portn);return -ENODEV ; }
base-commit: f0100363d8c374bd8e9ea7c9ba02744f0b802ca4
Signature · 1 line
2.43.0
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:
Hello:
This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:
Quoted 8 lines · On Wed, 23 Sep 2026 12:40:55 -0400 you wrote:
__cci_ace_get_port()looks up the device's "cci-control-port" node withof_parse_phandle(), which returns the node with its reference count raised, and only compares the pointer against the probed ports. Neither the match nor the no-match return releases it.Drop the reference on both paths once the comparison is done.
[...]
Here is the summary with links:
- [v1] bus: arm-cci: Drop cci-control-port node reference in __cci_ace_get_port()
https://git.kernel.org/soc/soc/c/810ccc792193
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html