floppy: don't store a stack buffer in timeout_message
Subsystems (3)
Denis Efremov (Oracle)
maintainerPATCH 1/1 floppy: don't store a stack buffer in timeout_message
request_done() formats "request done %d" into a buffer on its stack and passes it to reschedule_timeout(), which keeps the pointer in timeout_message. show_floppy() prints timeout_message long after request_done() has returned, e.g. from result() in the interrupt handler, and reads a dead stack frame:
BUG: KASAN: stack-out-of-bounds in string+0x39c/0x3d0 lib/vsprintf.c:720 Read of size 1 at addr ffffc900003cfc70 by task swapper/3/0 Call Trace: <IRQ> ... show_floppy+0xb1/0x45f drivers/block/floppy.c:1838 result.cold+0x2b/0x30 drivers/block/floppy.c:1183 floppy_interrupt+0x191/0x340 drivers/block/floppy.c:1755 floppy_hardint+0x1a7/0x200 arch/x86/include/asm/floppy.h:66
uptodate is either 0 or 1, so pass one of two string literals instead.
Fixes 73507e6cd8dc ("drivers/block/floppy.c: remove unnecessary argument from [__]reschedule_timeout")
Reported-by [email protected]
Signed-off-by Denis Efremov (Oracle) <[email protected]>
--- drivers/block/floppy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/block/floppy.c +2 -3
@@ -2276,11 +2276,10 @@ static void request_done(int uptodate) {struct request *req = current_req;int block; -char msg[sizeof ("request done " ) +sizeof (int ) *3 ]; probing =0 ; -snprintf (msg,sizeof (msg),"request done %d" , uptodate); -reschedule_timeout (MAXTIMEOUT , msg); +reschedule_timeout (MAXTIMEOUT , + uptodate ?"request done 1" :"request done 0" );if (!req) {pr_info ("floppy.c: no request in request_done\n" );
base-commit: 62f4c998b297cf233997a2b4cd6fc2d2df0319c9
Signature · 1 line
2.55.0