Skip to contentSkip to conversation

mm: remove the unused zone->unaccepted_cleanup

PATCH Applied Usama Arif 6 participants 7 messages Sep 24 – Sep 25

Subsystems (3)
lore
Share & tools
lore

Usama Arif

author
#0 lore raw

PATCH 1/1 mm: remove the unused zone->unaccepted_cleanup

Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted memory handling") removed the zones_with_unaccepted_pages static key and the work that decremented it, but left the work_struct behind in struct zone. Nothing uses it anymore, so let's remove it.

---
 include/linux/mmzone.h | 3 ---
 1 file changed, 3 deletions(-)
include/linux/mmzone.h +0 -3
index 65e2e0249b04f..e9d3845d10554 100644
@@ -1100,9 +1100,6 @@ struct zone {
 #ifdef CONFIG_UNACCEPTED_MEMORY
 	/* Pages to be accepted. All pages on the list are MAX_PAGE_ORDER */
 	struct list_head	unaccepted_pages;
-
-	/* To be called once the last page in the zone is accepted */
-	struct work_struct	unaccepted_cleanup;
 #endif
 
 	/* zone flags, see below */
Signature · 1 line
2.53.0-Meta
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Usama Arif

Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted memory handling") removed the zones_with_unaccepted_pages static key and the work that decremented it, but left the work_struct behind in struct zone. Nothing uses it anymore, so let's remove it.

---

Signature · 3 lines
Cheers,

David
Reviewed-by Kiryl Shutsemau (Meta) on v1 1/1
#5 lore raw
In reply to Usama Arif
Quoted 6 lines · Usama Arif

Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted memory handling") removed the zones_with_unaccepted_pages static key and the work that decremented it, but left the work_struct behind in struct zone. Nothing uses it anymore, so let's remove it.

You missed me on the CC list :(

Signature · 1 line
  Kiryl Shutsemau / Kirill A. Shutemov
author
#6 lore raw
Quoted 9 lines · Kiryl Shutsemau
Quoted 6 lines · Usama Arif

Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted memory handling") removed the zones_with_unaccepted_pages static key and the work that decremented it, but left the work_struct behind in struct zone. Nothing uses it anymore, so let's remove it.

You missed me on the CC list :(

I would never do such a thing. perl scripts on the other hand...

git show | ./scripts/get_maintainer.pl
Andrew Morton <[email protected]> (maintainer:MEMORY MANAGEMENT - MISC) David Hildenbrand <[email protected]> (maintainer:MEMORY MANAGEMENT - MISC) Lorenzo Stoakes <[email protected]> (reviewer:MEMORY MANAGEMENT - MISC)
"Liam R. Howlett" <[email protected]> (reviewer:MEMORY MANAGEMENT - MISC) Vlastimil Babka <[email protected]> (reviewer:MEMORY MANAGEMENT - MISC)
Mike Rapoport <[email protected]> (reviewer:MEMORY MANAGEMENT - MISC)
Suren Baghdasaryan <[email protected]> (reviewer:MEMORY MANAGEMENT - MISC) Michal Hocko <[email protected]> (reviewer:MEMORY MANAGEMENT - MISC)
Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION)
Shuah Khan <[email protected]> (reviewer:DOCUMENTATION)
Randy Dunlap <[email protected]> (reviewer:DOCUMENTATION)
Kairui Song <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) Qi Zheng <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) Shakeel Butt <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) Barry Song <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) Axel Rasmussen <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) Yuanchu Xie <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) Wei Xu <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) Baoquan He <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) Baolin Wang <[email protected]> (reviewer:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)) [email protected] (open list:MEMORY MANAGEMENT - MISC) [email protected] (open list:DOCUMENTATION)
[email protected] (open list)

I have a script that just takes the last N patches and converts it into a list from get_maintainer.pl. For trivial patches, I dont think much about its output and just use it without thinking.

Quoted 3 lines