ALSA: usb: Add support for Reloop Jockey 3 DJ controllers
Subsystems (2)
v4 cover ALSA: usb: Add support for Reloop Jockey 3 DJ controllers
Hi Takashi, Jaroslav, and the ALSA community,
Apologies for the long gap since v3. This is not simply v3 with the review comments addressed -- I went back to the reverse engineering, and a fair amount of what came out of it changed the driver structurally.
The patch has grown accordingly: v3 was 8 files and 1613 insertions, this is 17 and 7326. Most of that is not new logic: of the roughly 5700 added lines, about 2100 are comments, 1660 are KUnit tests and generated test vectors for the codec, 249 are the new jockey3.rst documentation, and only about 1300 are executable code. The rest is blank lines and Kconfig plumbing.
The relatively large number of comments comes from the deliberate decision to include what I learned from the protocol analysis with the relevant section of code. The parts that most need explaining (the bit-plane wire format, device initialization, why the URBs run for the device's whole lifetime, the locking order etc.) cannot be verified by reading the code alone. ploytec_codec.c is over half comment for that reason: the DOC: block deriving the format from the board's I2S and DMA geometry is effectively the specification the optimized variants implement.
Previous version:
v3: https://lore.kernel.org/all/[email protected]/
Changes v3 -> v4:
- Reworked the locking architecture around an explicit hierarchy: a process-context rate_mutex outermost, then IRQ-safe leaf spinlocks for playback, capture and MIDI that are never nested in one another. Documented in jockey3.c.
- Fixed the capture stall after a sample-rate change, eliminating the USB device reset that recovery used to require. The reset rate per rate change went from 19.3% to zero, with a 98k clean streak on arm64 and 61k on x86_64.
- Rewrote the bit-plane codec: a portable reference implementation plus 32-bit and 64-bit SWAR variants selected at compile time, called through a batch API at the driver's real batch sizes. Against the same machine's reference build, the optimized path measures 11.0x encode / 7.8x decode on x86_64 and 6.9x / 6.1x on arm64. KUnit tests validate all variants against an independently derived model of the wire format.
- Added URB coalescing. The driver used to submit one 512-byte packet per URB, fixing the completion rate at 9923/s at 44.1 kHz and 21600/s at 96 kHz for as long as the device was plugged in, used or not. N packets per URB (N a power of two, 1 to 8) are now chosen per PCM open from the requested period size.
- Fixed a cold-boot initialization race. Straight after power-on the device accepts the entire init sequence, reports success on every transfer, takes playback samples, but its audio engine never starts. Bisected over 100 cold boots to between 144 and 156 ms after enumeration; the driver now waits 250 ms before its first control transfer, close to the 297-308 ms the Windows driver waits.
- Added a URB liveness watchdog. Every error path hangs off a URB completion, so a device that stops completing URBs produces no error, no xrun and no log line. A work item now reports either direction silent for 20 ms and enters the recovery ladder on a stall onset.
- Hardened handling of an unresponsive device: an EP0 error-class predicate aborts the handshake before usb_set_interface() is reached, since the USB core disables an interface's endpoints as its first action and does not re-enable them on the failure return.
- Added Documentation/sound/cards/jockey3.rst
- Addressed the v3 review comments.
Testing:
Validated with an automated hardware-in-the-loop framework written for the
purpose: probe and unbind endurance, PCM cycling, every rate in both directions, period and buffer boundary matrices, duplex, xrun injection, rate-change soaks, suspend/resume, USB disconnects via hub port power switching, and cold-boot cycling through a network-controlled mains switch. Some of the figures above come from runs of tens of thousands of iterations.
Exercised on real hardware on x86_64, i386, arm64 (Raspberry Pi 4) and armv6/armhf (Raspberry Pi 1B -- functional but tight at 88.2/96 kHz), with x86_64 and arm64 also run under a KASAN + lockdep debug kernel. The codec KUnit suite additionally tested under UML and QEMU on i386, arm, arm64, riscv and s390 (test big/little endianness).
Two things I would rather state than have found:
- The mitigation stack around the rate-change stall is now practically dormant since the rate-change improvement. I kept it as cheap insurance; happy to remove it.
- The 250 ms settling delay in jockey3_initialize() runs on the USB hub thread. I can move initialization off the probe path if you prefer, though that introduces complexity to avoid races.
I look forward to your review/feedback.
Best regards,
Frank
Frank van de Pol (1):
ALSA: usb: Add support for Reloop Jockey 3 DJ controllers
Documentation/sound/cards/index.rst | 1 + Documentation/sound/cards/jockey3.rst | 249 + MAINTAINERS | 8 + sound/usb/Kconfig | 1 + sound/usb/Makefile | 1 + sound/usb/jockey3/.kunitconfig | 13 + sound/usb/jockey3/Kconfig | 60 + sound/usb/jockey3/Makefile | 7 + sound/usb/jockey3/jockey3.c | 4060 +++++++++++++++++ sound/usb/jockey3/ploytec_codec.c | 656 +++ sound/usb/jockey3/ploytec_codec.h | 44 + sound/usb/jockey3/ploytec_codec_kunit.c | 871 ++++ .../usb/jockey3/ploytec_codec_test_vectors.h | 793 ++++ sound/usb/jockey3/ploytec_midi.c | 83 + sound/usb/jockey3/ploytec_midi.h | 36 + sound/usb/jockey3/ploytec_proto.c | 365 ++ sound/usb/jockey3/ploytec_proto.h | 78 + 17 files changed, 7326 insertions(+) create mode 100644 Documentation/sound/cards/jockey3.rst create mode 100644 sound/usb/jockey3/.kunitconfig create mode 100644 sound/usb/jockey3/Kconfig create mode 100644 sound/usb/jockey3/Makefile create mode 100644 sound/usb/jockey3/jockey3.c create mode 100644 sound/usb/jockey3/ploytec_codec.c create mode 100644 sound/usb/jockey3/ploytec_codec.h create mode 100644 sound/usb/jockey3/ploytec_codec_kunit.c create mode 100644 sound/usb/jockey3/ploytec_codec_test_vectors.h create mode 100644 sound/usb/jockey3/ploytec_midi.c create mode 100644 sound/usb/jockey3/ploytec_midi.h create mode 100644 sound/usb/jockey3/ploytec_proto.c create mode 100644 sound/usb/jockey3/ploytec_proto.h
Signature · 1 line
2.47.3
PATCH v4 1/1 ALSA: usb: Add support for Reloop Jockey 3 DJ controllers
Add a driver for the Reloop Jockey 3 Master Edition and Reloop Jockey 3 Remix USB DJ controllers.
These devices are not USB Audio Class compliant. They use a proprietary Ploytec framing protocol, which needs handling beyond what the existing quirk mechanisms can express, so the driver lives in its own directory rather than extending usb-audio.
The driver provides:
- 6-channel capture and 4-channel playback at 24 bits.
- Sample rates of 44.1, 48, 88.2 and 96 kHz.
- ALSA RawMIDI input and output for the integrated control surface.
The Ploytec encapsulation and bit-plane streaming format were reverse-engineered from USB protocol analysis. They are isolated in a hardware-independent codec layer with 32-bit and 64-bit optimized variants alongside a portable reference implementation, all three validated against KUnit tests.
Tested on real hardware on x86_64, i386, arm64 and armhf.
--- Documentation/sound/cards/index.rst | 1 + Documentation/sound/cards/jockey3.rst | 249 + MAINTAINERS | 8 + sound/usb/Kconfig | 1 + sound/usb/Makefile | 1 + sound/usb/jockey3/.kunitconfig | 13 + sound/usb/jockey3/Kconfig | 60 + sound/usb/jockey3/Makefile | 7 + sound/usb/jockey3/jockey3.c | 4060 +++++++++++++++++ sound/usb/jockey3/ploytec_codec.c | 656 +++ sound/usb/jockey3/ploytec_codec.h | 44 + sound/usb/jockey3/ploytec_codec_kunit.c | 871 ++++ .../usb/jockey3/ploytec_codec_test_vectors.h | 793 ++++ sound/usb/jockey3/ploytec_midi.c | 83 + sound/usb/jockey3/ploytec_midi.h | 36 + sound/usb/jockey3/ploytec_proto.c | 365 ++ sound/usb/jockey3/ploytec_proto.h | 78 + 17 files changed, 7326 insertions(+) create mode 100644 Documentation/sound/cards/jockey3.rst create mode 100644 sound/usb/jockey3/.kunitconfig create mode 100644 sound/usb/jockey3/Kconfig create mode 100644 sound/usb/jockey3/Makefile create mode 100644 sound/usb/jockey3/jockey3.c create mode 100644 sound/usb/jockey3/ploytec_codec.c create mode 100644 sound/usb/jockey3/ploytec_codec.h create mode 100644 sound/usb/jockey3/ploytec_codec_kunit.c create mode 100644 sound/usb/jockey3/ploytec_codec_test_vectors.h create mode 100644 sound/usb/jockey3/ploytec_midi.c create mode 100644 sound/usb/jockey3/ploytec_midi.h create mode 100644 sound/usb/jockey3/ploytec_proto.c create mode 100644 sound/usb/jockey3/ploytec_proto.h
Documentation/sound/cards/index.rst +1 -0
@@ -18,4 +18,5 @@ Card-Specific Information hdspm serial-u16550 img-spdif-in + jockey3 pcmtest
Documentation/sound/cards/jockey3.rst new file +249 -0
249 lines not on this page · raw message
MAINTAINERS +8 -0
@@ -23058,6 +23058,14 @@ F: Documentation/filesystems/relay.rst F: include/linux/relay.h F: kernel/relay.c +RELOOP JOCKEY 3 DJ CONTROLLER DRIVER +M: Frank van de Pol <[email protected]> +L: [email protected] +S: Maintained +W: https://github.com/fvdpol/alsa-jockey3 +F: Documentation/sound/cards/jockey3.rst +F: sound/usb/jockey3/ + REGISTER MAP ABSTRACTION M: Mark Brown <[email protected]> L: [email protected]
sound/usb/Kconfig +1 -0
@@ -205,6 +205,7 @@ config SND_USB_AUDIO_QMI will be called snd-usb-audio-qmi. source "sound/usb/line6/Kconfig" +source "sound/usb/jockey3/Kconfig" endif # SND_USB
sound/usb/Makefile +1 -0
@@ -37,3 +37,4 @@ obj-$(CONFIG_SND_USB_US122L) += snd-usbmidi-lib.o obj-$(CONFIG_SND) += misc/ usx2y/ caiaq/ 6fire/ hiface/ bcd2000/ qcom/ obj-$(CONFIG_SND_USB_LINE6) += line6/ +obj-$(CONFIG_SND_USB_JOCKEY3) += jockey3/
sound/usb/jockey3/.kunitconfig new file +13 -0
@@ -0,0 +1,13 @@ +CONFIG_KUNIT=y + +CONFIG_SOUND=y +CONFIG_SND=y +CONFIG_SND_PCM=y +CONFIG_SND_RAWMIDI=y + +CONFIG_USB_SUPPORT=y +CONFIG_USB=y +CONFIG_SND_USB=y + +CONFIG_SND_USB_JOCKEY3=y +CONFIG_SND_USB_JOCKEY3_CODEC_KUNIT_TEST=y
sound/usb/jockey3/Kconfig new file +60 -0
60 lines not on this page · raw message
sound/usb/jockey3/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_SND_USB_JOCKEY3) += snd-reloop-jockey3.o +snd-reloop-jockey3-y := jockey3.o ploytec_proto.o ploytec_codec.o ploytec_midi.o + +# The codec functions are not exported, so the KUnit tests are +# linked into the driver module rather than built as a separate test module. +snd-reloop-jockey3-$(CONFIG_SND_USB_JOCKEY3_CODEC_KUNIT_TEST) += ploytec_codec_kunit.o
sound/usb/jockey3/jockey3.c new file +4060 -0
2,640 lines not on this page · raw message
sound/usb/jockey3/ploytec_codec.c new file +656 -0
656 lines not on this page · raw message
sound/usb/jockey3/ploytec_codec.h new file +44 -0
44 lines not on this page · raw message
sound/usb/jockey3/ploytec_codec_kunit.c new file +871 -0
871 lines not on this page · raw message
sound/usb/jockey3/ploytec_codec_test_vectors.h new file +793 -0
793 lines not on this page · raw message
sound/usb/jockey3/ploytec_midi.c new file +83 -0
83 lines not on this page · raw message
sound/usb/jockey3/ploytec_midi.h new file +36 -0
Lines of this file are not shown. View the raw message.
sound/usb/jockey3/ploytec_proto.c new file +365 -0
365 lines not on this page · raw message
sound/usb/jockey3/ploytec_proto.h new file +78 -0
78 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.47.3
Part of the diff is not shown here. View the raw message.
Quoted 131 lines · Frank van de Pol
Hi Takashi, Jaroslav, and the ALSA community,
Apologies for the long gap since v3. This is not simply v3 with the review comments addressed -- I went back to the reverse engineering, and a fair amount of what came out of it changed the driver structurally.
The patch has grown accordingly: v3 was 8 files and 1613 insertions, this is 17 and 7326. Most of that is not new logic: of the roughly 5700 added lines, about 2100 are comments, 1660 are KUnit tests and generated test vectors for the codec, 249 are the new
jockey3.rstdocumentation, and only about 1300 are executable code. The rest is blank lines andKconfigplumbing.The relatively large number of comments comes from the deliberate decision to include what I learned from the protocol analysis with the relevant section of code. The parts that most need explaining (the bit-plane wire format, device initialization, why the URBs run for the device's whole lifetime, the locking order etc.) cannot be verified by reading the code alone.
ploytec_codec.cis over half comment for that reason: the DOC: block deriving the format from the board's I2S and DMA geometry is effectively the specification the optimized variants implement.Previous version:
v3: https://lore.kernel.org/all/[email protected]/Changes v3 -> v4:
- Reworked the locking architecture around an explicit hierarchy: a process-context
rate_mutexoutermost, then IRQ-safe leaf spinlocks for playback, capture and MIDI that are never nested in one another. Documented injockey3.c.- Fixed the capture stall after a sample-rate change, eliminating the USB device reset that recovery used to require. The reset rate per rate change went from 19.3% to zero, with a 98k clean streak on arm64 and 61k on
x86_64.- Rewrote the bit-plane codec: a portable reference implementation plus 32-bit and 64-bit SWAR variants selected at compile time, called through a batch API at the driver's real batch sizes. Against the same machine's reference build, the optimized path measures 11.0x encode / 7.8x decode on
x86_64and 6.9x / 6.1x on arm64. KUnit tests validate all variants against an independently derived model of the wire format.- Added URB coalescing. The driver used to submit one 512-byte packet per URB, fixing the completion rate at 9923/s at 44.1 kHz and 21600/s at 96 kHz for as long as the device was plugged in, used or not. N packets per URB (N a power of two, 1 to 8) are now chosen per PCM open from the requested period size.
- Fixed a cold-boot initialization race. Straight after power-on the device accepts the entire init sequence, reports success on every transfer, takes playback samples, but its audio engine never starts. Bisected over 100 cold boots to between 144 and 156 ms after enumeration; the driver now waits 250 ms before its first control transfer, close to the 297-308 ms the Windows driver waits.
- Added a URB liveness watchdog. Every error path hangs off a URB completion, so a device that stops completing URBs produces no error, no xrun and no log line. A work item now reports either direction silent for 20 ms and enters the recovery ladder on a stall onset.
- Hardened handling of an unresponsive device: an EP0 error-class predicate aborts the handshake before
usb_set_interface()is reached, since the USB core disables an interface's endpoints as its first action and does not re-enable them on the failure return.- Added
Documentation/sound/cards/jockey3.rst- Addressed the v3 review comments.
Testing:
Validated with an automated hardware-in-the-loop framework written for the
purpose: probe and unbind endurance, PCM cycling, every rate in both directions, period and buffer boundary matrices, duplex, xrun injection, rate-change soaks, suspend/resume, USB disconnects via hub port power switching, and cold-boot cycling through a network-controlled mains switch. Some of the figures above come from runs of tens of thousands of iterations.Exercised on real hardware on
x86_64, i386, arm64 (Raspberry Pi 4) and armv6/armhf (Raspberry Pi 1B -- functional but tight at 88.2/96 kHz), withx86_64and arm64 also run under a KASAN + lockdep debug kernel. The codec KUnit suite additionally tested under UML and QEMU on i386, arm, arm64, riscv and s390 (test big/little endianness).Two things I would rather state than have found:
- The mitigation stack around the rate-change stall is now practically dormant since the rate-change improvement. I kept it as cheap insurance; happy to remove it.
- The 250 ms settling delay in
jockey3_initialize()runs on the USB hub thread. I can move initialization off the probe path if you prefer, though that introduces complexity to avoid races.I look forward to your review/feedback.
Best regards,
FrankFrank van de Pol (1):
ALSA: usb: Add support for Reloop Jockey 3 DJ controllersDocumentation/sound/cards/index.rst | 1 + Documentation/sound/cards/jockey3.rst | 249 + MAINTAINERS | 8 + sound/usb/Kconfig | 1 + sound/usb/Makefile | 1 + sound/usb/jockey3/.kunitconfig | 13 + sound/usb/jockey3/Kconfig | 60 + sound/usb/jockey3/Makefile | 7 + sound/usb/jockey3/jockey3.c | 4060 +++++++++++++++++ sound/usb/jockey3/ploytec_codec.c | 656 +++ sound/usb/jockey3/ploytec_codec.h | 44 + sound/usb/jockey3/ploytec_codec_kunit.c | 871 ++++ .../usb/jockey3/ploytec_codec_test_vectors.h | 793 ++++ sound/usb/jockey3/ploytec_midi.c | 83 + sound/usb/jockey3/ploytec_midi.h | 36 + sound/usb/jockey3/ploytec_proto.c | 365 ++ sound/usb/jockey3/ploytec_proto.h | 78 + 17 files changed, 7326 insertions(+) create mode 100644 Documentation/sound/cards/jockey3.rst create mode 100644 sound/usb/jockey3/.kunitconfig create mode 100644 sound/usb/jockey3/Kconfig create mode 100644 sound/usb/jockey3/Makefile create mode 100644 sound/usb/jockey3/jockey3.c
Quoted 8 lines
create mode 100644 sound/usb/jockey3/ploytec_codec.c create mode 100644 sound/usb/jockey3/ploytec_codec.h create mode 100644 sound/usb/jockey3/ploytec_codec_kunit.c create mode 100644 sound/usb/jockey3/ploytec_codec_test_vectors.h create mode 100644 sound/usb/jockey3/ploytec_midi.c create mode 100644 sound/usb/jockey3/ploytec_midi.h create mode 100644 sound/usb/jockey3/ploytec_proto.c create mode 100644 sound/usb/jockey3/ploytec_proto.h
Thanks for the update. I think overall the code would be OK, but the problem is that it's a way too big single patch to digest.
Could you try to instruct LLM for splitting logically for easier reviews? It could be like starting with the core probe skeleton, polytec core stuff, basic PCM loops, the mixer support, the MIDI support, kunit, documentation, something else I forgot, etc.
Takashi
Quoted 143 lines · Takashi Iwai
Quoted 131 lines · Frank van de Pol
Hi Takashi, Jaroslav, and the ALSA community,
Apologies for the long gap since v3. This is not simply v3 with the review comments addressed -- I went back to the reverse engineering, and a fair amount of what came out of it changed the driver structurally.
The patch has grown accordingly: v3 was 8 files and 1613 insertions, this is 17 and 7326. Most of that is not new logic: of the roughly 5700 added lines, about 2100 are comments, 1660 are KUnit tests and generated test vectors for the codec, 249 are the new
jockey3.rstdocumentation, and only about 1300 are executable code. The rest is blank lines andKconfigplumbing.The relatively large number of comments comes from the deliberate decision to include what I learned from the protocol analysis with the relevant section of code. The parts that most need explaining (the bit-plane wire format, device initialization, why the URBs run for the device's whole lifetime, the locking order etc.) cannot be verified by reading the code alone.
ploytec_codec.cis over half comment for that reason: the DOC: block deriving the format from the board's I2S and DMA geometry is effectively the specification the optimized variants implement.Previous version:
v3: https://lore.kernel.org/all/[email protected]/Changes v3 -> v4:
- Reworked the locking architecture around an explicit hierarchy: a process-context
rate_mutexoutermost, then IRQ-safe leaf spinlocks for playback, capture and MIDI that are never nested in one another. Documented injockey3.c.- Fixed the capture stall after a sample-rate change, eliminating the USB device reset that recovery used to require. The reset rate per rate change went from 19.3% to zero, with a 98k clean streak on arm64 and 61k on
x86_64.- Rewrote the bit-plane codec: a portable reference implementation plus 32-bit and 64-bit SWAR variants selected at compile time, called through a batch API at the driver's real batch sizes. Against the same machine's reference build, the optimized path measures 11.0x encode / 7.8x decode on
x86_64and 6.9x / 6.1x on arm64. KUnit tests validate all variants against an independently derived model of the wire format.- Added URB coalescing. The driver used to submit one 512-byte packet per URB, fixing the completion rate at 9923/s at 44.1 kHz and 21600/s at 96 kHz for as long as the device was plugged in, used or not. N packets per URB (N a power of two, 1 to 8) are now chosen per PCM open from the requested period size.
- Fixed a cold-boot initialization race. Straight after power-on the device accepts the entire init sequence, reports success on every transfer, takes playback samples, but its audio engine never starts. Bisected over 100 cold boots to between 144 and 156 ms after enumeration; the driver now waits 250 ms before its first control transfer, close to the 297-308 ms the Windows driver waits.
- Added a URB liveness watchdog. Every error path hangs off a URB completion, so a device that stops completing URBs produces no error, no xrun and no log line. A work item now reports either direction silent for 20 ms and enters the recovery ladder on a stall onset.
- Hardened handling of an unresponsive device: an EP0 error-class predicate aborts the handshake before
usb_set_interface()is reached, since the USB core disables an interface's endpoints as its first action and does not re-enable them on the failure return.- Added
Documentation/sound/cards/jockey3.rst- Addressed the v3 review comments.
Testing:
Validated with an automated hardware-in-the-loop framework written for the
purpose: probe and unbind endurance, PCM cycling, every rate in both directions, period and buffer boundary matrices, duplex, xrun injection, rate-change soaks, suspend/resume, USB disconnects via hub port power switching, and cold-boot cycling through a network-controlled mains switch. Some of the figures above come from runs of tens of thousands of iterations.Exercised on real hardware on
x86_64, i386, arm64 (Raspberry Pi 4) and armv6/armhf (Raspberry Pi 1B -- functional but tight at 88.2/96 kHz), withx86_64and arm64 also run under a KASAN + lockdep debug kernel. The codec KUnit suite additionally tested under UML and QEMU on i386, arm, arm64, riscv and s390 (test big/little endianness).Two things I would rather state than have found:
- The mitigation stack around the rate-change stall is now practically dormant since the rate-change improvement. I kept it as cheap insurance; happy to remove it.
- The 250 ms settling delay in
jockey3_initialize()runs on the USB hub thread. I can move initialization off the probe path if you prefer, though that introduces complexity to avoid races.I look forward to your review/feedback.
Best regards,
FrankFrank van de Pol (1):
ALSA: usb: Add support for Reloop Jockey 3 DJ controllersDocumentation/sound/cards/index.rst | 1 + Documentation/sound/cards/jockey3.rst | 249 + MAINTAINERS | 8 + sound/usb/Kconfig | 1 + sound/usb/Makefile | 1 + sound/usb/jockey3/.kunitconfig | 13 + sound/usb/jockey3/Kconfig | 60 + sound/usb/jockey3/Makefile | 7 + sound/usb/jockey3/jockey3.c | 4060 +++++++++++++++++ sound/usb/jockey3/ploytec_codec.c | 656 +++ sound/usb/jockey3/ploytec_codec.h | 44 + sound/usb/jockey3/ploytec_codec_kunit.c | 871 ++++ .../usb/jockey3/ploytec_codec_test_vectors.h | 793 ++++ sound/usb/jockey3/ploytec_midi.c | 83 + sound/usb/jockey3/ploytec_midi.h | 36 + sound/usb/jockey3/ploytec_proto.c | 365 ++ sound/usb/jockey3/ploytec_proto.h | 78 + 17 files changed, 7326 insertions(+) create mode 100644 Documentation/sound/cards/jockey3.rst create mode 100644 sound/usb/jockey3/.kunitconfig create mode 100644 sound/usb/jockey3/Kconfig create mode 100644 sound/usb/jockey3/Makefile create mode 100644 sound/usb/jockey3/jockey3.cQuoted 8 lines
create mode 100644 sound/usb/jockey3/ploytec_codec.c create mode 100644 sound/usb/jockey3/ploytec_codec.h create mode 100644 sound/usb/jockey3/ploytec_codec_kunit.c create mode 100644 sound/usb/jockey3/ploytec_codec_test_vectors.h create mode 100644 sound/usb/jockey3/ploytec_midi.c create mode 100644 sound/usb/jockey3/ploytec_midi.h create mode 100644 sound/usb/jockey3/ploytec_proto.c create mode 100644 sound/usb/jockey3/ploytec_proto.h
Quoted 7 lines
Thanks for the update. I think overall the code would be OK, but the problem is that it's a way too big single patch to digest.
Could you try to instruct LLM for splitting logically for easier reviews? It could be like starting with the core probe skeleton, polytec core stuff, basic PCM loops, the mixer support, the MIDI support, kunit, documentation, something else I forgot, etc.
And, you don't have to list up all models you've used in Assisted-by tag; just put a single "Assisted-by: LLM" should suffice (and even preferred).
Takashi
Quoted 9 lines · Takashi Iwai
Thanks for the update. I think overall the code would be OK, but the problem is that it's a way too big single patch to digest.
Could you try to instruct LLM for splitting logically for easier reviews? It could be like starting with the core probe skeleton, polytec core stuff, basic PCM loops, the mixer support, the MIDI support, kunit, documentation, something else I forgot, etc.
Thanks Takashi,
That makes sense. I'm not sure I'd trust the LLM to do that splitting by itself, but I can see a couple of large-chuncks that could be separated out as individual patches in a patch-set while maintaining a "buildable" driver.
Will also simplify the "Assisted-by tag" as per your recommendation.
Thanks,
Frank.