pinctrl: fix CONFIG_PINCTRL=n build failure
Subsystems (2)
PATCH 1/1 pinctrl: fix CONFIG_PINCTRL=n build failure
From: Arnd Bergmann <[email protected]>
If pinctrl/consumer.h is included before linux/errno.h, the missing error number macros cause a build failure:
In file included from drivers/gpu/drm/tilcdc/tilcdc_drv.c:9:include/linux/pinctrl/consumer.h:110:10: error: use of undeclared identifier 'ENOTSUPP'
110 | return -ENOTSUPP;
| ^~~~~~~~Include linux/errno.h indirectly.
--- include/linux/pinctrl/consumer.h | 1 + 1 file changed, 1 insertion(+)
include/linux/pinctrl/consumer.h +1 -0
@@ -12,6 +12,7 @@#define __LINUX_PINCTRL_CONSUMER_H#include <linux/err.h> +#include <linux/errno.h> #include <linux/types.h> #include <linux/pinctrl/pinctrl-state.h>
Signature · 1 line
2.53.0
Linus Walleij
maintainerQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
If
pinctrl/consumer.his included beforelinux/errno.h, the missing error number macros cause a build failure:In file included from
drivers/gpu/drm/tilcdc/tilcdc_drv.c:9:include/linux/pinctrl/consumer.h:110:10: error: use of undeclared identifier 'ENOTSUPP'
Quoted 7 lines
110 | return -ENOTSUPP; | ^~~~~~~~Include
linux/errno.hindirectly.Fixes b44aec87658e ("pinctrl: make the CONFIG_PINCTRL=n gpio config stubs return -ENOTSUPP")Signed-off-by Arnd Bergmann <[email protected]>
I think this is already fixed by:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?id=c2d996d9c6dab31ae41d19507c2b7ef8dbc14602
But thanks!
Yours,
Linus Walleij
Quoted 12 lines · Linus Walleij
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
If
pinctrl/consumer.his included beforelinux/errno.h, the missing error number macros cause a build failure:In file included from
drivers/gpu/drm/tilcdc/tilcdc_drv.c:9:include/linux/pinctrl/consumer.h:110:10: error: use of undeclared identifier 'ENOTSUPP'110 | return -ENOTSUPP; | ^~~~~~~~
Quoted 7 lines
Quoted 4 lines
Include
linux/errno.hindirectly.Fixes b44aec87658e ("pinctrl: make the CONFIG_PINCTRL=n gpio config stubs return -ENOTSUPP")Signed-off-by Arnd Bergmann <[email protected]>I think this is already fixed by:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?id=c2d996d9c6dab31ae41d19507c2b7ef8dbc14602
Right, I was still on yesterday's linux-next, so I did not see that.
Arnd