Skip to contentSkip to conversation

tty: add break_wait kernel-doc

PATCH In review Johan Hovold 4 participants 6 messages Sep 25 – Sep 26 TTY layer and serial drivers

lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 tty: add break_wait kernel-doc

Add the missing kernel-doc description for the new break_wait field in struct tty_struct.

Fixes c7e9bff9b4b3 ("tty: abort break signalling on hangup")
Reported-by Randy Dunlap <[email protected]>
Link https://lore.kernel.org/[email protected] open here
Signed-off-by Johan Hovold <[email protected]>
---
 include/linux/tty.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/tty.h +1 -0
index ad4e4a835f90..833bb7b97ceb 100644
@@ -168,6 +168,7 @@ struct tty_operations;
  * @write_wait: concurrent writers are waiting in this queue until they are
  *		allowed to write
  * @read_wait: readers wait for data in this queue
+ * @break_wait: wait queue for timed breaks
  * @hangup_work: normally a work to perform a hangup (do_tty_hangup()); while
  *		 freeing the tty, (re)used to release_one_tty()
  * @disc_data: pointer to @ldisc's private data (e.g. to &struct n_tty_data)
Signature · 1 line
2.55.0
AI review
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines

Add the missing kernel-doc description for the new break_wait field in struct tty_struct.

Fixes c7e9bff9b4b3 ("tty: abort break signalling on hangup")
Reported-by Randy Dunlap <[email protected]>
Link https://lore.kernel.org/[email protected] open here
Signed-off-by Johan Hovold <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
maintainer
#2 lore raw
In reply to Johan Hovold
Quoted 4 lines · Johan Hovold

Add the missing kernel-doc description for the new break_wait field in struct tty_struct.

Fixes c7e9bff9b4b3 ("tty: abort break signalling on hangup")

Don't you mean:

	845a2737e0f5 ("tty: abort break signalling on hangup")

?

thanks,

greg k-h

author
#3 lore raw
Quoted 9 lines · Greg Kroah-Hartman
Quoted 4 lines · Johan Hovold

Add the missing kernel-doc description for the new break_wait field in struct tty_struct.

Fixes c7e9bff9b4b3 ("tty: abort break signalling on hangup")

Don't you mean:

	845a2737e0f5 ("tty: abort break signalling on hangup")

?

Yes, sorry. Can you fix it up when applying or do you want me to resend?

Johan

maintainer
#4 lore raw
Quoted 5 lines · Johan Hovold
Quoted 4 lines · Greg Kroah-Hartman
Quoted 3 lines · Johan Hovold

Add the missing kernel-doc description for the new break_wait field in struct tty_struct.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Fixes c7e9bff9b4b3 ("tty: abort break signalling on hangup")

Don't you mean:

	845a2737e0f5 ("tty: abort break signalling on hangup")

?

Yes, sorry. Can you fix it up when applying or do you want me to resend?

I'll fix it up, no worries, thanks.

greg k-h

Tested-by Acked-by on v1 1/1
#5 lore raw
In reply to Johan Hovold
Quoted 7 lines · Johan Hovold

Add the missing kernel-doc description for the new break_wait field in struct tty_struct.

Fixes c7e9bff9b4b3 ("tty: abort break signalling on hangup")
Reported-by Randy Dunlap <[email protected]>
Link https://lore.kernel.org/[email protected] open here
Signed-off-by Johan Hovold <[email protected]>

FWIW. Too late, I suppose:

Tested-by Randy Dunlap <[email protected]>
Acked-by Randy Dunlap <[email protected]>

Thanks.

Quoted 16 lines
---
 include/linux/tty.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/tty.h +1 -0
index ad4e4a835f90..833bb7b97ceb 100644
@@ -168,6 +168,7 @@ struct tty_operations;
  * @write_wait: concurrent writers are waiting in this queue until they are
  *		allowed to write
  * @read_wait: readers wait for data in this queue
+ * @break_wait: wait queue for timed breaks
  * @hangup_work: normally a work to perform a hangup (do_tty_hangup()); while
  *		 freeing the tty, (re)used to release_one_tty()
  * @disc_data: pointer to @ldisc's private data (e.g. to &struct n_tty_data)
Signature · 1 line
~Randy