dmaengine: fsl_raid: use !desc for NULL check
PATCH 1/1 dmaengine: fsl_raid: use !desc for NULL check
<= 0 is flagged by sparse as being used for integer, not pointer comparison. Fix the warning.
Signed-off-by Rosen Penev <[email protected]>
--- drivers/dma/fsl_raid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/dma/fsl_raid.c +3 -3
@@ -346,7 +346,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_genq( } desc =fsl_re_chan_alloc_desc (re_chan, flags); -if (desc <=0 ) +if (!desc)return NULL ;if (scf && (flags &DMA_PREP_CONTINUE )) {
@@ -470,7 +470,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_pq( src_cnt +=3 ; desc =fsl_re_chan_alloc_desc (re_chan, flags); -if (desc <=0 ) +if (!desc)return NULL ;/* Filling GenQQ CDB */
@@ -554,7 +554,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_memcpy( } desc =fsl_re_chan_alloc_desc (re_chan, flags); -if (desc <=0 ) +if (!desc)return NULL ;/* Filling move CDB */
Signature · 1 line
2.55.0
Quoted 5 lines · Rosen Penev
<= 0 is flagged by sparse as being used for integer, not pointer comparison. Fix the warning.
Signed-off-by Rosen Penev <[email protected]>---
Reviewed-by Frank Li <[email protected]>
Quoted 37 lines
drivers/dma/fsl_raid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/dma/fsl_raid.c +3
-4@@ -346,7 +346,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_genq( } desc =fsl_re_chan_alloc_desc (re_chan, flags); -if (desc <=0 ) +if (!desc)return NULL ;if (scf && (flags &DMA_PREP_CONTINUE )) {@@ -470,7 +470,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_pq( src_cnt +=3 ; desc =fsl_re_chan_alloc_desc (re_chan, flags); -if (desc <=0 ) +if (!desc)return NULL ;/* Filling GenQQ CDB */ @@ -554,7 +554,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_memcpy( } desc =fsl_re_chan_alloc_desc (re_chan, flags); -if (desc <=0 ) +if (!desc)return NULL ;/* Filling move CDB */ --2.55.0