selftests/mm: cleanup -Wformat issues in hugetlb-mmap
Subsystems (3)
PATCH 1/1 selftests/mm: cleanup -Wformat issues in hugetlb-mmap
Commit ae571cd6015c ("selftests/mm: hugetlb-mmap: add setup of HugeTLB pages") and commit 9c5a65f374f8 ("selftests/mm: merge map_hugetlb into hugepage-mmap") added logs of 'hugepage_size' which has a size_t type. However, the incorrect format specifier '%lu' was used which triggers -Wformat warnings when building for 32-bit:
hugetlb-mmap.c:125:55: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
125 | ksft_print_msg("Default size hugepages (%lu kB)\n", hugepage_size >> 10);
| ~~~ ^~~~~~~~~~~~~~~~~~~
| %zu hugetlb-mmap.c:134:47: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
134 | ksft_exit_skip("Not enough %lu Kb pages\n", hugepage_size >> 10);
| ~~~ ^~~~~~~~~~~~~~~~~~~
| %zuFix this by switching to the expected '%zu' format specifier.
---
Note that I intentionally skipped the 'Fixes:' tag as I've been previously suggested _not_ to use it for kselftest patches. However, I can certainly add one if someone prefers it that way. Thanks!
tools/testing/selftests/mm/hugetlb-mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/mm/hugetlb-mmap.c +2 -2
@@ -122,7 +122,7 @@ int main(int argc, char **argv) hugepage_size =default_huge_page_size ();if (!hugepage_size)ksft_exit_skip ("Could not detect default hugetlb page size." ); -ksft_print_msg ("Default size hugepages (%lu kB)\n" , hugepage_size >>10 ); +ksft_print_msg ("Default size hugepages (%zu kB)\n" , hugepage_size >>10 ); }/* munmap will fail if the length is not page aligned */
@@ -131,7 +131,7 @@ int main(int argc, char **argv)hugetlb_set_nr_pages (hugepage_size, nr);if (hugetlb_free_pages (hugepage_size) < nr) -ksft_exit_skip ("Not enough %lu Kb pages\n" , hugepage_size >>10 ); +ksft_exit_skip ("Not enough %zu Kb pages\n" , hugepage_size >>10 );ksft_set_plan (2 );ksft_print_msg ("Mapping %lu Mbytes\n" , (unsigned long )length >>20 );
Signature · 1 line
2.56.0.rc1.315.gc6ed9934b7-goog
Andrew Morton
maintainerQuoted 12 lines · On Sun, 27 Sep 2026 16:24:18 +0000 Carlos Llamas <[email protected]> wrote:
Commit
ae571cd6015c("selftests/mm: hugetlb-mmap: add setup of HugeTLB pages") and commit9c5a65f374f8("selftests/mm: mergemap_hugetlbinto hugepage-mmap") added logs of 'hugepage_size' which has asize_ttype. However, the incorrect format specifier '%lu' was used which triggers -Wformat warnings when building for 32-bit:hugetlb-mmap.c:125:55: warning: format specifies type 'unsigned long' but the argument has type '
size_t' (aka 'unsigned int') [-Wformat]125 | ksft_print_msg("Default size hugepages (%lu kB)\n", hugepage_size >> 10); | ~~~ ^~~~~~~~~~~~~~~~~~~ | %zu
Quoted 7 lines
hugetlb-mmap.c:134:47: warning: format specifies type 'unsigned long' but the argument has type '
size_t' (aka 'unsigned int') [-Wformat]134 | ksft_exit_skip("Not enough %lu Kb pages\n", hugepage_size >> 10); | ~~~ ^~~~~~~~~~~~~~~~~~~ | %zuFix this by switching to the expected '%zu' format specifier.
Thanks.
Quoted 4 lines
Note that I intentionally skipped the 'Fixes:' tag as I've been previously suggested _not_ to use it for kselftest patches. However, I can certainly add one if someone prefers it that way. Thanks!
I added cc:stable. It's not good and it's worse with -Werror. mm selftests don't presently use -Werror, but quite a few other parts of selftests do this.
Quoted 14 lines · Carlos Llamas
Commit
ae571cd6015c("selftests/mm: hugetlb-mmap: add setup of HugeTLB pages") and commit9c5a65f374f8("selftests/mm: mergemap_hugetlbinto hugepage-mmap") added logs of 'hugepage_size' which has asize_ttype. However, the incorrect format specifier '%lu' was used which triggers -Wformat warnings when building for 32-bit:hugetlb-mmap.c:125:55: warning: format specifies type 'unsigned long' but the argument has type '
size_t' (aka 'unsigned int') [-Wformat]125 | ksft_print_msg("Default size hugepages (%lu kB)\n", hugepage_size >> 10); | ~~~ ^~~~~~~~~~~~~~~~~~~ | %zuhugetlb-mmap.c:134:47: warning: format specifies type 'unsigned long' but the argument has type '
size_t' (aka 'unsigned int') [-Wformat]
Quoted 8 lines
134 | ksft_exit_skip("Not enough %lu Kb pages\n", hugepage_size >> 10); | ~~~ ^~~~~~~~~~~~~~~~~~~ | %zuFix this by switching to the expected '%zu' format specifier.
Cc Mike Rapoport <[email protected]>Signed-off-by Carlos Llamas <[email protected]>
LGTM, so:
Quoted 12 lines · On Sun, 27 Sep 2026 16:24:18 +0000 Carlos Llamas <[email protected]> wrote:
Commit
ae571cd6015c("selftests/mm: hugetlb-mmap: add setup of HugeTLB pages") and commit9c5a65f374f8("selftests/mm: mergemap_hugetlbinto hugepage-mmap") added logs of 'hugepage_size' which has asize_ttype. However, the incorrect format specifier '%lu' was used which triggers -Wformat warnings when building for 32-bit:hugetlb-mmap.c:125:55: warning: format specifies type 'unsigned long' but the argument has type '
size_t' (aka 'unsigned int') [-Wformat]125 | ksft_print_msg("Default size hugepages (%lu kB)\n", hugepage_size >> 10); | ~~~ ^~~~~~~~~~~~~~~~~~~ | %zu
Quoted 7 lines
hugetlb-mmap.c:134:47: warning: format specifies type 'unsigned long' but the argument has type '
size_t' (aka 'unsigned int') [-Wformat]134 | ksft_exit_skip("Not enough %lu Kb pages\n", hugepage_size >> 10); | ~~~ ^~~~~~~~~~~~~~~~~~~ | %zuFix this by switching to the expected '%zu' format specifier.
Looks good to me.
Quoted 3 lines
Cc Mike Rapoport <[email protected]>Signed-off-by Carlos Llamas <[email protected]>
Thanks,
SJ
[...]
Quoted 14 lines · Carlos Llamas
Commit
ae571cd6015c("selftests/mm: hugetlb-mmap: add setup of HugeTLB pages") and commit9c5a65f374f8("selftests/mm: mergemap_hugetlbinto hugepage-mmap") added logs of 'hugepage_size' which has asize_ttype. However, the incorrect format specifier '%lu' was used which triggers -Wformat warnings when building for 32-bit:hugetlb-mmap.c:125:55: warning: format specifies type 'unsigned long' but the argument has type '
size_t' (aka 'unsigned int') [-Wformat]125 | ksft_print_msg("Default size hugepages (%lu kB)\n", hugepage_size >> 10); | ~~~ ^~~~~~~~~~~~~~~~~~~ | %zuhugetlb-mmap.c:134:47: warning: format specifies type 'unsigned long' but the argument has type '
size_t' (aka 'unsigned int') [-Wformat]
Quoted 8 lines
134 | ksft_exit_skip("Not enough %lu Kb pages\n", hugepage_size >> 10); | ~~~ ^~~~~~~~~~~~~~~~~~~ | %zuFix this by switching to the expected '%zu' format specifier.
Cc Mike Rapoport <[email protected]>Signed-off-by Carlos Llamas <[email protected]>
Quoted 32 lines
---
Note that I intentionally skipped the 'Fixes:' tag as I've been previously suggested _not_ to use it for kselftest patches. However, I can certainly add one if someone prefers it that way. Thanks!
tools/testing/selftests/mm/hugetlb-mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/mm/hugetlb-mmap.c +2
-3@@ -122,7 +122,7 @@ int main(int argc, char **argv) hugepage_size =default_huge_page_size ();if (!hugepage_size)ksft_exit_skip ("Could not detect default hugetlb page size." ); -ksft_print_msg ("Default size hugepages (%lu kB)\n" , hugepage_size >>10 ); +ksft_print_msg ("Default size hugepages (%zu kB)\n" , hugepage_size >>10 ); }/* munmap will fail if the length is not page aligned */ @@ -131,7 +131,7 @@ int main(int argc, char **argv)hugetlb_set_nr_pages (hugepage_size, nr);if (hugetlb_free_pages (hugepage_size) < nr) -ksft_exit_skip ("Not enough %lu Kb pages\n" , hugepage_size >>10 ); +ksft_exit_skip ("Not enough %zu Kb pages\n" , hugepage_size >>10 );ksft_set_plan (2 );ksft_print_msg ("Mapping %lu Mbytes\n" , (unsigned long )length >>20 ); --
Quoted 2 lines
2.56.0.rc1.315.gc6ed9934b7-goog
--
Cheers, Lorenzo