Skip to contentSkip to conversation

rust: bindings: fix VM_MAYSHARE blocklist entry

PATCH Applied Miguel Ojeda 5 participants 5 messages Sep 30

Subsystems (3)
Stable branch Memory management Rust
lore
Share & tools
lore

Miguel Ojeda

author maintainer
#0 lore raw

PATCH 1/1 rust: bindings: fix VM_MAYSHARE blocklist entry

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added constant helpers for the VMA flags and blocklist entries to suppress their direct bindings. However, it listed VM_MAYEXEC twice and omitted VM_MAYSHARE.

Thus fix it.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")
Cc [email protected]
Assisted-by LLM
Signed-off-by Miguel Ojeda <[email protected]>
---
 rust/bindgen_parameters | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
rust/bindgen_parameters +1 -1
index 8402b0c93545..93e622aaaf78 100644
@@ -50,7 +50,7 @@
 --blocklist-item VM_MAYREAD
 --blocklist-item VM_MAYWRITE
 --blocklist-item VM_MAYEXEC
---blocklist-item VM_MAYEXEC
+--blocklist-item VM_MAYSHARE
 --blocklist-item VM_PFNMAP
 --blocklist-item VM_IO
 --blocklist-item VM_DONTCOPY

base-commit: 7b5ba47d845f35b04937748a191a1772ffc1f288

Signature · 1 line
2.55.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Miguel Ojeda

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added constant helpers for the VMA flags and blocklist entries to suppress their direct bindings. However, it listed VM_MAYEXEC twice and omitted VM_MAYSHARE.

Thus fix it.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")
Cc [email protected]
Assisted-by LLM
Signed-off-by Miguel Ojeda <[email protected]>
Reviewed-by Alice Ryhl <[email protected]>
Reviewed-by on v1 1/1
#2 lore raw
In reply to Miguel Ojeda
Quoted 10 lines · Miguel Ojeda

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added constant helpers for the VMA flags and blocklist entries to suppress their direct bindings. However, it listed VM_MAYEXEC twice and omitted VM_MAYSHARE.

Thus fix it.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")
Cc [email protected]
Assisted-by LLM
Signed-off-by Miguel Ojeda <[email protected]>

Oops! :) LGTM so:

Reviewed-by Lorenzo Stoakes (ARM) <[email protected]>
Quoted 18 lines
---
 rust/bindgen_parameters | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
rust/bindgen_parameters +1 -1
index 8402b0c93545..93e622aaaf78 100644
@@ -50,7 +50,7 @@
 --blocklist-item VM_MAYREAD
 --blocklist-item VM_MAYWRITE
 --blocklist-item VM_MAYEXEC
---blocklist-item VM_MAYEXEC
+--blocklist-item VM_MAYSHARE
 --blocklist-item VM_PFNMAP
 --blocklist-item VM_IO
 --blocklist-item VM_DONTCOPY
Quoted 4 lines

base-commit: 7b5ba47d845f35b04937748a191a1772ffc1f288 --
2.55.0

--
Cheers, Lorenzo

Applied
#3 lore raw
In reply to Miguel Ojeda
Quoted 11 lines · Miguel Ojeda

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added constant helpers for the VMA flags and blocklist entries to suppress their direct bindings. However, it listed VM_MAYEXEC twice and omitted VM_MAYSHARE.

Thus fix it.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")
Cc [email protected]
Assisted-by LLM
Signed-off-by Miguel Ojeda <[email protected]>

Applied to rust-next to go next to the other one where I noticed it. Thanks everyone!

Cheers,
Miguel

Reviewed-by on v1 1/1
#4 lore raw
In reply to Miguel Ojeda
Quoted 10 lines · Miguel Ojeda

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added constant helpers for the VMA flags and blocklist entries to suppress their direct bindings. However, it listed VM_MAYEXEC twice and omitted VM_MAYSHARE.

Thus fix it.

Fixes 2b6a3f061f11 ("mm: declare VMA flags by bit")
Cc [email protected]
Assisted-by LLM
Signed-off-by Miguel Ojeda <[email protected]>

Nice catch!

Reviewed-by Vishal Moola (Fractile) <[email protected]>