Skip to contentSkip to conversation

Bluetooth: btusb: add ASUS 0b05:1825 to QCA Rome quirks

PATCH Superseded Konstantin Nazarov 2 participants 2 messages Sep 30 Bluetooth drivers

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Bluetooth: btusb: add ASUS 0b05:1825 to QCA Rome quirks

The Bluetooth controller with USB ID 0b05:1825 found on ASUS systems uses a Qualcomm QCA Rome chipset, but is currently matched only by the generic Bluetooth USB entry.

Without BTUSB_QCA_ROME, the driver does not load the QCA rampatch and NVM firmware. BLE scanning also repeatedly reports:

    Bluetooth: hci0: unexpected event for opcode 0x2005

Mark the device as BTUSB_QCA_ROME with wideband speech support, in line with the other QCA Rome USB IDs.

Similar issue but with different device id. After patching bluetooth is working fine, no unexpected events in log.

Tested-on: Qualcomm Atheros QCA6174 SoC integrated in motherboard ASUS Z170I PRO GAMING, USB device id: 0b05:1825

---
 drivers/bluetooth/btusb_main.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/bluetooth/btusb_main.c +2 -0
index 3518f92eb..cc3a021a9 100644
@@ -272,6 +272,8 @@ static const struct usb_device_id quirks_table[] = {
 	{ USB_DEVICE(0x0489, 0xe03c), .driver_info = BTUSB_ATH3012 },
 
 	/* QCA ROME chipset */
+        { USB_DEVICE(0x0b05, 0x1825), .driver_info = BTUSB_QCA_ROME |
+                                                     BTUSB_WIDEBAND_SPEECH },
 	{ USB_DEVICE(0x0b05, 0x1868), .driver_info = BTUSB_QCA_ROME |
 						     BTUSB_WIDEBAND_SPEECH },
 	{ USB_DEVICE(0x0cf3, 0x535b), .driver_info = BTUSB_QCA_ROME |
Signature · 1 line
2.43.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1177199/

---Test result---

Test Summary:

CheckPatch                    FAIL      0.39 seconds
VerifyFixes                   PASS      0.07 seconds
VerifySignedoff               PASS      0.07 seconds
GitLint                       FAIL      0.17 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      16.64 seconds
CheckAllWarning               PASS      19.65 seconds
CheckSparse                   PASS      30.25 seconds
BuildKernel32                 PASS      16.96 seconds
CheckKernelLLVM               PASS      18.18 seconds
TestRunnerSetup               PASS      411.75 seconds
IncrementalBuild              PASS      17.38 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v2] Bluetooth: btusb: add ASUS 0b05:1825 to QCA Rome quirks
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #110:
Similar issue but with different device id. After patching bluetooth is working fine,

ERROR: code indent should use tabs where possible
#131: FILE: drivers/bluetooth/btusb_main.c:275:
+ { USB_DEVICE(0x0b05, 0x1825), .driver_info = BTUSB_QCA_ROME |$

WARNING: please, no spaces at the start of a line
#131: FILE: drivers/bluetooth/btusb_main.c:275:
+ { USB_DEVICE(0x0b05, 0x1825), .driver_info = BTUSB_QCA_ROME |$

ERROR: code indent should use tabs where possible
#132: FILE: drivers/bluetooth/btusb_main.c:276:
+ BTUSB_WIDEBAND_SPEECH },$

WARNING: please, no spaces at the start of a line
#132: FILE: drivers/bluetooth/btusb_main.c:276:
+ BTUSB_WIDEBAND_SPEECH },$

total: 2 errors, 3 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile

/home/runner/work/bluetooth-next/bluetooth-next/src/patch/14859393.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v2] Bluetooth: btusb: add ASUS 0b05:1825 to QCA Rome quirks

15: B1 Line exceeds max length (85>80): "Similar issue but with different device id. After patching bluetooth is working fine,"

https://github.com/bluez/bluetooth-next/pull/846

---
Regards,
Linux Bluetooth