Skip to contentSkip to conversation

drm/xe: use resource_size() in xe_pagemap_create()

PATCH Superseded Aryan Sinha 2 participants 2 messages Oct 1

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/xe: use resource_size() in xe_pagemap_create()

The open coded res->end - res->start + 1 is what resource_size() does.

---
 drivers/gpu/drm/xe/xe_svm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_svm.c +1 -1
index b228a737c..e6ab5a5b3 100644
@@ -1848,7 +1848,7 @@ static struct xe_pagemap *xe_pagemap_create(struct xe_device *xe, struct xe_vram
 out_no_pages:
 	drm_pagemap_release_owner(&xpagemap->peer);
 out_no_owner:
-	devm_release_mem_region(dev, res->start, res->end - res->start + 1);
+	devm_release_mem_region(dev, res->start, resource_size(res));
 out_err:
 	drm_pagemap_put(dpagemap);
 	return ERR_PTR(err);
Signature · 1 line
2.46.0
maintainer
#1 lore raw
Quoted 1 line · Aryan Sinha

The open coded res->end - res->start + 1 is what resource_size() does.

nit: we should use imperative telling the change and why. this is just the why...

Quoted 11 lines
---
 drivers/gpu/drm/xe/xe_svm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_svm.c +0 -0
index b228a737c..e6ab5a5b3 100644

drivers/gpu/drm/xe/xe_svm.c static struct xe_pagemap *xe_pagemap_create(struct xe_device *xe, struct xe_vram · line 1851

Quoted 4 lines
drivers/gpu/drm/xe/xe_svm.c +0 -1
@@ -1848,7 +1848,7 @@ static struct xe_pagemap *xe_pagemap_create(struct xe_device *xe, struct xe_vram
 out_no_pages:
 	drm_pagemap_release_owner(&xpagemap->peer);
 out_no_owner:
-	devm_release_mem_region(dev, res->start, res->end - res->start + 1);

I noticed we are not including the linux/ioport.h here.
We should do this explicit. I know, we should had done it already when using the struct resource. But now it makes more important. Please add it.

Thanks for the contribution,
Rodrigo.

Quoted 7 lines
drivers/gpu/drm/xe/xe_svm.c +1 -0
+	devm_release_mem_region(dev, res->start, resource_size(res));
 out_err:
 	drm_pagemap_put(dpagemap);
 	return ERR_PTR(err);
Signature · 1 line
2.46.0