media: uvcvideo: Remove unused active field
Subsystems (2)
PATCH 1/1 media: uvcvideo: Remove unused active field
The active field in struct uvc_streaming is not used anymore, drop it.
--- drivers/media/usb/uvc/uvc_video.c | 2 -- drivers/media/usb/uvc/uvcvideo.h | 1 - 2 files changed, 3 deletions(-)
drivers/media/usb/uvc/uvc_video.c +0 -2
@@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)return -EINVAL ; } -atomic_set (&stream->active,0 ); -/* * Alternate setting 0 should be the default, yet the XBox Live Vision * Cam (and possibly other devices) crash or otherwise misbehave if
drivers/media/usb/uvc/uvcvideo.h +0 -1
@@ -456,7 +456,6 @@ struct uvc_streaming {struct list_head list;struct uvc_device *dev;struct uvc_video_chain *chain; -atomic_t active;struct usb_interface *intf;int intfnum;
---
base-commit: 253355887a1ab0ac8f33b356c7c1140eee554d18
change-id: 20260630-uvc-remove-active-8843181bcbb4
Best regards,
Signature · 1 line
Ricardo Ribalda <[email protected]>
Quoted 1 line · Ricardo Ribalda
The active field in struct
uvc_streamingis not used anymore, drop it.
Easy one, I like that :-)
Quoted 4 lines
Reported-by Hans de Goede <[email protected]>Closes https://lore.kernel.org/linux-media/[email protected]/T/#m3078f0d5fd71435b5cfacaa5c99f23a446db581f open hereFixes c93d73c9c2cf ("media: uvcvideo: Use vb2 ioctl and fop helpers")Signed-off-by Ricardo Ribalda <[email protected]>
Quoted 34 lines
--- drivers/media/usb/uvc/uvc_video.c | 2 -- drivers/media/usb/uvc/uvcvideo.h | 1 - 2 files changed, 3 deletions(-)drivers/media/usb/uvc/uvc_video.c +0
-2@@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)return -EINVAL ; } -atomic_set (&stream->active,0 ); -/* * Alternate setting 0 should be the default, yet the XBox Live Vision * Cam (and possibly other devices) crash or otherwise misbehave if drivers/media/usb/uvc/uvcvideo.h +0
-2@@ -456,7 +456,6 @@ struct uvc_streaming {struct list_head list;struct uvc_device *dev;struct uvc_video_chain *chain; -atomic_t active;struct usb_interface *intf;int intfnum; ---base-commit:
253355887a1ab0ac8f33b356c7c1140eee554d18
change-id: 20260630-uvc-remove-active-8843181bcbb4
Signature · 3 lines
Regards, Laurent Pinchart
Laurent Pinchart
maintainerQuoted 8 lines · Laurent Pinchart
Quoted 1 line · Ricardo Ribalda
The active field in struct
uvc_streamingis not used anymore, drop it.Easy one, I like that :-)
Quoted 3 lines
Reported-by Hans de Goede <[email protected]>Closes https://lore.kernel.org/linux-media/[email protected]/T/#m3078f0d5fd71435b5cfacaa5c99f23a446db581f open hereFixes c93d73c9c2cf ("media: uvcvideo: Use vb2 ioctl and fop helpers")
CI has flagged that this requires a Cc: stable. As I don't think there's a need to backport this, I'll drop the Fixes tag.
Quoted 38 lines
Quoted 1 line
Signed-off-by Ricardo Ribalda <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>Quoted 34 lines
--- drivers/media/usb/uvc/uvc_video.c | 2 -- drivers/media/usb/uvc/uvcvideo.h | 1 - 2 files changed, 3 deletions(-)drivers/media/usb/uvc/uvc_video.c +0
-2@@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)return -EINVAL ; } -atomic_set (&stream->active,0 ); -/* * Alternate setting 0 should be the default, yet the XBox Live Vision * Cam (and possibly other devices) crash or otherwise misbehave if drivers/media/usb/uvc/uvcvideo.h +0
-2@@ -456,7 +456,6 @@ struct uvc_streaming {struct list_head list;struct uvc_device *dev;struct uvc_video_chain *chain; -atomic_t active;struct usb_interface *intf;int intfnum; ---base-commit:
253355887a1ab0ac8f33b356c7c1140eee554d18
change-id: 20260630-uvc-remove-active-8843181bcbb4
Signature · 3 lines
Regards, Laurent Pinchart
Hi,
Quoted 6 lines · Ricardo Ribalda
The active field in struct
uvc_streamingis not used anymore, drop it.Reported-by Hans de Goede <[email protected]>Closes https://lore.kernel.org/linux-media/[email protected]/T/#m3078f0d5fd71435b5cfacaa5c99f23a446db581f open hereFixes c93d73c9c2cf ("media: uvcvideo: Use vb2 ioctl and fop helpers")Signed-off-by Ricardo Ribalda <[email protected]>
Thanks, patch looks good to me:
Regards,
Hans
Quoted 36 lines
--- drivers/media/usb/uvc/uvc_video.c | 2 -- drivers/media/usb/uvc/uvcvideo.h | 1 - 2 files changed, 3 deletions(-)drivers/media/usb/uvc/uvc_video.c +0
-2@@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)return -EINVAL ; } -atomic_set (&stream->active,0 ); -/* * Alternate setting 0 should be the default, yet the XBox Live Vision * Cam (and possibly other devices) crash or otherwise misbehave if drivers/media/usb/uvc/uvcvideo.h +0
-2@@ -456,7 +456,6 @@ struct uvc_streaming {struct list_head list;struct uvc_device *dev;struct uvc_video_chain *chain; -atomic_t active;struct usb_interface *intf;int intfnum; ---base-commit:
253355887a1ab0ac8f33b356c7c1140eee554d18
change-id: 20260630-uvc-remove-active-8843181bcbb4Best regards,
Hans de Goede
maintainerHi,
Quoted 6 lines · Ricardo Ribalda
The active field in struct
uvc_streamingis not used anymore, drop it.Reported-by Hans de Goede <[email protected]>Closes https://lore.kernel.org/linux-media/[email protected]/T/#m3078f0d5fd71435b5cfacaa5c99f23a446db581f open hereFixes c93d73c9c2cf ("media: uvcvideo: Use vb2 ioctl and fop helpers")Signed-off-by Ricardo Ribalda <[email protected]>
Thank you for your patch.
I have merged this into:
https://gitlab.freedesktop.org/linux-media/users/uvc/-/commits/for-next/
Regards,
Hans
Quoted 36 lines
--- drivers/media/usb/uvc/uvc_video.c | 2 -- drivers/media/usb/uvc/uvcvideo.h | 1 - 2 files changed, 3 deletions(-)drivers/media/usb/uvc/uvc_video.c +0
-2@@ -2229,8 +2229,6 @@ int uvc_video_init(struct uvc_streaming *stream)return -EINVAL ; } -atomic_set (&stream->active,0 ); -/* * Alternate setting 0 should be the default, yet the XBox Live Vision * Cam (and possibly other devices) crash or otherwise misbehave if drivers/media/usb/uvc/uvcvideo.h +0
-2@@ -456,7 +456,6 @@ struct uvc_streaming {struct list_head list;struct uvc_device *dev;struct uvc_video_chain *chain; -atomic_t active;struct usb_interface *intf;int intfnum; ---base-commit:
253355887a1ab0ac8f33b356c7c1140eee554d18
change-id: 20260630-uvc-remove-active-8843181bcbb4Best regards,