arm: dts: qcom: Format with dtfmt
cover arm: dts: qcom: Format with dtfmt
I was looking through the notes for the last Devicetree microconference at Linux Plumbers (LPC) 2025 [1], and realized that the tool I have been working on might be of interest here: dtfmt - a Devicetree Source formatter [2].
dtfmt uses a parser with lexical grammar (tree-sitter) directly ported from the actual Device Tree Compiler's (dtc) lexer/parser, also (hand)written by me [3]. It is primarily designed for the Linux kernel and currently parses all 6872 devicetree files in the tree successfully (found with find . -iregex ".+\.dts[io]?$").
This tool was developed out of frustration when reviewing devicetree patches internally at my company Axis. I would have published it earlier if I was aware of the on-going discussions at LPC 2025. It only caught my attention since I'm planning to attend LPC this year (especially the Devicetree microconference and would therefore love to discuss this more in-person!).
This patch series is only a small demonstration of dtfmt, primarily to get Konrad Dybcio in the "To:"-field (who did the presentation on LPC 2025). Obviously one can run dtfmt for all files and generate a much bigger diff. There have been patches sent for arch/arm64/boot/dts/exynos/ previously [4].
Please note that since we don't currently have a _definitive_ style guide for Devictree Source files, dtfmt tries to be pragmatic and try to "guess" the intended style (e.g. alignment of arrays and comma separated property data). Some things have been left out (for now) or manually edited, because it's too hard to implement without any concrete style decisions in place (e.g. alignment of comments, long line wrapping etc.). dtfmt will continue to develop and will always align with the Linux kernel. Feedback (and collaboration) is therefore greatly appreciated!
[1] https://lpc.events/event/19/sessions/237/attachments/1713/4459/Notes%20-%20Devicetree%20MC%20-%20LPC%202025.pdf
[2] https://codeberg.org/whame/dtfmt
Mirror: https://github.com/whame/dtfmt
[3] https://codeberg.org/whame/tree-sitter-devicetree
Mirror: https://github.com/whame/tree-sitter-devicetree
[4] https://lore.kernel.org/lkml/[email protected]/
Waqar Hameed (38):
arm: dts: qcom: pm8226: Add newline between subnodes
arm: dts: qcom: pm8841: Remove superfluous empty lines
arm: dts: qcom: pm8921: Remove superfluous empty lines
arm: dts: qcom: pm8941: Remove superfluous empty lines
arm: dts: qcom: pm8084: Remove superfluous empty line
arm: dts: qcom: apq8026: Add newline between subnodes
arm: dts: qcom: apq8026: Add space between OR-operator
arm: dts: qcom: apq8060: Add newline between subnodes
arm: dts: qcom: apq8060: Align multiple property data
arm: dts: qcom: apq8060: Indent property data with tab
arm: dts: qcom: apq8064: Add newline between subnodes
arm: dts: qcom: apq8064: Remove empty line at end of node
arm: dts: qcom: apq8064: Add space before line comments
arm: dts: qcom: apq8064: Align multiple property data
arm: dts: qcom: apq8064: Remove tab after property name
arm: dts: qcom: ipq4018: Indent closing brace properly
arm: dts: qcom: ipq4019: Add newline between subnodes
arm: dts: qcom: ipq4019: Align multiple property data
arm: dts: qcom: ipq4019: Break long property array data
arm: dts: qcom: ipq8064: Add newline between subnodes
arm: dts: qcom: ipq8064: Align multiple property data
arm: dts: qcom: ipq8064: Break long property array data
arm: dts: qcom: msm8226: Add space between OR-operator
arm: dts: qcom: msm8226: Add newline between subnodes
arm: dts: qcom: ipq8064: Break long property array data
arm: dts: qcom: msm8226: Align multiple property data
arm: dts: qcom: msm8660: Remove empty line at end of node
arm: dts: qcom: msm8660: Remove space inside array property
arm: dts: qcom: msm8660: Align closing array bracket
arm: dts: qcom: msm8916: Add newline between subnodes
arm: dts: qcom: msm8960: Properly indent subnodes
arm: dts: qcom: msm8660: Align closing array bracket
arm: dts: qcom: msm8974: Align multiple property data
arm: dts: qcom: msm8974: Align closing brace properly
arm: dts: qcom: msm8974: Add newline between subnodes
arm: dts: qcom: sdx55: Properly indent subnode
arm: dts: qcom: sdx65: Remove empty line at end of node
arm: dts: qcom: sdx65: Align multiple property data
arch/arm/boot/dts/qcom/pm8226.dtsi | 5 + arch/arm/boot/dts/qcom/pm8841.dtsi | 2 - arch/arm/boot/dts/qcom/pm8921.dtsi | 2 - arch/arm/boot/dts/qcom/pm8941.dtsi | 3 - arch/arm/boot/dts/qcom/pma8084.dtsi | 1 - .../dts/qcom/qcom-apq8026-asus-sparrow.dts | 32 +++++ .../boot/dts/qcom/qcom-apq8026-lg-lenok.dts | 27 +++++ .../qcom/qcom-apq8026-samsung-milletwifi.dts | 4 +- .../dts/qcom/qcom-apq8060-dragonboard.dts | 54 ++++++--- .../dts/qcom/qcom-apq8064-asus-nexus7-flo.dts | 7 +- .../qcom-apq8064-sony-xperia-lagan-yuga.dts | 1 - arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 114 +++++++++--------- .../boot/dts/qcom/qcom-ipq4018-ap120c-ac.dtsi | 3 +- .../boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi | 1 + .../boot/dts/qcom/qcom-ipq4019-ap.dk04.1.dtsi | 11 +- .../dts/qcom/qcom-ipq4019-ap.dk07.1-c1.dts | 3 +- arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 16 ++- arch/arm/boot/dts/qcom/qcom-ipq8064-v1.0.dtsi | 1 + arch/arm/boot/dts/qcom/qcom-ipq8064-v2.0.dtsi | 1 + arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 29 +++-- .../qcom-msm8226-samsung-matisse-common.dtsi | 4 +- arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 18 ++- arch/arm/boot/dts/qcom/qcom-msm8660-surf.dts | 2 +- arch/arm/boot/dts/qcom/qcom-msm8660.dtsi | 6 +- arch/arm/boot/dts/qcom/qcom-msm8916-smp.dtsi | 3 + arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 18 +-- arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 24 +++- arch/arm/boot/dts/qcom/qcom-sdx55-t55.dts | 10 +- arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 14 +-- 29 files changed, 264 insertions(+), 152 deletions(-)
base-commit: 6c2cb8b8b843d216ab549b678a0d8831c43153e0
Signature · 1 line
2.43.0
PATCH 1/38 arm: dts: qcom: pm8226: Add newline between subnodes
There should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/pm8226.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/qcom/pm8226.dtsi +5 -0
@@ -109,21 +109,26 @@ channel@7 { qcom,pre-scaling = <1 3>; label = "vph_pwr"; }; + channel@8 { reg = <VADC_DIE_TEMP>; label = "die_temp"; }; + channel@9 { reg = <VADC_REF_625MV>; label = "ref_625mv"; }; + channel@a { reg = <VADC_REF_1250MV>; label = "ref_1250mv"; }; + channel@e { reg = <VADC_GND_REF>; }; + channel@f { reg = <VADC_VDD_VADC>; };
Signature · 1 line
2.43.0
Re: [PATCH 01/38] arm: dts: qcom: pm8226: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 2/38 arm: dts: qcom: pm8841: Remove superfluous empty lines
In reply to Waqar HameedThere shouldn't be a newline at the start of node definition or multiple empty lines. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/pm8841.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/qcom/pm8841.dtsi +0 -2
@@ -2,7 +2,6 @@ #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/spmi/spmi.h> - / { thermal-zones { pm8841-thermal {
@@ -34,7 +33,6 @@ crit { }; &spmi_bus { - pm8841_0: pm8841@4 { compatible = "qcom,pm8841", "qcom,spmi-pmic"; reg = <0x4 SPMI_USID>;
Signature · 1 line
2.43.0
Re: [PATCH 02/38] arm: dts: qcom: pm8841: Remove superfluous empty lines
Quoted 5 lines · Waqar Hameed
There shouldn't be a newline at the start of node definition or multiple empty lines. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 3/38 arm: dts: qcom: pm8921: Remove superfluous empty lines
In reply to Waqar HameedThere shouldn't be a newline at the start or end of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/pm8921.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/qcom/pm8921.dtsi +0 -2
@@ -53,7 +53,6 @@ pm8921_keypad: keypad@148 { }; pm8921_gpio: gpio@150 { - compatible = "qcom,pm8921-gpio", "qcom,ssbi-gpio"; reg = <0x150>;
@@ -62,7 +61,6 @@ pm8921_gpio: gpio@150 { gpio-controller; gpio-ranges = <&pm8921_gpio 0 0 44>; #gpio-cells = <2>; - }; pm8921_xoadc: xoadc@197 {
Signature · 1 line
2.43.0
Re: [PATCH 03/38] arm: dts: qcom: pm8921: Remove superfluous empty lines
Quoted 5 lines · Waqar Hameed
There shouldn't be a newline at the start or end of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 4/38 arm: dts: qcom: pm8941: Remove superfluous empty lines
In reply to Waqar HameedThere shouldn't be a newline at the start of node definition or multiple empty lines. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/pm8941.dtsi | 3 --- 1 file changed, 3 deletions(-)
arch/arm/boot/dts/qcom/pm8941.dtsi +0 -3
@@ -3,7 +3,6 @@ #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/spmi/spmi.h> - / { thermal-zones { pm8941-thermal {
@@ -35,7 +34,6 @@ crit { }; &spmi_bus { - pm8941_0: pm8941@0 { compatible = "qcom,pm8941", "qcom,spmi-pmic"; reg = <0x0 SPMI_USID>;
@@ -146,7 +144,6 @@ pm8941_vadc: adc@3100 { #size-cells = <0>; #io-channel-cells = <1>; - channel@6 { reg = <VADC_VBAT_SNS>; };
Signature · 1 line
2.43.0
Re: [PATCH 04/38] arm: dts: qcom: pm8941: Remove superfluous empty lines
Quoted 5 lines · Waqar Hameed
There shouldn't be a newline at the start of node definition or multiple empty lines. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 5/38 arm: dts: qcom: pm8084: Remove superfluous empty line
In reply to Waqar HameedThere shouldn't be a newline at the start of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/pma8084.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/arm/boot/dts/qcom/pma8084.dtsi +0 -1
@@ -5,7 +5,6 @@ #include <dt-bindings/spmi/spmi.h> &spmi_bus { - pma8084_0: pma8084@0 { compatible = "qcom,pma8084", "qcom,spmi-pmic"; reg = <0x0 SPMI_USID>;
Signature · 1 line
2.43.0
Re: [PATCH 05/38] arm: dts: qcom: pm8084: Remove superfluous empty line
Quoted 5 lines · Waqar Hameed
There shouldn't be a newline at the start of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 6/38 arm: dts: qcom: apq8026: Add newline between subnodes
In reply to Waqar HameedThere should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- .../dts/qcom/qcom-apq8026-asus-sparrow.dts | 32 +++++++++++++++++++ .../boot/dts/qcom/qcom-apq8026-lg-lenok.dts | 27 ++++++++++++++++ 2 files changed, 59 insertions(+)
arch/arm/boot/dts/qcom/qcom-apq8026-asus-sparrow.dts +32 -0
@@ -22,22 +22,27 @@ sbl_region: sbl@2f00000 { reg = <0x02f00000 0x100000>; no-map; }; + external_image_region: external-image@3100000 { reg = <0x3100000 0x200000>; no-map; }; + peripheral_region: peripheral@3300000 { reg = <0x3300000 0x600000>; no-map; }; + adsp_region: adsp@3900000 { reg = <0x3900000 0x1400000>; no-map; }; + modem_region: modem@4d00000 { reg = <0x4d00000 0x1b00000>; no-map; }; + modem_efs_region: modem-efs@7f00000 { reg = <0x7f00000 0x100000>; no-map;
@@ -94,10 +99,12 @@ pm8226_s3: s3 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1300000>; }; + pm8226_s4: s4 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2200000>; }; + pm8226_s5: s5 { regulator-min-microvolt = <1150000>; regulator-max-microvolt = <1150000>;
@@ -107,102 +114,127 @@ pm8226_l1: l1 { regulator-min-microvolt = <1225000>; regulator-max-microvolt = <1225000>; }; + pm8226_l2: l2 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; }; + pm8226_l3: l3 { regulator-min-microvolt = <750000>; regulator-max-microvolt = <1337500>; }; + pm8226_l4: l4 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; }; + pm8226_l5: l5 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; }; + pm8226_l6: l6 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l7: l7 { regulator-min-microvolt = <1900000>; regulator-max-microvolt = <1900000>; }; + pm8226_l8: l8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l9: l9 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l10: l10 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l12: l12 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l14: l14 { regulator-min-microvolt = <2750000>; regulator-max-microvolt = <2750000>; }; + pm8226_l15: l15 { regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; }; + pm8226_l16: l16 { regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; }; + pm8226_l17: l17 { regulator-min-microvolt = <2950000>; regulator-max-microvolt = <2950000>; }; + pm8226_l18: l18 { regulator-min-microvolt = <2950000>; regulator-max-microvolt = <2950000>; }; + pm8226_l19: l19 { regulator-min-microvolt = <2850000>; regulator-max-microvolt = <2850000>; }; + pm8226_l20: l20 { regulator-min-microvolt = <3075000>; regulator-max-microvolt = <3075000>; }; + pm8226_l21: l21 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2950000>; }; + pm8226_l22: l22 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2950000>; }; + pm8226_l23: l23 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l24: l24 { regulator-min-microvolt = <1300000>; regulator-max-microvolt = <1350000>; }; + pm8226_l25: l25 { regulator-min-microvolt = <1775000>; regulator-max-microvolt = <2125000>; }; + pm8226_l26: l26 { regulator-min-microvolt = <1225000>; regulator-max-microvolt = <1225000>; }; + pm8226_l27: l27 { regulator-min-microvolt = <2050000>; regulator-max-microvolt = <2050000>; }; + pm8226_l28: l28 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2950000>;
arch/arm/boot/dts/qcom/qcom-apq8026-lg-lenok.dts +27 -0
@@ -157,10 +157,12 @@ pm8226_s3: s3 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1350000>; }; + pm8226_s4: s4 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2200000>; }; + pm8226_s5: s5 { regulator-min-microvolt = <1150000>; regulator-max-microvolt = <1150000>;
@@ -170,102 +172,127 @@ pm8226_l1: l1 { regulator-min-microvolt = <1225000>; regulator-max-microvolt = <1225000>; }; + pm8226_l2: l2 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; }; + pm8226_l3: l3 { regulator-min-microvolt = <750000>; regulator-max-microvolt = <1337500>; }; + pm8226_l4: l4 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; }; + pm8226_l5: l5 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; }; + pm8226_l6: l6 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l7: l7 { regulator-min-microvolt = <1850000>; regulator-max-microvolt = <1850000>; }; + pm8226_l8: l8 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l9: l9 { regulator-min-microvolt = <2050000>; regulator-max-microvolt = <2050000>; }; + pm8226_l10: l10 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l12: l12 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l14: l14 { regulator-min-microvolt = <2750000>; regulator-max-microvolt = <2750000>; }; + pm8226_l15: l15 { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; }; + pm8226_l16: l16 { regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3350000>; }; + pm8226_l17: l17 { regulator-min-microvolt = <2950000>; regulator-max-microvolt = <2950000>; }; + pm8226_l18: l18 { regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3300000>; }; + pm8226_l19: l19 { regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; }; + pm8226_l20: l20 { regulator-min-microvolt = <3075000>; regulator-max-microvolt = <3075000>; }; + pm8226_l21: l21 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2950000>; }; + pm8226_l22: l22 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + pm8226_l23: l23 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2950000>; }; + pm8226_l24: l24 { regulator-min-microvolt = <1300000>; regulator-max-microvolt = <1350000>; }; + pm8226_l25: l25 { regulator-min-microvolt = <1775000>; regulator-max-microvolt = <2125000>; }; + pm8226_l26: l26 { regulator-min-microvolt = <1225000>; regulator-max-microvolt = <1225000>; }; + pm8226_l27: l27 { regulator-min-microvolt = <2050000>; regulator-max-microvolt = <2050000>; }; + pm8226_l28: l28 { regulator-min-microvolt = <2700000>; regulator-max-microvolt = <3000000>;
Signature · 1 line
2.43.0
Re: [PATCH 06/38] arm: dts: qcom: apq8026: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 7/38 arm: dts: qcom: apq8026: Add space between OR-operator
In reply to Waqar HameedThere should be a space between binary operators. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-apq8026-samsung-milletwifi.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-apq8026-samsung-milletwifi.dts +2 -2
@@ -86,8 +86,8 @@ key-volume-up { i2c-backlight { compatible = "i2c-gpio"; - sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; - scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; + sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; + scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; pinctrl-0 = <&backlight_i2c_default_state>; pinctrl-names = "default";
Signature · 1 line
2.43.0
Re: [PATCH 07/38] arm: dts: qcom: apq8026: Add space between OR-operator
Quoted 5 lines · Waqar Hameed
There should be a space between binary operators. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 8/38 arm: dts: qcom: apq8060: Add newline between subnodes
In reply to Waqar HameedThere should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- .../dts/qcom/qcom-apq8060-dragonboard.dts | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts +22 -0
@@ -181,6 +181,7 @@ eeprom@52 { vcc-supply = <&pm8058_s3>; pagesize = <64>; }; + wm8903: wm8903@1a { /* This Woolfson Micro device has an unrouted interrupt line */ compatible = "wlf,wm8903";
@@ -226,6 +227,7 @@ ak8975@c { vid-supply = <&pm8058_lvs0>; // 1.8V vdd-supply = <&pm8058_l14>; // 2.85V }; + bmp085@77 { compatible = "bosch,bmp085"; reg = <0x77>;
@@ -237,6 +239,7 @@ bmp085@77 { vddd-supply = <&pm8058_lvs0>; // 1.8V vdda-supply = <&pm8058_l14>; // 2.85V }; + mpu3050@68 { compatible = "invensense,mpu3050"; reg = <0x68>;
@@ -287,6 +290,7 @@ pinconf { power-source = <PM8058_GPIO_S3>; }; }; + dragon_bmp085_gpios: bmp085-state { pinconf { pins = "gpio16";
@@ -296,6 +300,7 @@ pinconf { power-source = <PM8058_GPIO_S3>; }; }; + dragon_mpu3050_gpios: mpu3050-state { pinconf { pins = "gpio17";
@@ -305,6 +310,7 @@ pinconf { power-source = <PM8058_GPIO_S3>; }; }; + dragon_sdcc3_gpios: sdcc3-state { pinconf { pins = "gpio22";
@@ -314,6 +320,7 @@ pinconf { power-source = <PM8058_GPIO_S3>; }; }; + dragon_sdcc5_gpios: sdcc5-state { pinconf { pins = "gpio26";
@@ -324,6 +331,7 @@ pinconf { power-source = <PM8058_GPIO_S3>; }; }; + dragon_ak8975_gpios: ak8975-state { pinconf { pins = "gpio33";
@@ -333,6 +341,7 @@ pinconf { power-source = <PM8058_GPIO_S3>; }; }; + dragon_cm3605_gpios: cm3605-state { /* Pin 34 connected to the proxy IRQ */ gpio34-pins {
@@ -342,6 +351,7 @@ gpio34-pins { bias-disable; power-source = <PM8058_GPIO_S3>; }; + /* Pin 35 connected to ASET */ gpio35-pins { pins = "gpio35";
@@ -351,6 +361,7 @@ gpio35-pins { power-source = <PM8058_GPIO_S3>; }; }; + dragon_veth_gpios: veth-state { pinconf { pins = "gpio40";
@@ -521,12 +532,14 @@ pm8901_s2: s2 { qcom,switch-mode-frequency = <1600000>; bias-pull-down; }; + pm8901_s3: s3 { regulator-min-microvolt = <1100000>; regulator-max-microvolt = <1100000>; qcom,switch-mode-frequency = <1600000>; bias-pull-down; }; + pm8901_s4: s4 { regulator-min-microvolt = <1225000>; regulator-max-microvolt = <1225000>;
@@ -837,12 +850,14 @@ clk-pins { drive-strength = <16>; bias-disable; }; + cmd-pins { pins = "gpio168"; /* SDC1 CMD */ function = "sdc1"; drive-strength = <10>; bias-pull-up; }; + data-pins { /* SDC1 D0 to D7 */ pins = "gpio159", "gpio160", "gpio161", "gpio162",
@@ -863,11 +878,13 @@ clk-pins { drive-strength = <8>; bias-disable; }; + cmd-pins { pins = "sdc3_cmd"; drive-strength = <8>; bias-pull-up; }; + data-pins { pins = "sdc3_data"; drive-strength = <8>;
@@ -883,12 +900,14 @@ clk-pins { drive-strength = <16>; bias-disable; }; + cmd-pins { pins = "gpio95"; /* SDC5 CMD */ function = "sdc5"; drive-strength = <10>; bias-pull-up; }; + data-pins { /* SDC5 D0 to D3 */ pins = "gpio96", "gpio98", "gpio99", "gpio100";
@@ -930,6 +949,7 @@ tx-pins { drive-strength = <8>; bias-disable; }; + rx-pins { pins = "gpio118"; function = "gsbi12";
@@ -951,6 +971,7 @@ mux0-pins { "gpio134"; /* CS0_N testpoint TP29 */ function = "ebi2cs"; }; + mux1-pins { pins = /* EBI2_ADDR_7 downto EBI2_ADDR_0 address bus */
@@ -983,6 +1004,7 @@ reset-pins { drive-strength = <6>; bias-disable; }; + irq-pins { pins = "gpio61"; /* IRQ line */ function = "gpio";
Signature · 1 line
2.43.0
Re: [PATCH 08/38] arm: dts: qcom: apq8060: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 9/38 arm: dts: qcom: apq8060: Align multiple property data
In reply to Waqar HameedMultiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts +2 -2
@@ -99,7 +99,7 @@ ethernet@2,0 { * for network wakeup, connected to the TLMM. */ interrupts-extended = <&pm8058_gpio 7 IRQ_TYPE_EDGE_FALLING>, - <&tlmm 29 IRQ_TYPE_EDGE_RISING>; + <&tlmm 29 IRQ_TYPE_EDGE_RISING>; reset-gpios = <&tlmm 30 GPIO_ACTIVE_LOW>; vdd33a-supply = <&dragon_veth>; vddvario-supply = <&dragon_vario>;
@@ -861,7 +861,7 @@ cmd-pins { data-pins { /* SDC1 D0 to D7 */ pins = "gpio159", "gpio160", "gpio161", "gpio162", - "gpio163", "gpio164", "gpio165", "gpio166"; + "gpio163", "gpio164", "gpio165", "gpio166"; function = "sdc1"; drive-strength = <10>; bias-pull-up;
Signature · 1 line
2.43.0
Re: [PATCH 09/38] arm: dts: qcom: apq8060: Align multiple property data
Quoted 5 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 10/38 arm: dts: qcom: apq8060: Indent property data with tab
In reply to Waqar HameedMultiple property data on a newline should be indented with tabs. Found/fixed with dtfmt (Devicetree Source formatter).
--- .../dts/qcom/qcom-apq8060-dragonboard.dts | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-)
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts +14 -14
@@ -966,25 +966,25 @@ dragon_ebi2_pins: ebi2-state { */ mux0-pins { pins = - /* "gpio39", CS1A_N this is not good to mux */ - "gpio40", /* CS2A_N */ - "gpio134"; /* CS0_N testpoint TP29 */ + /* "gpio39", CS1A_N this is not good to mux */ + "gpio40", /* CS2A_N */ + "gpio134"; /* CS0_N testpoint TP29 */ function = "ebi2cs"; }; mux1-pins { pins = - /* EBI2_ADDR_7 downto EBI2_ADDR_0 address bus */ - "gpio123", "gpio124", "gpio125", "gpio126", - "gpio127", "gpio128", "gpio129", "gpio130", - /* EBI2_DATA_15 downto EBI2_DATA_0 data bus */ - "gpio135", "gpio136", "gpio137", "gpio138", - "gpio139", "gpio140", "gpio141", "gpio142", - "gpio143", "gpio144", "gpio145", "gpio146", - "gpio147", "gpio148", "gpio149", "gpio150", - "gpio151", /* EBI2_OE_N */ - "gpio153", /* EBI2_ADV */ - "gpio157"; /* EBI2_WE_N */ + /* EBI2_ADDR_7 downto EBI2_ADDR_0 address bus */ + "gpio123", "gpio124", "gpio125", "gpio126", + "gpio127", "gpio128", "gpio129", "gpio130", + /* EBI2_DATA_15 downto EBI2_DATA_0 data bus */ + "gpio135", "gpio136", "gpio137", "gpio138", + "gpio139", "gpio140", "gpio141", "gpio142", + "gpio143", "gpio144", "gpio145", "gpio146", + "gpio147", "gpio148", "gpio149", "gpio150", + "gpio151", /* EBI2_OE_N */ + "gpio153", /* EBI2_ADV */ + "gpio157"; /* EBI2_WE_N */ function = "ebi2"; }; };
Signature · 1 line
2.43.0
Re: [PATCH 10/38] arm: dts: qcom: apq8060: Indent property data with tab
Quoted 13 lines · Waqar Hameed
Multiple property data on a newline should be indented with tabs. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- .../dts/qcom/qcom-apq8060-dragonboard.dts | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-)arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts +0
-0
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts dragon_ebi2_pins: ebi2-state { · line 969
Quoted 4 lines
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts +0
-1@@ -966,25 +966,25 @@ dragon_ebi2_pins: ebi2-state { */ mux0-pins { pins = - /* "gpio39", CS1A_N this is not good to mux */
Here I see a possibility for improvement - we shouldn't really be breaking lines at the assignment operator
Konrad
Quoted 35 lines
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts +14
-13- "gpio40", /* CS2A_N */ - "gpio134"; /* CS0_N testpoint TP29 */ + /* "gpio39", CS1A_N this is not good to mux */ + "gpio40", /* CS2A_N */ + "gpio134"; /* CS0_N testpoint TP29 */ function = "ebi2cs"; }; mux1-pins { pins = - /* EBI2_ADDR_7 downto EBI2_ADDR_0 address bus */ - "gpio123", "gpio124", "gpio125", "gpio126", - "gpio127", "gpio128", "gpio129", "gpio130", - /* EBI2_DATA_15 downto EBI2_DATA_0 data bus */ - "gpio135", "gpio136", "gpio137", "gpio138", - "gpio139", "gpio140", "gpio141", "gpio142", - "gpio143", "gpio144", "gpio145", "gpio146", - "gpio147", "gpio148", "gpio149", "gpio150", - "gpio151", /* EBI2_OE_N */ - "gpio153", /* EBI2_ADV */ - "gpio157"; /* EBI2_WE_N */ + /* EBI2_ADDR_7 downto EBI2_ADDR_0 address bus */ + "gpio123", "gpio124", "gpio125", "gpio126", + "gpio127", "gpio128", "gpio129", "gpio130", + /* EBI2_DATA_15 downto EBI2_DATA_0 data bus */ + "gpio135", "gpio136", "gpio137", "gpio138", + "gpio139", "gpio140", "gpio141", "gpio142", + "gpio143", "gpio144", "gpio145", "gpio146", + "gpio147", "gpio148", "gpio149", "gpio150", + "gpio151", /* EBI2_OE_N */ + "gpio153", /* EBI2_ADV */ + "gpio157"; /* EBI2_WE_N */ function = "ebi2"; }; };
Re: [PATCH 10/38] arm: dts: qcom: apq8060: Indent property data with tab
Quoted 9 lines · On Mon, Oct 12, 2026 at 17:24 +0200 Konrad Dybcio…
Quoted 8 lines · Waqar Hameed
Multiple property data on a newline should be indented with tabs. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- .../dts/qcom/qcom-apq8060-dragonboard.dts | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-)
Quoted 12 lines
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts dragon_ebi2_pins: ebi2-state { · line 969
Quoted 9 lines
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts +0
-1@@ -966,25 +966,25 @@ dragon_ebi2_pins: ebi2-state { */ mux0-pins { pins = - /* "gpio39", CS1A_N this is not good to mux */Here I see a possibility for improvement - we shouldn't really be breaking lines at the assignment operator
Yeah, this should be discussed and decided. dtfmt is pragmatic right now and follows the existing style it encounters. That is, if there is a newline after the assignment (like here), it respects it and follows that. Try removing the newline after = here and run dtfmt again. It will then align ...
Quoted 7 lines
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts dragon_ebi2_pins: ebi2-state { · line 973
Quoted 7 lines
arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts +3
-2- "gpio40", /* CS2A_N */ - "gpio134"; /* CS0_N testpoint TP29 */ + /* "gpio39", CS1A_N this is not good to mux */ + "gpio40", /* CS2A_N */ + "gpio134"; /* CS0_N testpoint TP29 */ function = "ebi2cs"; };
... these lines accordingly.
[...]
PATCH 11/38 arm: dts: qcom: apq8064: Add newline between subnodes
In reply to Waqar HameedThere should be a newline (and only one) between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- .../boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts | 2 ++ arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 11 +++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts +2 -0
@@ -53,6 +53,7 @@ key-volume-up { gpios = <&pm8921_gpio 4 GPIO_ACTIVE_HIGH>; linux,code = <KEY_VOLUMEUP>; }; + key-volume-down { label = "Volume Down"; gpios = <&pm8921_gpio 38 GPIO_ACTIVE_HIGH>;
@@ -330,6 +331,7 @@ pm8921_lvs5: lvs5 { pm8921_lvs6: lvs6 { bias-pull-down; }; + /* * mipi_dsi.1-dsi1_vddio * pil_riva-pll_vdd
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +9 -2
@@ -116,6 +116,7 @@ cpu_alert0: trip0 { hysteresis = <2000>; type = "passive"; }; + cpu_crit0: trip1 { temperature = <110000>; hysteresis = <2000>;
@@ -137,6 +138,7 @@ cpu_alert1: trip0 { hysteresis = <2000>; type = "passive"; }; + cpu_crit1: trip1 { temperature = <110000>; hysteresis = <2000>;
@@ -158,6 +160,7 @@ cpu_alert2: trip0 { hysteresis = <2000>; type = "passive"; }; + cpu_crit2: trip1 { temperature = <110000>; hysteresis = <2000>;
@@ -179,6 +182,7 @@ cpu_alert3: trip0 { hysteresis = <2000>; type = "passive"; }; + cpu_crit3: trip1 { temperature = <110000>; hysteresis = <2000>;
@@ -707,6 +711,7 @@ qfprom: efuse@700000 { tsens_calib: calib@404 { reg = <0x404 0x10>; }; + tsens_backup: backup-calib@414 { reg = <0x414 0x10>; };
@@ -1177,7 +1182,6 @@ dsi0_out: endpoint { }; }; - dsi0_phy: phy@4700200 { compatible = "qcom,dsi-phy-28nm-8960"; #clock-cells = <1>;
@@ -1249,7 +1253,6 @@ dsi1_out: endpoint { }; }; - dsi1_phy: dsi-phy@5800200 { compatible = "qcom,dsi-phy-28nm-8960"; reg = <0x05800200 0x100>,
@@ -1596,18 +1599,21 @@ funnel_in0: endpoint { remote-endpoint = <&etm0_out>; }; }; + port@1 { reg = <1>; funnel_in1: endpoint { remote-endpoint = <&etm1_out>; }; }; + port@4 { reg = <4>; funnel_in4: endpoint { remote-endpoint = <&etm2_out>; }; }; + port@5 { reg = <5>; funnel_in5: endpoint {
@@ -1698,4 +1704,5 @@ etm3_out: endpoint { }; }; }; + #include "qcom-apq8064-pins.dtsi"
Signature · 1 line
2.43.0
Re: [PATCH 11/38] arm: dts: qcom: apq8064: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline (and only one) between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
There's some 'remove newlines' in there but the granularity on these patches is already more than enough, so I don't mind!
Konrad
Re: [PATCH 11/38] arm: dts: qcom: apq8064: Add newline between subnodes
Quoted 9 lines · On Mon, Oct 12, 2026 at 17:23 +0200 Konrad Dybcio…
Quoted 5 lines · Waqar Hameed
There should be a newline (and only one) between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
There's some 'remove newlines' in there but the granularity on these patches is already more than enough, so I don't mind!
I tried to cover both "adding" and "removing" by saying "should be a newline (*and only one*)". I guess the subject "add newline between subnodes" could be rephrased though :)
Quoted 2 lines
Reviewed-by Konrad Dybcio <[email protected]>
Thanks!
PATCH 12/38 arm: dts: qcom: apq8064: Remove empty line at end of node
In reply to Waqar HameedThere shouldn't be an empty line at end of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts | 1 - arch/arm/boot/dts/qcom/qcom-apq8064-sony-xperia-lagan-yuga.dts | 1 - arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 1 - 3 files changed, 3 deletions(-)
arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts +0 -1
@@ -137,7 +137,6 @@ bq27541@55 { compatible = "ti,bq27541"; reg = <0x55>; }; - }; &gsbi3 {
arch/arm/boot/dts/qcom/qcom-apq8064-sony-xperia-lagan-yuga.dts +0 -1
@@ -395,7 +395,6 @@ tx-pins { }; }; - sdcc3_cd_pin_a: sdcc3-cd-pin-active-state { pins = "gpio26"; function = "gpio";
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +0 -1
@@ -482,7 +482,6 @@ gsbi1_i2c: i2c@12460000 { #size-cells = <0>; status = "disabled"; }; - }; gsbi2: gsbi@12480000 {
Signature · 1 line
2.43.0
Re: [PATCH 12/38] arm: dts: qcom: apq8064: Remove empty line at end of node
Quoted 5 lines · Waqar Hameed
There shouldn't be an empty line at end of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 13/38 arm: dts: qcom: apq8064: Add space before line comments
In reply to Waqar HameedThere should be a space before start of comment delimiter. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-apq8064-asus-nexus7-flo.dts +2 -2
@@ -79,7 +79,7 @@ reboot-mode { }; &dsi0 { - vdda-supply = <&pm8921_l2>;/*VDD_MIPI1 to 4*/ + vdda-supply = <&pm8921_l2>; /* VDD_MIPI1 to 4 */ vdd-supply = <&pm8921_l8>; vddio-supply = <&pm8921_lvs7>; avdd-supply = <&pm8921_l11>;
@@ -114,7 +114,7 @@ &dsi0_out { }; &dsi0_phy { - vddio-supply = <&pm8921_lvs7>;/*VDD_PLL2_1 to 7*/ + vddio-supply = <&pm8921_lvs7>; /* VDD_PLL2_1 to 7 */ status = "okay"; };
Signature · 1 line
2.43.0
Re: [PATCH 13/38] arm: dts: qcom: apq8064: Add space before line comments
Quoted 5 lines · Waqar Hameed
There should be a space before start of comment delimiter. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 14/38 arm: dts: qcom: apq8064: Align multiple property data
In reply to Waqar HameedMultiple property data on a newline should be aligned with the first one or properly indented with tabs. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 98 ++++++++++++------------ 1 file changed, 49 insertions(+), 49 deletions(-)
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +49 -49
@@ -89,7 +89,7 @@ l2: l2-cache { idle-states { cpu_spc: cpu-spc { compatible = "qcom,idle-state-spc", - "arm,idle-state"; + "arm,idle-state"; entry-latency-us = <400>; exit-latency-us = <900>; min-residency-us = <3000>;
@@ -1036,15 +1036,15 @@ gpu: gpu@4300000 { interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "kgsl_3d0_irq"; clock-names = - "core", - "iface", - "mem", - "mem_iface"; + "core", + "iface", + "mem", + "mem_iface"; clocks = - <&mmcc GFX3D_CLK>, - <&mmcc GFX3D_AHB_CLK>, - <&mmcc GFX3D_AXI_CLK>, - <&mmcc MMSS_IMEM_AHB_CLK>; + <&mmcc GFX3D_CLK>, + <&mmcc GFX3D_AHB_CLK>, + <&mmcc GFX3D_AXI_CLK>, + <&mmcc MMSS_IMEM_AHB_CLK>; iommus = <&gfx3d 0 &gfx3d 1
@@ -1141,24 +1141,24 @@ dsi0: dsi@4700000 { reg-names = "dsi_ctrl"; clocks = <&mmcc DSI_M_AHB_CLK>, - <&mmcc DSI_S_AHB_CLK>, - <&mmcc AMP_AHB_CLK>, - <&mmcc DSI_CLK>, - <&mmcc DSI1_BYTE_CLK>, - <&mmcc DSI_PIXEL_CLK>, - <&mmcc DSI1_ESC_CLK>; + <&mmcc DSI_S_AHB_CLK>, + <&mmcc AMP_AHB_CLK>, + <&mmcc DSI_CLK>, + <&mmcc DSI1_BYTE_CLK>, + <&mmcc DSI_PIXEL_CLK>, + <&mmcc DSI1_ESC_CLK>; clock-names = "iface", "bus", "core_mmss", - "src", "byte", "pixel", - "core"; + "src", "byte", "pixel", + "core"; assigned-clocks = <&mmcc DSI1_BYTE_SRC>, - <&mmcc DSI1_ESC_SRC>, - <&mmcc DSI_SRC>, - <&mmcc DSI_PIXEL_SRC>; + <&mmcc DSI1_ESC_SRC>, + <&mmcc DSI_SRC>, + <&mmcc DSI_PIXEL_SRC>; assigned-clock-parents = <&dsi0_phy 0>, - <&dsi0_phy 0>, - <&dsi0_phy 1>, - <&dsi0_phy 1>; + <&dsi0_phy 0>, + <&dsi0_phy 1>, + <&dsi0_phy 1>; syscon-sfpb = <&mmss_sfpb>; phys = <&dsi0_phy>; status = "disabled";
@@ -1187,8 +1187,8 @@ dsi0_phy: phy@4700200 { #phy-cells = <0>; reg = <0x04700200 0x100>, - <0x04700300 0x200>, - <0x04700500 0x5c>; + <0x04700300 0x200>, + <0x04700500 0x5c>; reg-names = "dsi_pll", "dsi_phy", "dsi_phy_regulator"; clock-names = "iface", "ref"; clocks = <&mmcc DSI_M_AHB_CLK>,
@@ -1274,15 +1274,15 @@ mdp_port0: iommu@7500000 { compatible = "qcom,apq8064-iommu"; #iommu-cells = <1>; clock-names = - "smmu_pclk", - "iommu_clk"; + "smmu_pclk", + "iommu_clk"; clocks = - <&mmcc SMMU_AHB_CLK>, - <&mmcc MDP_AXI_CLK>; + <&mmcc SMMU_AHB_CLK>, + <&mmcc MDP_AXI_CLK>; reg = <0x07500000 0x100000>; interrupts = - <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; qcom,ncb = <2>; };
@@ -1290,15 +1290,15 @@ mdp_port1: iommu@7600000 { compatible = "qcom,apq8064-iommu"; #iommu-cells = <1>; clock-names = - "smmu_pclk", - "iommu_clk"; + "smmu_pclk", + "iommu_clk"; clocks = - <&mmcc SMMU_AHB_CLK>, - <&mmcc MDP_AXI_CLK>; + <&mmcc SMMU_AHB_CLK>, + <&mmcc MDP_AXI_CLK>; reg = <0x07600000 0x100000>; interrupts = - <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>; qcom,ncb = <2>; };
@@ -1306,15 +1306,15 @@ gfx3d: iommu@7c00000 { compatible = "qcom,apq8064-iommu"; #iommu-cells = <1>; clock-names = - "smmu_pclk", - "iommu_clk"; + "smmu_pclk", + "iommu_clk"; clocks = - <&mmcc SMMU_AHB_CLK>, - <&mmcc GFX3D_AXI_CLK>; + <&mmcc SMMU_AHB_CLK>, + <&mmcc GFX3D_AXI_CLK>; reg = <0x07c00000 0x100000>; interrupts = - <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>; qcom,ncb = <3>; };
@@ -1322,15 +1322,15 @@ gfx3d1: iommu@7d00000 { compatible = "qcom,apq8064-iommu"; #iommu-cells = <1>; clock-names = - "smmu_pclk", - "iommu_clk"; + "smmu_pclk", + "iommu_clk"; clocks = - <&mmcc SMMU_AHB_CLK>, - <&mmcc GFX3D_AXI_CLK>; + <&mmcc SMMU_AHB_CLK>, + <&mmcc GFX3D_AXI_CLK>; reg = <0x07d00000 0x100000>; interrupts = - <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>; qcom,ncb = <3>; };
Signature · 1 line
2.43.0
Re: [PATCH 14/38] arm: dts: qcom: apq8064: Align multiple property data
Quoted 23 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one or properly indented with tabs. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 98 ++++++++++++------------ 1 file changed, 49 insertions(+), 49 deletions(-)arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +1
-1@@ -89,7 +89,7 @@ l2: l2-cache { idle-states { cpu_spc: cpu-spc { compatible = "qcom,idle-state-spc", - "arm,idle-state"; + "arm,idle-state"; entry-latency-us = <400>; exit-latency-us = <900>; min-residency-us = <3000>;
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi gpu: gpu@4300000 { · line 1039
Quoted 8 lines
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +1
-4@@ -1036,15 +1036,15 @@ gpu: gpu@4300000 { interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "kgsl_3d0_irq"; clock-names = - "core", - "iface", - "mem", - "mem_iface"; + "core",
As before, let's add a rule to prohibit property =\n
Konrad
Re: [PATCH 14/38] arm: dts: qcom: apq8064: Align multiple property data
Quoted 26 lines · On Mon, Oct 12, 2026 at 17:52 +0200 Konrad Dybcio…
Quoted 25 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one or properly indented with tabs. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 98 ++++++++++++------------ 1 file changed, 49 insertions(+), 49 deletions(-)arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +1
-1@@ -89,7 +89,7 @@ l2: l2-cache { idle-states { cpu_spc: cpu-spc { compatible = "qcom,idle-state-spc", - "arm,idle-state"; + "arm,idle-state"; entry-latency-us = <400>; exit-latency-us = <900>; min-residency-us = <3000>;@@ -1036,15 +1036,15 @@ gpu: gpu@4300000 { interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "kgsl_3d0_irq";
Quoted 8 lines
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi gpu: gpu@4300000 { · line 1039
Quoted 6 lines
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +1
-4clock-names = - "core", - "iface", - "mem", - "mem_iface"; + "core",As before, let's add a rule to prohibit
property =\n
Let's see what the discussions on patch 22 result in. It could maybe be applied here as well, e.g.
clock-names = "corecorecorecorecorecorecorecorecorecorecorecorecorecorecore";
would be wrapped to
clock-names =
"corecorecorecorecorecorecorecorecorecorecorecorecorecorecore";To fit 100 chars. Then multiple property string data would follow the same logic:
clock-names = "corecorecorecorecorecorecorecorecorecorecorecorecorecorecore", "iface", "mem", "mem_iface";
Which maybe is more clean than allowing the first string to overflow 100 chars and aligning others to that one:
clock-names = "corecorecorecorecorecorecorecorecorecorecorecorecorecorecore", "iface", "mem", "mem_iface";
So the question is if we should either "try to fit within 100 chars, by adding newline after =" or "don't care about property data longer that 100 chars, always start first one after = on the same line". The latter one is of course much easier to implement :)
Re: [PATCH 14/38] arm: dts: qcom: apq8064: Align multiple property data
Quoted 9 lines · Waqar Hameed
Quoted 7 lines · On Mon, Oct 12, 2026 at 17:52 +0200 Konrad Dybcio…
Quoted 6 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one or properly indented with tabs. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
[...]
Quoted 8 lines
Which maybe is more clean than allowing the first string to overflow 100 chars and aligning others to that one:
clock-names = "corecorecorecorecorecorecorecorecorecorecorecorecorecorecore", "iface", "mem", "mem_iface";
Quoted 4 lines
So the question is if we should either "try to fit within 100 chars, by adding newline after
=" or "don't care about property data longer that 100 chars, always start first one after=on the same line". The latter one is of course much easier to implement :)
I have an ultrawide monitor so we can overflow waaay above 100 :D
But more seriously, between the low likelihood of this happening and the presumed disadvantage of having to scroll sideways but still being able to read without jumping to a different (line, col) with your eyesight, letting super long properties overflow seems OK to me.
Let's see if others agree
Konrad
PATCH 15/38 arm: dts: qcom: apq8064: Remove tab after property name
In reply to Waqar HameedThese shouldn't have these to be consistent with rest of the style. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi +2 -2
@@ -916,8 +916,8 @@ sata_phy0: phy@1b400000 { sata0: sata@29000000 { compatible = "qcom,apq8064-ahci", "generic-ahci"; - status = "disabled"; - reg = <0x29000000 0x180>; + status = "disabled"; + reg = <0x29000000 0x180>; interrupts = <GIC_SPI 209 IRQ_TYPE_LEVEL_HIGH>; clocks = <&gcc SFAB_SATA_S_H_CLK>,
Signature · 1 line
2.43.0
Re: [PATCH 15/38] arm: dts: qcom: apq8064: Remove tab after property name
Quoted 5 lines · Waqar Hameed
These shouldn't have these to be consistent with rest of the style. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 16/38 arm: dts: qcom: ipq4018: Indent closing brace properly
In reply to Waqar HameedClosing brace of a node definition should be indented like subnode name/reference. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-ipq4018-ap120c-ac.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-ipq4018-ap120c-ac.dtsi +1 -2
@@ -260,8 +260,7 @@ &usb3_hs_phy { &usb3 { status = "okay"; - - }; +}; &usb3_dwc { phys = <&usb3_hs_phy>;
Signature · 1 line
2.43.0
Re: [PATCH 16/38] arm: dts: qcom: ipq4018: Indent closing brace properly
Quoted 5 lines · Waqar Hameed
Closing brace of a node definition should be indented like subnode name/reference. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 17/38 arm: dts: qcom: ipq4019: Add newline between subnodes
In reply to Waqar HameedThere should be a newline (and only one) between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi | 1 + arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk04.1.dtsi | 1 + arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk07.1-c1.dts | 1 + arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 3 +++ 4 files changed, 6 insertions(+)
arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi +1 -0
@@ -47,6 +47,7 @@ spi0-pins { drive-strength = <12>; bias-disable; }; + spi0-cs-pins { pins = "gpio54"; function = "gpio";
arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk04.1.dtsi +1 -0
@@ -43,6 +43,7 @@ spi0-pins { pins = "gpio13", "gpio14", "gpio15"; bias-disable; }; + spi0-cs-pins { function = "gpio"; pins = "gpio12";
arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk07.1-c1.dts +1 -0
@@ -32,6 +32,7 @@ spi0-pins { pins = "gpio13", "gpio14", "gpio15"; bias-disable; }; + spio-cs-pins { function = "gpio"; pins = "gpio12";
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi +3 -0
@@ -111,14 +111,17 @@ opp-48000000 { opp-hz = /bits/ 64 <48000000>; clock-latency-ns = <256000>; }; + opp-200000000 { opp-hz = /bits/ 64 <200000000>; clock-latency-ns = <256000>; }; + opp-500000000 { opp-hz = /bits/ 64 <500000000>; clock-latency-ns = <256000>; }; + opp-716000000 { opp-hz = /bits/ 64 <716000000>; clock-latency-ns = <256000>;
Signature · 1 line
2.43.0
Re: [PATCH 17/38] arm: dts: qcom: ipq4019: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline (and only one) between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 18/38 arm: dts: qcom: ipq4019: Align multiple property data
In reply to Waqar HameedMultiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk04.1.dtsi | 10 +++++----- arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk07.1-c1.dts | 2 +- arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-)
arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk04.1.dtsi +5 -5
@@ -32,7 +32,7 @@ serial_0_pins: serial0-state { serial_1_pins: serial1-state { pins = "gpio8", "gpio9", - "gpio10", "gpio11"; + "gpio10", "gpio11"; function = "blsp_uart1"; bias-disable; };
@@ -60,10 +60,10 @@ i2c_0_pins: i2c-0-state { nand_pins: nand-state { pins = "gpio53", "gpio55", "gpio56", - "gpio57", "gpio58", "gpio59", - "gpio60", "gpio62", "gpio63", - "gpio64", "gpio65", "gpio66", - "gpio67", "gpio68", "gpio69"; + "gpio57", "gpio58", "gpio59", + "gpio60", "gpio62", "gpio63", + "gpio64", "gpio65", "gpio66", + "gpio67", "gpio68", "gpio69"; function = "qpic"; }; };
arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk07.1-c1.dts +1 -1
@@ -21,7 +21,7 @@ spi@78b6000 { pinctrl@1000000 { serial_1_pins: serial1-state { pins = "gpio8", "gpio9", - "gpio10", "gpio11"; + "gpio10", "gpio11"; function = "blsp_uart1"; bias-disable; };
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi +4 -4
@@ -181,7 +181,7 @@ intc: interrupt-controller@b000000 { #address-cells = <0>; #interrupt-cells = <3>; reg = <0x0b000000 0x1000>, - <0x0b002000 0x1000>; + <0x0b002000 0x1000>; }; gcc: clock-controller@1800000 {
@@ -268,7 +268,7 @@ blsp1_spi2: spi@78b6000 { /* BLSP1 QUP2 */ reg = <0x78b6000 0x600>; interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; clocks = <&gcc GCC_BLSP1_QUP2_SPI_APPS_CLK>, - <&gcc GCC_BLSP1_AHB_CLK>; + <&gcc GCC_BLSP1_AHB_CLK>; clock-names = "core", "iface"; #address-cells = <1>; #size-cells = <0>;
@@ -380,7 +380,7 @@ blsp1_uart1: serial@78af000 { interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; clocks = <&gcc GCC_BLSP1_UART1_APPS_CLK>, - <&gcc GCC_BLSP1_AHB_CLK>; + <&gcc GCC_BLSP1_AHB_CLK>; clock-names = "core", "iface"; dmas = <&blsp_dma 0>, <&blsp_dma 1>; dma-names = "tx", "rx";
@@ -392,7 +392,7 @@ blsp1_uart2: serial@78b0000 { interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; clocks = <&gcc GCC_BLSP1_UART2_APPS_CLK>, - <&gcc GCC_BLSP1_AHB_CLK>; + <&gcc GCC_BLSP1_AHB_CLK>; clock-names = "core", "iface"; dmas = <&blsp_dma 2>, <&blsp_dma 3>; dma-names = "tx", "rx";
Signature · 1 line
2.43.0
Re: [PATCH 18/38] arm: dts: qcom: ipq4019: Align multiple property data
Quoted 5 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 19/38 arm: dts: qcom: ipq4019: Break long property array data
In reply to Waqar HameedThere is an awkward line break at the last elements expression. Put all elements on a newline instead. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi +3 -2
@@ -135,8 +135,9 @@ memory { pmu { compatible = "arm,cortex-a7-pmu"; - interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | - IRQ_TYPE_LEVEL_HIGH)>; + interrupts = < + GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH) + >; }; clocks {
Signature · 1 line
2.43.0
Re: [PATCH 19/38] arm: dts: qcom: ipq4019: Break long property array data
Quoted 14 lines · Waqar Hameed
There is an awkward line break at the last elements expression. Put all elements on a newline instead. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi +0
-0
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi memory { · line 140
Quoted 8 lines
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi +3
-2@@ -135,8 +135,9 @@ memory { pmu { compatible = "arm,cortex-a7-pmu"; - interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | - IRQ_TYPE_LEVEL_HIGH)>; + interrupts = < + GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH) + >;
I find this equally awkward.. especially since this fits below 100 chars
Konrad
Re: [PATCH 19/38] arm: dts: qcom: ipq4019: Break long property array data
Quoted 16 lines · On Mon, Oct 12, 2026 at 17:26 +0200 Konrad Dybcio…
Quoted 15 lines · Waqar Hameed
There is an awkward line break at the last elements expression. Put all elements on a newline instead. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi +0
-0@@ -135,8 +135,9 @@ memory {
Quoted 10 lines
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi memory { · line 140
Quoted 7 lines
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi +3
-2pmu { compatible = "arm,cortex-a7-pmu"; - interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | - IRQ_TYPE_LEVEL_HIGH)>; + interrupts = < + GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH) + >;I find this equally awkward.. especially since this fits below 100 chars
Yeah, I agree. dtfmt tries to be pragmatic and guess the intended style of where to have the opening < and closing > of the array (since there is no definitive answer in the kernel). That is, if the < and > are different lines, then you probably want to keep that (many examples of this in devictree files in the kernel tree).
I will remove the newline. If you now run dtfmt after that, it properly formats it on one line (since < and > are on the same line now).
One of the hardest things left to implement is line wrapping (i.e. lines spanning over 100 chars). Which has been left out due to too many uncertainties. I'll be happy is we could come to some kind of agreement on how to do that (but I'll guess that will take some time indeed...).
PATCH 20/38 arm: dts: qcom: ipq8064: Add newline between subnodes
In reply to Waqar HameedThere should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-ipq8064-v1.0.dtsi | 1 + arch/arm/boot/dts/qcom/qcom-ipq8064-v2.0.dtsi | 1 + arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 2 ++ 3 files changed, 4 insertions(+)
arch/arm/boot/dts/qcom/qcom-ipq8064-v1.0.dtsi +1 -0
@@ -26,6 +26,7 @@ button-1 { linux,input-type = <1>; debounce-interval = <60>; }; + button-2 { label = "wps"; linux,code = <KEY_WPS_BUTTON>;
arch/arm/boot/dts/qcom/qcom-ipq8064-v2.0.dtsi +1 -0
@@ -32,6 +32,7 @@ &gsbi4 { serial@16340000 { status = "okay"; }; + /* * The i2c device on gsbi4 should not be enabled. * On ipq806x designs gsbi4 i2c is meant for exclusive
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi +2 -0
@@ -380,9 +380,11 @@ qfprom: efuse@700000 { speedbin_efuse: speedbin@c0 { reg = <0xc0 0x4>; }; + tsens_calib: calib@400 { reg = <0x400 0xb>; }; + tsens_calib_backup: calib-backup@410 { reg = <0x410 0xb>; };
Signature · 1 line
2.43.0
Re: [PATCH 20/38] arm: dts: qcom: ipq8064: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 21/38 arm: dts: qcom: ipq8064: Align multiple property data
In reply to Waqar HameedMultiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi +11 -11
@@ -353,8 +353,8 @@ rpm: rpm@108000 { qcom,ipc = <&l2cc 0x8 2>; interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "ack", "err", "wakeup"; clocks = <&gcc RPM_MSG_RAM_H_CLK>;
@@ -438,7 +438,7 @@ spi_pins: spi-state { leds_pins: leds-state { pins = "gpio7", "gpio8", "gpio9", - "gpio26", "gpio53"; + "gpio26", "gpio53"; function = "gpio"; drive-strength = <2>; bias-pull-down;
@@ -489,9 +489,9 @@ mdio0_pins: mdio0-state { rgmii2_pins: rgmii2-state { pins = "gpio27", "gpio28", "gpio29", - "gpio30", "gpio31", "gpio32", - "gpio51", "gpio52", "gpio59", - "gpio60", "gpio61", "gpio62"; + "gpio30", "gpio31", "gpio32", + "gpio51", "gpio52", "gpio59", + "gpio60", "gpio61", "gpio62"; function = "rgmii2"; drive-strength = <8>; bias-disable;
@@ -1257,11 +1257,11 @@ lpass@28100000 { compatible = "qcom,lpass-cpu"; status = "disabled"; clocks = <&lcc AHBIX_CLK>, - <&lcc MI2S_OSR_CLK>, - <&lcc MI2S_BIT_CLK>; + <&lcc MI2S_OSR_CLK>, + <&lcc MI2S_BIT_CLK>; clock-names = "ahbix-clk", - "mi2s-osr-clk", - "mi2s-bit-clk"; + "mi2s-osr-clk", + "mi2s-bit-clk"; interrupts = <GIC_SPI 85 IRQ_TYPE_EDGE_RISING>; interrupt-names = "lpass-irq-lpaif"; reg = <0x28100000 0x10000>;
@@ -1280,7 +1280,7 @@ sata: sata@29000000 { <&gcc SATA_RXOOB_CLK>, <&gcc SATA_PMALIVE_CLK>; clock-names = "slave_iface", "iface", "core", - "rxoob", "pmalive"; + "rxoob", "pmalive"; assigned-clocks = <&gcc SATA_RXOOB_CLK>, <&gcc SATA_PMALIVE_CLK>; assigned-clock-rates = <100000000>, <100000000>;
Signature · 1 line
2.43.0
Re: [PATCH 21/38] arm: dts: qcom: ipq8064: Align multiple property data
Quoted 5 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 22/38 arm: dts: qcom: ipq8064: Break long property array data
In reply to Waqar HameedThere is an awkward line break at the last elements expression. Put all elements on a newline instead. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi +3 -2
@@ -278,8 +278,9 @@ memory { cpu-pmu { compatible = "qcom,krait-pmu"; - interrupts = <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | - IRQ_TYPE_LEVEL_HIGH)>; + interrupts = < + GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) + >; }; reserved-memory {
Signature · 1 line
2.43.0
Re: [PATCH 22/38] arm: dts: qcom: ipq8064: Break long property array data
Quoted 14 lines · Waqar Hameed
There is an awkward line break at the last elements expression. Put all elements on a newline instead. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi +0
-0
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi memory { · line 283
Quoted 8 lines
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi +3
-2@@ -278,8 +278,9 @@ memory { cpu-pmu { compatible = "qcom,krait-pmu"; - interrupts = <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | - IRQ_TYPE_LEVEL_HIGH)>; + interrupts = < + GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) + >;
Let's wrap it at 100 chars. For lines that overflow, I think we may need some brainstorming from the wider audience.
For reference, we have a couple of very long lines in the Qualcomm soundwire nodes (qcom,soundwire-vXXX), and we just kinda let them overflow for the time being
Konrad
Re: [PATCH 22/38] arm: dts: qcom: ipq8064: Break long property array data
Quoted 16 lines · On Mon, Oct 12, 2026 at 17:31 +0200 Konrad Dybcio…
Quoted 15 lines · Waqar Hameed
There is an awkward line break at the last elements expression. Put all elements on a newline instead. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi +0
-0@@ -278,8 +278,9 @@ memory {
Quoted 10 lines
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi memory { · line 283
Quoted 7 lines
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi +3
-2cpu-pmu { compatible = "qcom,krait-pmu"; - interrupts = <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | - IRQ_TYPE_LEVEL_HIGH)>; + interrupts = < + GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) + >;Let's wrap it at 100 chars. For lines that overflow, I think we may need some brainstorming from the wider audience.
Yeah, as I responded in patch 19, this is hard and needs some discussions. Having the braces on separate lines like this is one way to do it, and in fact that's how black for Python does it. rustfmt also chooses this but first tries to fit it on one line with a newline after the assignment:
interrupts = <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
If it still doesn't fit 100 chars (like here), it then formats long arrays as
interrupts = < GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) >;
This still doesn't fit 100 chars. Maybe we could then wrap the individual items like:
interrupts = < GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) >;
I think that's a reasonable algorithm to have in dtfmt for wrapping arrays, or?
Quoted 4 lines
For reference, we have a couple of very long lines in the Qualcomm soundwire nodes (qcom,soundwire-vXXX), and we just kinda let them overflow for the time being
I think the above approach would format them quite nicely, for example
swr3: soundwire@6ab0000 {
compatible = "qcom,soundwire-v2.2.0", "qcom,soundwire-v2.0.0";
...
qcom,ports-sinterval = /bits/ 16 <
0x07 0x1f 0x3f 0x07 0x1f 0x3f 0x18f 0xff 0xff 0x0f 0x0f 0xff 0x31f
>;
qcom,ports-offset1 = /bits/ 8 <
0x01 0x03 0x05 0x02 0x04 0x15 0x00 0xff 0xff 0x06 0x0d 0xff 0x00
>;
qcom,ports-offset2 = /bits/ 8 <
0xff 0x07 0x1f 0xff 0x07 0x1f 0xff 0xff 0xff 0xff 0xff 0xff 0xff
>;
...
};in arch/arm64/boot/dts/qcom/kaanapali.dtsi. What do you think?
Re: [PATCH 22/38] arm: dts: qcom: ipq8064: Break long property array data
Quoted 19 lines · Waqar Hameed
Yeah, as I responded in patch 19, this is hard and needs some discussions. Having the braces on separate lines like this is one way to do it, and in fact that's how
blackfor Python does it.rustfmtalso chooses this but first tries to fit it on one line with a newline after the assignment:interrupts = <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;If it still doesn't fit 100 chars (like here), it then formats long arrays as
interrupts = < GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) >;This still doesn't fit 100 chars. Maybe we could then wrap the individual items like:
Quoted 7 lines
interrupts = < GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) >;I think that's a reasonable algorithm to have in dtfmt for wrapping arrays, or?
The code should be:
interrupts = <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) it fits within reasonable limits. Why would you wrap it?
Best regards,
Krzysztof
Re: [PATCH 22/38] arm: dts: qcom: ipq8064: Break long property array data
Quoted 25 lines · On Fri, Oct 16, 2026 at 16:48 +0200 Krzysztof Kozlowski <[email protected]> wrote:
Quoted 24 lines · Waqar Hameed
Yeah, as I responded in patch 19, this is hard and needs some discussions. Having the braces on separate lines like this is one way to do it, and in fact that's how
blackfor Python does it.rustfmtalso chooses this but first tries to fit it on one line with a newline after the assignment:interrupts = <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;If it still doesn't fit 100 chars (like here), it then formats long arrays as
interrupts = < GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) >;This still doesn't fit 100 chars. Maybe we could then wrap the individual items like:
interrupts = < GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH) >;
Quoted 6 lines
Quoted 2 lines
I think that's a reasonable algorithm to have in dtfmt for wrapping arrays, or?
The code should be:
interrupts = <GIC_PPI10 (GIC_CPU_MASK_SIMPLE(2)|IRQ_TYPE_LEVEL_HIGH) it fits within reasonable limits. Why would you wrap it?
Ah sorry, I can see how this is confusing, but this was just a response to Konrad's comment "... For lines that overflow, I think we may need some brainstorming from the wider audience". This was my "brainstorming" about line wrapping in general. What do you think Krzysztof about this approach?
We are all in agreement that the line in _this patch_ should only be on one line, without any wrapping (since it's shorter than 100 chars)!
Re: [PATCH 22/38] arm: dts: qcom: ipq8064: Break long property array data
In reply to Waqar HameedQuoted 9 lines · Waqar Hameed
Quoted 7 lines · On Mon, Oct 12, 2026 at 17:31 +0200 Konrad Dybcio…
Quoted 6 lines · Waqar Hameed
There is an awkward line break at the last elements expression. Put all elements on a newline instead. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
[...]
Quoted 20 lines
I think the above approach would format them quite nicely, for example
swr3: soundwire@6ab0000 { compatible = "qcom,soundwire-v2.2.0", "qcom,soundwire-v2.0.0"; ... qcom,ports-sinterval = /bits/ 16 < 0x07 0x1f 0x3f 0x07 0x1f 0x3f 0x18f 0xff 0xff 0x0f 0x0f 0xff 0x31f >; qcom,ports-offset1 = /bits/ 8 < 0x01 0x03 0x05 0x02 0x04 0x15 0x00 0xff 0xff 0x06 0x0d 0xff 0x00 >; qcom,ports-offset2 = /bits/ 8 < 0xff 0x07 0x1f 0xff 0x07 0x1f 0xff 0xff 0xff 0xff 0xff 0xff 0xff >; ... };
Quoted 1 line
in
arch/arm64/boot/dts/qcom/kaanapali.dtsi. What do you think?
I don't have any better idea so might as well
Konrad
PATCH 23/38 arm: dts: qcom: msm8226: Add space between OR-operator
In reply to Waqar HameedThere should be a space between binary operators. Found/fixed with dtfmt (Devicetree Source formatter).
--- .../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi +2 -2
@@ -82,8 +82,8 @@ key-volume-up { i2c-backlight { compatible = "i2c-gpio"; - sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; - scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; + sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; + scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; pinctrl-0 = <&backlight_i2c_default_state>; pinctrl-names = "default";
Signature · 1 line
2.43.0
Re: [PATCH 23/38] arm: dts: qcom: msm8226: Add space between OR-operator
Quoted 5 lines · Waqar Hameed
There should be a space between binary operators. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 24/38 arm: dts: qcom: msm8226: Add newline between subnodes
In reply to Waqar HameedThere should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi +5 -0
@@ -183,18 +183,23 @@ rpmpd_opp_table: opp-table { rpmpd_opp_ret: opp1 { opp-level = <1>; }; + rpmpd_opp_svs_krait: opp2 { opp-level = <2>; }; + rpmpd_opp_svs_soc: opp3 { opp-level = <3>; }; + rpmpd_opp_nom: opp4 { opp-level = <4>; }; + rpmpd_opp_turbo: opp5 { opp-level = <5>; }; + rpmpd_opp_super_turbo: opp6 { opp-level = <6>; };
Signature · 1 line
2.43.0
Re: [PATCH 24/38] arm: dts: qcom: msm8226: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 25/38 arm: dts: qcom: ipq8064: Break long property array data
In reply to Waqar HameedThere is an awkward line break at the last elements expression. Put all elements on a newline instead. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi +3 -2
@@ -137,8 +137,9 @@ opp-787200000 { pmu { compatible = "arm,cortex-a7-pmu"; - interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | - IRQ_TYPE_LEVEL_HIGH)>; + interrupts = < + GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH) + >; }; rpm: remoteproc {
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH 25/38] arm: dts: qcom: ipq8064: Break long property array data
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] arm/dts: commit message mismatch for msm8226 --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm/dts: commit message mismatch for msm8226
--
commit 48c3f8677b03cbab24e050029b004bb3e0cca06a
Author: Waqar Hameed <[email protected]>
arm: dts: qcom: ipq8064: Break long property array data
This commit resolves an awkward line break in a devicetree property array by placing all elements on a new line.
Quoted 1 line
arm: dts: qcom: ipq8064: Break long property array data
[Severity: Medium]
Does this commit message prefix accurately reflect the changes?
The prefix explicitly states 'ipq8064' (and shares the identical subject with an earlier patch in the series, commit 0462db0355be), while the only modified file is arch/arm/boot/dts/qcom/qcom-msm8226.dtsi which corresponds to the MSM8226 SoC.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=25
Re: [PATCH 25/38] arm: dts: qcom: ipq8064: Break long property array data
Quoted 14 lines · On Fri, Oct 02, 2026 at 09:13 +0000 [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm/dts: commit message mismatch for msm8226
--commit
48c3f8677b03cbab24e050029b004bb3e0cca06a
Author: Waqar Hameed <[email protected]>arm: dts: qcom: ipq8064: Break long property array data
This commit resolves an awkward line break in a devicetree property array by placing all elements on a new line.
Quoted 1 line
arm: dts: qcom: ipq8064: Break long property array data
Quoted 7 lines
[Severity: Medium]
Does this commit message prefix accurately reflect the changes?The prefix explicitly states 'ipq8064' (and shares the identical subject with an earlier patch in the series, commit
0462db0355be), while the only modified file isarch/arm/boot/dts/qcom/qcom-msm8226.dtsiwhich corresponds to the MSM8226 SoC.
Good bot! Will fix!
PATCH 26/38 arm: dts: qcom: msm8226: Align multiple property data
In reply to Waqar HameedMultiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi +4 -4
@@ -1483,12 +1483,12 @@ cpu_crit1: trip1 { timer { compatible = "arm,armv7-timer"; interrupts = <GIC_PPI 2 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 3 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 4 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 1 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>; + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>; }; };
Signature · 1 line
2.43.0
Re: [PATCH 26/38] arm: dts: qcom: msm8226: Align multiple property data
Quoted 18 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/qcom/qcom-msm8226.dtsi +1
-1@@ -1483,12 +1483,12 @@ cpu_crit1: trip1 { timer { compatible = "arm,armv7-timer"; interrupts = <GIC_PPI 2 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>,
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi cpu_crit1: trip1 { · line 1493
Quoted 10 lines
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi +3
-3<GIC_PPI 3 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 4 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 1 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>; + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>; };
Likewise, these fit into 100c
Konrad
Re: [PATCH 26/38] arm: dts: qcom: msm8226: Align multiple property data
Quoted 23 lines · On Mon, Oct 12, 2026 at 17:31 +0200 Konrad Dybcio…
Quoted 22 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>--- arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/qcom/qcom-msm8226.dtsi +2
-2@@ -1483,12 +1483,12 @@ cpu_crit1: trip1 { timer { compatible = "arm,armv7-timer"; interrupts = <GIC_PPI 2 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 3 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 4
Quoted 8 lines
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi cpu_crit1: trip1 { · line 1493
Quoted 6 lines
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi +2
-2- (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 1 - (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>; + (GIC_CPU_MASK_RAW(15) | IRQ_TYPE_LEVEL_LOW)>; };Likewise, these fit into 100c
Yup, will change if we come to a conclusion (c.f. response in patch 19 and 22).
PATCH 27/38 arm: dts: qcom: msm8660: Remove empty line at end of node
In reply to Waqar HameedThere shouldn't be an empty line at end of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8660.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8660.dtsi +0 -2
@@ -107,7 +107,6 @@ tlmm: pinctrl@800000 { interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <2>; - }; gcc: clock-controller@900000 {
@@ -430,5 +429,4 @@ tcsr: syscon@1a400000 { reg = <0x1a400000 0x100>; }; }; - };
Signature · 1 line
2.43.0
Re: [PATCH 27/38] arm: dts: qcom: msm8660: Remove empty line at end of node
Quoted 5 lines · Waqar Hameed
There shouldn't be an empty line at end of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 28/38 arm: dts: qcom: msm8660: Remove space inside array property
In reply to Waqar HameedThere shouldn't be spaces at the beginning and end of an property array. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8660.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8660.dtsi +2 -2
@@ -83,8 +83,8 @@ intc: interrupt-controller@2080000 { compatible = "qcom,msm-8660-qgic"; interrupt-controller; #interrupt-cells = <3>; - reg = < 0x02080000 0x1000 >, - < 0x02081000 0x1000 >; + reg = <0x02080000 0x1000>, + <0x02081000 0x1000>; }; timer@2000000 {
Signature · 1 line
2.43.0
Re: [PATCH 28/38] arm: dts: qcom: msm8660: Remove space inside array property
Quoted 5 lines · Waqar Hameed
There shouldn't be spaces at the beginning and end of an property array. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 29/38 arm: dts: qcom: msm8660: Align closing array bracket
In reply to Waqar HameedClosing angle bracket of an array should be indented like property name. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8660-surf.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom/qcom-msm8660-surf.dts +1 -1
@@ -60,7 +60,7 @@ MATRIX_KEY(5, 1, KEY_RIGHT) MATRIX_KEY(5, 2, KEY_DOWN) MATRIX_KEY(5, 3, KEY_BACK) MATRIX_KEY(5, 4, KEY_MENU) - >; + >; keypad,num-rows = <6>; keypad,num-columns = <5>; };
Signature · 1 line
2.43.0
Re: [PATCH 29/38] arm: dts: qcom: msm8660: Align closing array bracket
Quoted 5 lines · Waqar Hameed
Closing angle bracket of an array should be indented like property name. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 30/38 arm: dts: qcom: msm8916: Add newline between subnodes
In reply to Waqar HameedThere should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8916-smp.dtsi | 3 +++ 1 file changed, 3 insertions(+)
arch/arm/boot/dts/qcom/qcom-msm8916-smp.dtsi +3 -0
@@ -5,12 +5,15 @@ cpus { cpu@0 { enable-method = "qcom,msm8916-smp"; }; + cpu@1 { enable-method = "qcom,msm8916-smp"; }; + cpu@2 { enable-method = "qcom,msm8916-smp"; }; + cpu@3 { enable-method = "qcom,msm8916-smp"; };
Signature · 1 line
2.43.0
Re: [PATCH 30/38] arm: dts: qcom: msm8916: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 31/38 arm: dts: qcom: msm8960: Properly indent subnodes
In reply to Waqar HameedSubnodes should be indented with tabs only. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts +8 -8
@@ -58,34 +58,34 @@ &gsbi5_serial { &tlmm { spi1_default: spi1-default-state { - mosi-pins { + mosi-pins { pins = "gpio6"; function = "gsbi1"; drive-strength = <12>; bias-disable; - }; + }; - miso-pins { + miso-pins { pins = "gpio7"; function = "gsbi1"; drive-strength = <12>; bias-disable; - }; + }; - cs-pins { + cs-pins { pins = "gpio8"; function = "gsbi1"; drive-strength = <12>; bias-disable; output-low; - }; + }; - clk-pins { + clk-pins { pins = "gpio9"; function = "gsbi1"; drive-strength = <12>; bias-disable; - }; + }; }; };
Signature · 1 line
2.43.0
Re: [PATCH 31/38] arm: dts: qcom: msm8960: Properly indent subnodes
Quoted 5 lines · Waqar Hameed
Subnodes should be indented with tabs only. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 32/38 arm: dts: qcom: msm8660: Align closing array bracket
In reply to Waqar HameedClosing angle bracket of an array should be indented like property name. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts +1 -1
@@ -99,7 +99,7 @@ MATRIX_KEY(0, 0, KEY_VOLUMEUP) MATRIX_KEY(0, 1, KEY_VOLUMEDOWN) MATRIX_KEY(0, 2, KEY_CAMERA_FOCUS) MATRIX_KEY(0, 3, KEY_CAMERA) - >; + >; keypad,num-rows = <1>; keypad,num-columns = <5>;
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH 32/38] arm: dts: qcom: msm8660: Align closing array bracket
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dts: qcom: commit subject incorrectly references msm8660 instead of msm8960 --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: qcom: commit subject incorrectly references msm8660 instead of msm8960 --
commit b17e9982dfac5102cf428f6631b5708c042ae4d2
Author: Waqar Hameed <[email protected]>
arm: dts: qcom: msm8660: Align closing array bracket
This commit fixes the indentation of the closing angle bracket for the matrix keymap array in the device tree source.
Quoted 1 line
arm: dts: qcom: msm8660: Align closing array bracket
[Severity: Low]
This isn't a bug, but the commit subject incorrectly references the msm8660 platform, while the patch actually modifies qcom-msm8960-cdp.dts. Should the subject prefix be msm8960 instead?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=32
Re: [PATCH 32/38] arm: dts: qcom: msm8660: Align closing array bracket
Quoted 12 lines · On Fri, Oct 02, 2026 at 09:14 +0000 [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: qcom: commit subject incorrectly references msm8660 instead of msm8960 --commit
b17e9982dfac5102cf428f6631b5708c042ae4d2
Author: Waqar Hameed <[email protected]>arm: dts: qcom: msm8660: Align closing array bracket
This commit fixes the indentation of the closing angle bracket for the matrix keymap array in the device tree source.
Quoted 6 lines
Quoted 1 line
arm: dts: qcom: msm8660: Align closing array bracket
[Severity: Low]
This isn't a bug, but the commit subject incorrectly references the msm8660 platform, while the patch actually modifiesqcom-msm8960-cdp.dts. Should the subject prefix be msm8960 instead?
Good bot! Will fix!
Re: [PATCH 32/38] arm: dts: qcom: msm8660: Align closing array bracket
In reply to Waqar HameedQuoted 5 lines · Waqar Hameed
Closing angle bracket of an array should be indented like property name. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 33/38 arm: dts: qcom: msm8974: Align multiple property data
In reply to Waqar HameedMultiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +5 -5
@@ -92,7 +92,7 @@ l2: l2-cache { idle-states { cpu_spc: cpu-spc { compatible = "qcom,idle-state-spc", - "arm,idle-state"; + "arm,idle-state"; entry-latency-us = <150>; exit-latency-us = <200>; min-residency-us = <2000>;
@@ -2228,10 +2228,10 @@ remoteproc_adsp: remoteproc@fe200000 { reg = <0xfe200000 0x100>; interrupts-extended = <&intc GIC_SPI 162 IRQ_TYPE_EDGE_RISING>, - <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, - <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, - <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, - <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; + <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, + <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, + <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, + <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; interrupt-names = "wdog", "fatal", "ready", "handover", "stop-ack"; clocks = <&xo_board>;
Signature · 1 line
2.43.0
Re: [PATCH 33/38] arm: dts: qcom: msm8974: Align multiple property data
Quoted 5 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 34/38 arm: dts: qcom: msm8974: Align closing brace properly
In reply to Waqar HameedClosing brace of a node definition should be indented like subnode name. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +1 -1
@@ -867,7 +867,7 @@ port { tpiu_in: endpoint { remote-endpoint = <&replicator_out1>; }; - }; + }; }; };
Signature · 1 line
2.43.0
Re: [PATCH 34/38] arm: dts: qcom: msm8974: Align closing brace properly
Quoted 5 lines · Waqar Hameed
Closing brace of a node definition should be indented like subnode name. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 35/38 arm: dts: qcom: msm8974: Add newline between subnodes
In reply to Waqar HameedThere should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +12 -0
@@ -960,6 +960,7 @@ replicator_out0: endpoint { remote-endpoint = <&etr_in>; }; }; + port@1 { reg = <1>; replicator_out1: endpoint {
@@ -1083,18 +1084,21 @@ kpss_in0: endpoint { remote-endpoint = <&etm0_out>; }; }; + port@1 { reg = <1>; kpss_in1: endpoint { remote-endpoint = <&etm1_out>; }; }; + port@2 { reg = <2>; kpss_in2: endpoint { remote-endpoint = <&etm2_out>; }; }; + port@3 { reg = <3>; kpss_in3: endpoint {
@@ -1785,6 +1789,7 @@ blsp1_i2c6_sleep: blsp1-i2c6-sleep-state { drive-strength = <2>; bias-pull-up; }; + /* 6 interfaces per QUP, BLSP2 indexes are numbered (n)+6 */ /* BLSP2_I2C1 info is missing */
@@ -1872,14 +1877,17 @@ mosi-pins { pins = "gpio45"; function = "blsp_spi8"; }; + miso-pins { pins = "gpio46"; function = "blsp_spi8"; }; + cs-pins { pins = "gpio47"; function = "blsp_spi8"; }; + clk-pins { pins = "gpio48"; function = "blsp_spi8";
@@ -2280,6 +2288,7 @@ cpu_alert0: trip0 { hysteresis = <2000>; type = "passive"; }; + cpu_crit0: trip1 { temperature = <110000>; hysteresis = <2000>;
@@ -2300,6 +2309,7 @@ cpu_alert1: trip0 { hysteresis = <2000>; type = "passive"; }; + cpu_crit1: trip1 { temperature = <110000>; hysteresis = <2000>;
@@ -2320,6 +2330,7 @@ cpu_alert2: trip0 { hysteresis = <2000>; type = "passive"; }; + cpu_crit2: trip1 { temperature = <110000>; hysteresis = <2000>;
@@ -2340,6 +2351,7 @@ cpu_alert3: trip0 { hysteresis = <2000>; type = "passive"; }; + cpu_crit3: trip1 { temperature = <110000>; hysteresis = <2000>;
Signature · 1 line
2.43.0
Re: [PATCH 35/38] arm: dts: qcom: msm8974: Add newline between subnodes
Quoted 5 lines · Waqar Hameed
There should be a newline between subnodes. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
Quoted 8 lines
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +0
-0
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi replicator_out0: endpoint { · line 966
Quoted 7 lines
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +1
-0@@ -960,6 +960,7 @@ replicator_out0: endpoint { remote-endpoint = <&etr_in>; }; }; + port@1 { reg = <1>; replicator_out1: endpoint {
P.S. ^^ we should also have a \n between the last property and the following subnode
Re: [PATCH 35/38] arm: dts: qcom: msm8974: Add newline between subnodes
Quoted 1 line · On Mon, Oct 12, 2026 at 17:51 +0200 Konrad Dybcio…
On 10/2/26 12:36 AM, Waqar Hameed wrote:
[...]
Quoted 18 lines
Quoted 8 lines
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +0
-0arch/arm/boot/dts/qcom/qcom-msm8974.dtsi replicator_out0: endpoint { · line 966
Quoted 7 lines
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +1
-0@@ -960,6 +960,7 @@ replicator_out0: endpoint { remote-endpoint = <&etr_in>; }; }; + port@1 { reg = <1>; replicator_out1: endpoint {
P.S. ^^ we should also have a \n between the last property and the following subnode
From Documentation/devicetree/bindings/dts-coding-style.rst I read
8. Child nodes, where each node is preceded with a blank line
I guess that also applies to the first subnode after the properties then, as you say? If so, let's update dtfmt to add a blank line there as well then. Thanks for pointing that out Konrad!
Re: [PATCH 35/38] arm: dts: qcom: msm8974: Add newline between subnodes
Quoted 25 lines · Waqar Hameed
Quoted 1 line · On Mon, Oct 12, 2026 at 17:51 +0200 Konrad Dybcio…
On 10/2/26 12:36 AM, Waqar Hameed wrote:
[...]
Quoted 18 lines
Quoted 8 lines
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +0
-0arch/arm/boot/dts/qcom/qcom-msm8974.dtsi replicator_out0: endpoint { · line 966
Quoted 7 lines
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +1
-0@@ -960,6 +960,7 @@ replicator_out0: endpoint { remote-endpoint = <&etr_in>; }; }; + port@1 { reg = <1>; replicator_out1: endpoint {
P.S. ^^ we should also have a \n between the last property and the following subnode
Quoted 7 lines
From
Documentation/devicetree/bindings/dts-coding-style.rstI read8. Child nodes, where each node is preceded with a blank line
I guess that also applies to the first subnode after the properties then, as you say? If so, let's update dtfmt to add a blank line there as well then. Thanks for pointing that out Konrad!
Yeah, thanks!
Konrad
PATCH 36/38 arm: dts: qcom: sdx55: Properly indent subnode
In reply to Waqar HameedSubnodes should be indented with tabs only. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-sdx55-t55.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/qcom/qcom-sdx55-t55.dts +5 -5
@@ -297,11 +297,11 @@ perst-pins { }; wake-pins { - pins = "gpio53"; - function = "gpio"; - drive-strength = <2>; - bias-pull-up; - }; + pins = "gpio53"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; }; };
Signature · 1 line
2.43.0
Re: [PATCH 36/38] arm: dts: qcom: sdx55: Properly indent subnode
Quoted 5 lines · Waqar Hameed
Subnodes should be indented with tabs only. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 37/38 arm: dts: qcom: sdx65: Remove empty line at end of node
In reply to Waqar HameedThere shouldn't be an empty line at end of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-sdx65.dtsi +0 -2
@@ -261,7 +261,6 @@ usb_qmpphy: phy@ff6000 { "phy_phy"; status = "disabled"; - }; system_noc: interconnect@1620000 {
@@ -807,7 +806,6 @@ rpmhpd_opp_turbo_l1: opp10 { apps_bcm_voter: bcm-voter { compatible = "qcom,bcm-voter"; }; - }; };
Signature · 1 line
2.43.0
Re: [PATCH 37/38] arm: dts: qcom: sdx65: Remove empty line at end of node
Quoted 5 lines · Waqar Hameed
There shouldn't be an empty line at end of node definition. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
PATCH 38/38 arm: dts: qcom: sdx65: Align multiple property data
In reply to Waqar HameedMultiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
--- arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/qcom/qcom-sdx65.dtsi +6 -6
@@ -544,10 +544,10 @@ restart@c264000 { spmi_bus: spmi@c440000 { compatible = "qcom,spmi-pmic-arb"; reg = <0xc440000 0xd00>, - <0xc600000 0x2000000>, - <0xe600000 0x100000>, - <0xe700000 0xa0000>, - <0xc40a000 0x26000>; + <0xc600000 0x2000000>, + <0xe600000 0x100000>, + <0xe700000 0xa0000>, + <0xc40a000 0x26000>; reg-names = "core", "chnls", "obsrvr", "intr", "cnfg"; interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "periph_irq";
@@ -735,10 +735,10 @@ apps_rsc: rsc@17830000 { label = "apps_rsc"; compatible = "qcom,rpmh-rsc"; reg = <0x17830000 0x10000>, - <0x17840000 0x10000>; + <0x17840000 0x10000>; reg-names = "drv-0", "drv-1"; interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>; qcom,tcs-offset = <0xd00>; qcom,drv-id = <1>; qcom,tcs-config = <ACTIVE_TCS 2>,
Signature · 1 line
2.43.0
Re: [PATCH 38/38] arm: dts: qcom: sdx65: Align multiple property data
Quoted 5 lines · Waqar Hameed
Multiple property data on a newline should be aligned with the first one. Found/fixed with dtfmt (Devicetree Source formatter).
Signed-off-by Waqar Hameed <[email protected]>---
Konrad
Quoted 18 lines · Waqar Hameed
I was looking through the notes for the last Devicetree microconference at Linux Plumbers (LPC) 2025 [1], and realized that the tool I have been working on might be of interest here: dtfmt - a Devicetree Source formatter [2].
dtfmt uses a parser with lexical grammar (tree-sitter) directly ported from the actual Device Tree Compiler's (dtc) lexer/parser, also (hand)written by me [3]. It is primarily designed for the Linux kernel and currently parses all 6872 devicetree files in the tree successfully (found with
find . -iregex ".+\.dts[io]?$").This tool was developed out of frustration when reviewing devicetree patches internally at my company Axis. I would have published it earlier if I was aware of the on-going discussions at LPC 2025. It only caught my attention since I'm planning to attend LPC this year (especially the Devicetree microconference and would therefore love to discuss this more in-person!).
Quoted 5 lines
This patch series is only a small demonstration of dtfmt, primarily to get Konrad Dybcio in the "To:"-field (who did the presentation on LPC 2025). Obviously one can run dtfmt for all files and generate a much bigger diff. There have been patches sent for
arch/arm64/boot/dts/exynos/previously [4].
Incredible work, thank you once again!
For some fun trivia, this is the tool you might have heard of as we walked around one of the LPC 2026 evening events and kept poking the various soc maintainers!
Konrad
Quoted 19 lines · On Mon, Oct 12, 2026 at 17:28 +0200 Konrad Dybcio…
Quoted 18 lines · Waqar Hameed
I was looking through the notes for the last Devicetree microconference at Linux Plumbers (LPC) 2025 [1], and realized that the tool I have been working on might be of interest here: dtfmt - a Devicetree Source formatter [2].
dtfmt uses a parser with lexical grammar (tree-sitter) directly ported from the actual Device Tree Compiler's (dtc) lexer/parser, also (hand)written by me [3]. It is primarily designed for the Linux kernel and currently parses all 6872 devicetree files in the tree successfully (found with
find . -iregex ".+\.dts[io]?$").This tool was developed out of frustration when reviewing devicetree patches internally at my company Axis. I would have published it earlier if I was aware of the on-going discussions at LPC 2025. It only caught my attention since I'm planning to attend LPC this year (especially the Devicetree microconference and would therefore love to discuss this more in-person!).
Quoted 7 lines
Quoted 5 lines
This patch series is only a small demonstration of dtfmt, primarily to get Konrad Dybcio in the "To:"-field (who did the presentation on LPC 2025). Obviously one can run dtfmt for all files and generate a much bigger diff. There have been patches sent for
arch/arm64/boot/dts/exynos/previously [4].Incredible work, thank you once again!
Thank you very much Konrad! I hope we can have some fruitful discussions around this!
Quoted 4 lines
For some fun trivia, this is the tool you might have heard of as we walked around one of the LPC 2026 evening events and kept poking the various soc maintainers!
Haha that was fun! I will indeed send some examples to Samuel Holland and AngeloGioacchino Del Regno (added to CC) soon, as previously promised :)
Re: (subset) [PATCH 00/38] arm: dts: qcom: Format with dtfmt
In reply to Waqar HameedQuoted 5 lines · Waqar Hameed
I was looking through the notes for the last Devicetree microconference at Linux Plumbers (LPC) 2025 [1], and realized that the tool I have been working on might be of interest here: dtfmt - a Devicetree Source formatter [2].
Quoted 7 lines
dtfmt uses a parser with lexical grammar (tree-sitter) directly ported from the actual Device Tree Compiler's (dtc) lexer/parser, also (hand)written by me [3]. It is primarily designed for the Linux kernel and currently parses all 6872 devicetree files in the tree successfully (found with
find . -iregex ".+\.dts[io]?$").[...]
Applied, thanks!
[01/38] arm: dts: qcom: pm8226: Add newline between subnodes
commit: 5891ac4aac66f8867f2badb0f667e97fa93a8998
[02/38] arm: dts: qcom: pm8841: Remove superfluous empty lines
commit: 47b258bacac524458c3b19eb09e9122604158229
[03/38] arm: dts: qcom: pm8921: Remove superfluous empty lines
commit: 907ca1b0e46e1431d2e7c8803b338000b3d49552
[04/38] arm: dts: qcom: pm8941: Remove superfluous empty lines
commit: 73fab0c1a361e131c873bcbe099e304eb63d6851
[05/38] arm: dts: qcom: pm8084: Remove superfluous empty line
commit: 45142714cbbc11b988360cda7915df415569d18f
[06/38] arm: dts: qcom: apq8026: Add newline between subnodes
commit: 9df53dd8f25f50e1df85a272893fb6fa46da3e9f
[07/38] arm: dts: qcom: apq8026: Add space between OR-operator
commit: ff2ecb673fe8b8798c4487803677b132d564ffb8
[08/38] arm: dts: qcom: apq8060: Add newline between subnodes
commit: 09781c9bdd1420809e3afd1dc6280141bb415ca0
[09/38] arm: dts: qcom: apq8060: Align multiple property data
commit: 62cc70db73f86a8fbac51f547efd57ca5d9f583d
[11/38] arm: dts: qcom: apq8064: Add newline between subnodes
commit: 91befd2233976da5e93c352c412ac016e1d4b524
[12/38] arm: dts: qcom: apq8064: Remove empty line at end of node
commit: 32f2a3ae88836da3599497fa48ce00d8386e90ee
[13/38] arm: dts: qcom: apq8064: Add space before line comments
commit: 668d5c4f17ba7ac71dec8171a3089cf86bac6013
[15/38] arm: dts: qcom: apq8064: Remove tab after property name
commit: c80842bc5645048d3420a70212d266b1180d97a0
[16/38] arm: dts: qcom: ipq4018: Indent closing brace properly
commit: 2e5995f56125656a764b10dbf6a851bc4aa78e80
[17/38] arm: dts: qcom: ipq4019: Add newline between subnodes
commit: 0bb2cc21182d4ec9b2f735969eab5b7e6e166547
[18/38] arm: dts: qcom: ipq4019: Align multiple property data
commit: 7ee7adcd177ef173ac5173d9f2abd4a11fcb6ee8
[20/38] arm: dts: qcom: ipq8064: Add newline between subnodes
commit: 1af8b1d15661d9fab079707b3033d5972581b370
[21/38] arm: dts: qcom: ipq8064: Align multiple property data
commit: 60e3b3a311d7d279d854d45544361840eda8d4e8
[23/38] arm: dts: qcom: msm8226: Add space between OR-operator
commit: 599f0af30d988442a91b1ae06d85c416370d131d
[24/38] arm: dts: qcom: msm8226: Add newline between subnodes
commit: 067a79e474d668879973e8ade04c15930c065a3f
[27/38] arm: dts: qcom: msm8660: Remove empty line at end of node
commit: d4d1902dd9fc44ee750aa8e26f747a6a415a0d94
[28/38] arm: dts: qcom: msm8660: Remove space inside array property
commit: 1981640ac8f8dd8d142e649a6b6067ae1966a689
[29/38] arm: dts: qcom: msm8660: Align closing array bracket
commit: b8523cf55936a779055a8e407982d577ecef0dcc
[30/38] arm: dts: qcom: msm8916: Add newline between subnodes
commit: a9cf6dc7dda2ef9bd6b35a9a3a0cf68ebd4014cc
[31/38] arm: dts: qcom: msm8960: Properly indent subnodes
commit: 8c70a6486f560ae5d50914f89ba34e066ac85ff0
[32/38] arm: dts: qcom: msm8660: Align closing array bracket
commit: b8523cf55936a779055a8e407982d577ecef0dcc
[33/38] arm: dts: qcom: msm8974: Align multiple property data
commit: bcf022999f71e337dd2bfa6e3ce860c3267d0c36
[34/38] arm: dts: qcom: msm8974: Align closing brace properly
commit: 9e5e19b9591f6ca93e20256603b14aa90573d520
[35/38] arm: dts: qcom: msm8974: Add newline between subnodes
commit: d53daef23defdb7a926fde228764209f9d71e317
[36/38] arm: dts: qcom: sdx55: Properly indent subnode
commit: 88b3da2433d0c661dc7548b3a148afb4bf8dbeb8
[37/38] arm: dts: qcom: sdx65: Remove empty line at end of node
commit: 83a91ecbb1fa193f1cee7339a477f8dbd5ac0b62
[38/38] arm: dts: qcom: sdx65: Align multiple property data
commit: ae2005cea2e4f84692268e54199bb03f5c6f4558Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>