Skip to contentSkip to conversation

pinctrl: ambarella: add CONFIG_OF dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Oct 2

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: ambarella: add CONFIG_OF dependency

From: Arnd Bergmann <[email protected]>

On randconfig builds without CONFIG_OF, this driver fails to link:

x86_64-linux-ld: vmlinux.o: in function `pinconf_generic_dt_node_to_map_all':
pinctrl-ambarella.c:(.text+0x54cdf0): undefined reference to `pinconf_generic_dt_node_to_map'

Enforce OF as a dependency as we do for other such drivers.

Fixes b40e9d140c24 ("pinctrl: ambarella: add CV75 pin controller")
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
index 6fe53a684dc0..83f68bdd951a 100644
@@ -41,6 +41,7 @@ config PINCTRL_AMB
 	bool "Ambarella pin controller support"
 	depends on ARCH_AMBARELLA || COMPILE_TEST
 	depends on HAS_IOMEM
+	depends on OF
 	default y if ARCH_AMBARELLA
 	select GENERIC_PINCONF
 	select GENERIC_PINCTRL_GROUPS
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

On randconfig builds without CONFIG_OF, this driver fails to link:

x86_64-linux-ld: vmlinux.o: in function `pinconf_generic_dt_node_to_map_all':
pinctrl-ambarella.c:(.text+0x54cdf0): undefined reference to `pinconf_generic_dt_node_to_map'

Enforce OF as a dependency as we do for other such drivers.

Fixes b40e9d140c24 ("pinctrl: ambarella: add CV75 pin controller")

Patch applied!

Yours,
Linus Walleij