monitor: Fix legacy SCAN_RSP PDU type names
PATCH 1/1 monitor: Fix legacy SCAN_RSP PDU type names
The names of the two legacy scan response event types are swapped. A scan response keeps the properties of the advertisement it answers, so 0x1b, which has the connectable bit set, is the response to ADV_IND and 0x1a is the response to ADV_SCAN_IND, as listed in Core Specification Vol 4, Part E, 7.7.65.13, Table 7.1.
--- monitor/packet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
monitor/packet.c +2 -2
@@ -13074,10 +13074,10 @@ static void print_legacy_adv_report_pdu(uint16_t flags) str ="ADV_DIRECT_IND" ;break ;case 0x1a : - str ="SCAN_RSP to an ADV_IND" ; + str ="SCAN_RSP to an ADV_SCAN_IND" ;break ;case 0x1b : - str ="SCAN_RSP to an ADV_SCAN_IND" ; + str ="SCAN_RSP to an ADV_IND" ;break ;default : str ="Reserved" ;
Signature · 1 line
2.54.0 (Apple Git-157)
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1178588/
---Test result---
Test Summary:
CheckPatch PASS 0.29 seconds GitLint PASS 0.22 seconds BuildEll PASS 19.97 seconds BluezMake PASS 400.93 seconds MakeCheck PASS 0.83 seconds MakeDistcheck PASS 143.06 seconds CheckValgrind PASS 148.04 seconds CheckSmatch WARNING 292.34 seconds bluezmakeextell PASS 93.70 seconds TestFunctional PASS 1158.36 seconds IncrementalBuild PASS 404.38 seconds ScanBuild PASS 1157.22 seconds
Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:monitor/packet.c:2289:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3924:52: warning: array of flexible structuresmonitor/bt.h:3912:40: warning: array of flexible structures
https://github.com/bluez/bluez/pull/2624
---
Regards,
Linux Bluetooth
Hi Luiz,
Gentle ping on this one. It swaps the two SCAN_RSP labels btmon prints for legacy advertising reports, so they match Table 7.1 of the Core specification, and it still applies cleanly to master.
Kevin
This is an automated email and please do not reply to this email.
Dear Submitter,
This series was picked up by the CI more than 2 weeks ago and the pull request created for it is still open, which means the series was never applied to the tree.
Series: [BlueZ] monitor: Fix legacy SCAN_RSP PDU type names
Pull Request: https://github.com/bluez/bluez/pull/2624
Created: 2026-10-02 21:02:04+00:00
The pull request has been closed and no further action is taken on this series.
If the change should still be considered, it must be resent to the Linux Bluetooth mailing list ([email protected]) so that it is picked up again.
---
Regards,
Linux Bluetooth