backlight: lm3630a: Cancel delayed work before destroying workqueue
Subsystems (3)
PATCH 1/1 backlight: lm3630a: Cancel delayed work before destroying workqueue
The interrupt handler queues delayed work to read the interrupt status. After free_irq() stops the producer, this work can still be waiting on its timer. destroy_workqueue() cannot drain delayed work that has not yet been queued by its timer, so the timer can outlive both the workqueue and the devm-allocated chip containing the work.
Cancel the delayed work synchronously after freeing the IRQ and before destroying the workqueue. This also waits for any running status read to finish before the chip's resources are released.
This issue was identified during our ongoing static-analysis research while reviewing kernel code.
--- drivers/video/backlight/lm3630a_bl.c | 1 + 1 file changed, 1 insertion(+)
drivers/video/backlight/lm3630a_bl.c +1 -0
@@ -591,6 +591,7 @@ static void lm3630a_remove(struct i2c_client *client)if (pchip->irq) {free_irq (pchip->irq, pchip); +cancel_delayed_work_sync (&pchip->work);destroy_workqueue (pchip->irqthread); } }
Signature · 1 line
2.53.0
Quoted 13 lines · Myeonghun Pak
The interrupt handler queues delayed work to read the interrupt status. After
free_irq()stops the producer, this work can still be waiting on its timer.destroy_workqueue()cannot drain delayed work that has not yet been queued by its timer, so the timer can outlive both the workqueue and the devm-allocated chip containing the work.Cancel the delayed work synchronously after freeing the IRQ and before destroying the workqueue. This also waits for any running status read to finish before the chip's resources are released.
This issue was identified during our ongoing static-analysis research while reviewing kernel code.
Quoted 6 lines
Fixes 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip")Assisted-by LLMCo-developed-by Ijae Kim <[email protected]>Signed-off-by Ijae Kim <[email protected]>Signed-off-by Myeonghun Pak <[email protected]>
Daniel.
Re: (subset) [PATCH] backlight: lm3630a: Cancel delayed work before destroying workqueue
In reply to Myeonghun PakQuoted 11 lines · Myeonghun Pak
The interrupt handler queues delayed work to read the interrupt status. After
free_irq()stops the producer, this work can still be waiting on its timer.destroy_workqueue()cannot drain delayed work that has not yet been queued by its timer, so the timer can outlive both the workqueue and the devm-allocated chip containing the work.Cancel the delayed work synchronously after freeing the IRQ and before destroying the workqueue. This also waits for any running status read to finish before the chip's resources are released.
[...]
Applied, thanks!
[1/1] backlight: lm3630a: Cancel delayed work before destroying workqueue
commit: 2cf184caab8b406fdd9db126ee40d62418237456
--
Lee Jones [李琼斯]