drm/loongson: Fix double free on BO initialization failure
Subsystems (4)
PATCH 1/2 drm/loongson: Fix double free on BO initialization failure
If ttm_bo_init_validate() fails, it drops the buffer object's reference and cleans it up through the supplied destroy callback. lsdc_bo_destroy() releases the GEM object and frees the enclosing lsdc_bo, so freeing it again in lsdc_bo_create() causes a double free on a synchronous failure path.
Let TTM own the cleanup after initialization has started and return the error directly. Keep the explicit free on drm_gem_object_init() failure, which occurs before ownership is passed to TTM.
Tested on LS7A2000 by making drm_vma_offset_add() return -ENOSPC for one selected dumb-buffer creation. The error reached userspace, the destroy callback ran once, and no handle was published or tracked BO retained. Normal buffer creation, zeroing, mapping, readback and release passed.
AI assistance was used for the ownership analysis, fix, fault-injection tools, build and test execution.
--- drivers/gpu/drm/loongson/lsdc_ttm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/loongson/lsdc_ttm.c +1 -3
@@ -475,10 +475,8 @@ struct lsdc_bo *lsdc_bo_create(struct drm_device *ddev, ret =ttm_bo_init_validate (bdev, tbo, bo_type, &lbo->placement,0 , false, sg, resv, lsdc_bo_destroy); -if (ret) { -kfree (lbo); +if (ret)return ERR_PTR (ret); - }return lbo; }
base-commit: bca45af5998a05f34b13a2ef11e639bac9c62643
Signature · 1 line
2.43.0
PATCH 2/2 drm/loongson: Handle buffer mapping failures when clearing a BO
lsdc_bo_clear() ignores the return value from lsdc_bo_kmap() and writes to lbo->kptr unconditionally. When the first mapping of a newly allocated buffer fails, kptr is still NULL and the subsequent memset accesses it.
Return the mapping error without touching the buffer and propagate it from lsdc_gem_object_create(). Install the GEM object functions before clearing so that drm_gem_object_put() can release the buffer correctly on failure. Do not add the failed object to the tracking list or return an uncleared buffer to the caller.
Imported buffers still skip clearing, and successfully mapped buffers are cleared and unmapped as before.
Tested on LS7A2000 with a one-shot range error in ttm_bo_kmap(). Its -EINVAL return reached userspace, the object was destroyed once, and no GEM handle was published. Normal create/map/zero/write/read/close cycles passed, with the tracked BO count and VRAM usage unchanged.
AI assistance was used for the lifetime analysis, fix, fault-injection tools, build and test execution.
--- drivers/gpu/drm/loongson/lsdc_gem.c | 12 ++++++++---- drivers/gpu/drm/loongson/lsdc_ttm.c | 10 ++++++++-- drivers/gpu/drm/loongson/lsdc_ttm.h | 2 +- 3 files changed, 17 insertions(+), 7 deletions(-)
drivers/gpu/drm/loongson/lsdc_gem.c +8 -4
@@ -157,14 +157,18 @@ struct drm_gem_object *lsdc_gem_object_create(struct drm_device *ddev,return ERR_PTR (ret); } + gobj = &lbo->tbo.base; + gobj->funcs = &lsdc_gem_object_funcs; +if (!sg) {/* VRAM is filled with random data */ -lsdc_bo_clear (lbo); + ret =lsdc_bo_clear (lbo); +if (ret) { +drm_gem_object_put (gobj); +return ERR_PTR (ret); + } } - gobj = &lbo->tbo.base; - gobj->funcs = &lsdc_gem_object_funcs; -/* tracking the BOs we created */ mutex_lock (&ldev->gem.mutex);list_add_tail (&lbo->list, &ldev->gem.objects);
drivers/gpu/drm/loongson/lsdc_ttm.c +8 -2
@@ -388,9 +388,13 @@ void lsdc_bo_kunmap(struct lsdc_bo *lbo)ttm_bo_kunmap (&lbo->kmap); } -void lsdc_bo_clear (struct lsdc_bo *lbo) +int lsdc_bo_clear (struct lsdc_bo *lbo) { -lsdc_bo_kmap (lbo); +int ret; + + ret =lsdc_bo_kmap (lbo); +if (ret) +return ret;if (lbo->is_iomem)memset_io ((void __iomem *)lbo->kptr,0 , lbo->size);
@@ -398,6 +402,8 @@ void lsdc_bo_clear(struct lsdc_bo *lbo)memset (lbo->kptr,0 , lbo->size);lsdc_bo_kunmap (lbo); + +return 0 ; }int lsdc_bo_evict_vram (struct drm_device *ddev)
drivers/gpu/drm/loongson/lsdc_ttm.h +1 -1
@@ -89,7 +89,7 @@ size_t lsdc_bo_size(struct lsdc_bo *lbo);int lsdc_bo_kmap (struct lsdc_bo *lbo);void lsdc_bo_kunmap (struct lsdc_bo *lbo); -void lsdc_bo_clear (struct lsdc_bo *lbo); +int lsdc_bo_clear (struct lsdc_bo *lbo);int lsdc_bo_evict_vram (struct drm_device *ddev);
Signature · 1 line
2.43.0
Icenowy Zheng
reviewerRe: [PATCH 2/2] drm/loongson: Handle buffer mapping failures when clearing a BO
Quoted 95 lines · 在 2026-10-03六的 09:34 +0000,Evanshenf写道:
lsdc_bo_clear()ignores the return value fromlsdc_bo_kmap()and writes
tolbo->kptrunconditionally. When the first mapping of a newly allocated
buffer fails, kptr is still NULL and the subsequent memset accesses it.Return the mapping error without touching the buffer and propagate it from
lsdc_gem_object_create(). Install the GEM object functions before
clearing so thatdrm_gem_object_put()can release the buffer correctly
on failure. Do not add the failed object to the tracking list or return
an uncleared buffer to the caller.Imported buffers still skip clearing, and successfully mapped buffers are cleared and unmapped as before.
Tested on LS7A2000 with a one-shot range error in
ttm_bo_kmap(). Its-EINVALreturn reached userspace, the object was destroyed once, and no GEM handle was published. Normal create/map/zero/write/read/close cycles passed, with the tracked BO count and VRAM usage unchanged.AI assistance was used for the lifetime analysis, fix, fault- injection
tools, build and test execution.Fixes f39db26c5428 ("drm: Add kms driver for loongson displaycontroller")
---
drivers/gpu/drm/loongson/lsdc_gem.c | 12 ++++++++---- drivers/gpu/drm/loongson/lsdc_ttm.c | 10 ++++++++-- drivers/gpu/drm/loongson/lsdc_ttm.h | 2 +- 3 files changed, 17 insertions(+), 7 deletions(-)drivers/gpu/drm/loongson/lsdc_gem.c +0
-0@@ -157,14 +157,18 @@ struct drm_gem_object *lsdc_gem_object_create(struct drm_device *ddev, return ERR_PTR(ret); }drivers/gpu/drm/loongson/lsdc_gem.c +3
-0+ gobj = &lbo->tbo.base; + gobj->funcs = &lsdc_gem_object_funcs; +if (!sg) {
/* VRAM is filled with random data */drivers/gpu/drm/loongson/lsdc_gem.c +5
-1-lsdc_bo_clear (lbo); + ret =lsdc_bo_clear (lbo); +if (ret) { +drm_gem_object_put (gobj); +return ERR_PTR (ret); + }}
drivers/gpu/drm/loongson/lsdc_gem.c +0
-3- gobj = &lbo->tbo.base; - gobj->funcs = &lsdc_gem_object_funcs; -/* tracking the BOs we created */
mutex_lock(&ldev->gem.mutex);list_add_tail(&lbo->list, &ldev->gem.objects);drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -388,9 +388,13 @@ void lsdc_bo_kunmap(struct lsdc_bo *lbo) ttm_bo_kunmap(&lbo->kmap); }drivers/gpu/drm/loongson/lsdc_ttm.c +1
-1-void lsdc_bo_clear (struct lsdc_bo *lbo) +int lsdc_bo_clear (struct lsdc_bo *lbo){
drivers/gpu/drm/loongson/lsdc_ttm.c +5
-1-lsdc_bo_kmap (lbo); +int ret; + + ret =lsdc_bo_kmap (lbo); +if (ret) +return ret;
if (lbo->is_iomem)
memset_io((void __iomem *)lbo->kptr, 0, lbo->size);drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -398,6 +402,8 @@ void lsdc_bo_clear(struct lsdc_bo *lbo) memset(lbo->kptr, 0, lbo->size);
lsdc_bo_kunmap(lbo);drivers/gpu/drm/loongson/lsdc_ttm.c +2
-0+ +return 0 ;
Quoted 3 lines
}
intlsdc_bo_evict_vram(struct drm_device *ddev)
Well I currently don't know whether the clearing is meaningful...
It seems that drm_gem_vram_helper doesn't do this.
Cc'ing TTM maintainers for an answer.
Thanks,
Icenowy
Quoted 14 lines
drivers/gpu/drm/loongson/lsdc_ttm.h +0
-0@@ -89,7 +89,7 @@ size_t lsdc_bo_size(struct lsdc_bo *lbo);
intlsdc_bo_kmap(struct lsdc_bo *lbo);
voidlsdc_bo_kunmap(struct lsdc_bo *lbo);drivers/gpu/drm/loongson/lsdc_ttm.h +1
-1-void lsdc_bo_clear (struct lsdc_bo *lbo); +int lsdc_bo_clear (struct lsdc_bo *lbo);
intlsdc_bo_evict_vram(struct drm_device *ddev);
Re: [PATCH 2/2] drm/loongson: Handle buffer mapping failures when clearing a BO
Quoted 102 lines · Icenowy Zheng
Quoted 95 lines · 在 2026-10-03六的 09:34 +0000,Evanshenf写道:
lsdc_bo_clear()ignores the return value fromlsdc_bo_kmap()and writes
tolbo->kptrunconditionally. When the first mapping of a newly allocated
buffer fails, kptr is still NULL and the subsequent memset accesses it.Return the mapping error without touching the buffer and propagate it from
lsdc_gem_object_create(). Install the GEM object functions before
clearing so thatdrm_gem_object_put()can release the buffer correctly
on failure. Do not add the failed object to the tracking list or return
an uncleared buffer to the caller.Imported buffers still skip clearing, and successfully mapped buffers are cleared and unmapped as before.
Tested on LS7A2000 with a one-shot range error in
ttm_bo_kmap(). Its-EINVALreturn reached userspace, the object was destroyed once, and no GEM handle was published. Normal create/map/zero/write/read/close cycles passed, with the tracked BO count and VRAM usage unchanged.AI assistance was used for the lifetime analysis, fix, fault- injection
tools, build and test execution.Fixes f39db26c5428 ("drm: Add kms driver for loongson displaycontroller")
---
drivers/gpu/drm/loongson/lsdc_gem.c | 12 ++++++++---- drivers/gpu/drm/loongson/lsdc_ttm.c | 10 ++++++++-- drivers/gpu/drm/loongson/lsdc_ttm.h | 2 +- 3 files changed, 17 insertions(+), 7 deletions(-)drivers/gpu/drm/loongson/lsdc_gem.c +0
-0@@ -157,14 +157,18 @@ struct drm_gem_object *lsdc_gem_object_create(struct drm_device *ddev, return ERR_PTR(ret); }drivers/gpu/drm/loongson/lsdc_gem.c +3
-0+ gobj = &lbo->tbo.base; + gobj->funcs = &lsdc_gem_object_funcs; +if (!sg) {
/* VRAM is filled with random data */drivers/gpu/drm/loongson/lsdc_gem.c +5
-1-lsdc_bo_clear (lbo); + ret =lsdc_bo_clear (lbo); +if (ret) { +drm_gem_object_put (gobj); +return ERR_PTR (ret); + }}
drivers/gpu/drm/loongson/lsdc_gem.c +0
-3- gobj = &lbo->tbo.base; - gobj->funcs = &lsdc_gem_object_funcs; -/* tracking the BOs we created */
mutex_lock(&ldev->gem.mutex);list_add_tail(&lbo->list, &ldev->gem.objects);drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -388,9 +388,13 @@ void lsdc_bo_kunmap(struct lsdc_bo *lbo) ttm_bo_kunmap(&lbo->kmap); }drivers/gpu/drm/loongson/lsdc_ttm.c +1
-1-void lsdc_bo_clear (struct lsdc_bo *lbo) +int lsdc_bo_clear (struct lsdc_bo *lbo){
drivers/gpu/drm/loongson/lsdc_ttm.c +5
-1-lsdc_bo_kmap (lbo); +int ret; + + ret =lsdc_bo_kmap (lbo); +if (ret) +return ret;
if (lbo->is_iomem)
memset_io((void __iomem *)lbo->kptr, 0, lbo->size);drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -398,6 +402,8 @@ void lsdc_bo_clear(struct lsdc_bo *lbo) memset(lbo->kptr, 0, lbo->size);
lsdc_bo_kunmap(lbo);drivers/gpu/drm/loongson/lsdc_ttm.c +2
-0+ +return 0 ;Quoted 3 lines
}
intlsdc_bo_evict_vram(struct drm_device *ddev)Well I currently don't know whether the clearing is meaningful...
Quoted 3 lines
It seems that
drm_gem_vram_helperdoesn't do this.Cc'ing TTM maintainers for an answer.
Natalie and Arun are TTM maintainers now, but I will try to answer here as well.
OpenGL doesn't necessarily require clearing of VRAM nor isolation of VRAM data between processes.
So it is up to the driver if they want this or not. Classically a lot of drivers didn't clear VRAM allocations until explicitely asked.
But if you clear the memory you should have proper error handling and a kmap/vmap can fail at any time for multiple reasons.
Regards,
Christian.
Quoted 19 lines
Thanks,
IcenowyQuoted 14 lines
drivers/gpu/drm/loongson/lsdc_ttm.h +0
-0@@ -89,7 +89,7 @@ size_t lsdc_bo_size(struct lsdc_bo *lbo);
intlsdc_bo_kmap(struct lsdc_bo *lbo);
voidlsdc_bo_kunmap(struct lsdc_bo *lbo);drivers/gpu/drm/loongson/lsdc_ttm.h +1
-1-void lsdc_bo_clear (struct lsdc_bo *lbo); +int lsdc_bo_clear (struct lsdc_bo *lbo);
intlsdc_bo_evict_vram(struct drm_device *ddev);
Icenowy Zheng
reviewerRe: [PATCH 2/2] drm/loongson: Handle buffer mapping failures when clearing a BO
Quoted 111 lines · 在 2026-10-09五的 16:14 +0200,Christian König写道:
Quoted 110 lines · Icenowy Zheng
Quoted 103 lines · 在 2026-10-03六的 09:34 +0000,Evanshenf写道:
lsdc_bo_clear()ignores the return value fromlsdc_bo_kmap()and writes
tolbo->kptrunconditionally. When the first mapping of a newly allocated
buffer fails, kptr is still NULL and the subsequent memset accesses
it.Return the mapping error without touching the buffer and propagate it
fromlsdc_gem_object_create(). Install the GEM object functions before
clearing so thatdrm_gem_object_put()can release the buffer correctly
on failure. Do not add the failed object to the tracking list or return
an uncleared buffer to the caller.Imported buffers still skip clearing, and successfully mapped buffers
are cleared and unmapped as before.Tested on LS7A2000 with a one-shot range error in
ttm_bo_kmap(). Its-EINVALreturn reached userspace, the object was destroyed once, and
no GEM handle was published. Normal create/map/zero/write/read/close
cycles passed, with the tracked BO count and VRAM usage unchanged.AI assistance was used for the lifetime analysis, fix, fault- injection
tools, build and test execution.Fixes f39db26c5428 ("drm: Add kms driver for loongson displaycontroller")
---
drivers/gpu/drm/loongson/lsdc_gem.c | 12 ++++++++---- drivers/gpu/drm/loongson/lsdc_ttm.c | 10 ++++++++-- drivers/gpu/drm/loongson/lsdc_ttm.h | 2 +- 3 files changed, 17 insertions(+), 7 deletions(-)drivers/gpu/drm/loongson/lsdc_gem.c +0
-0@@ -157,14 +157,18 @@ struct drm_gem_object *lsdc_gem_object_create(struct drm_device *ddev, return ERR_PTR(ret); }drivers/gpu/drm/loongson/lsdc_gem.c +3
-0+ gobj = &lbo->tbo.base; + gobj->funcs = &lsdc_gem_object_funcs; +if (!sg) {
/* VRAM is filled with random data */drivers/gpu/drm/loongson/lsdc_gem.c +5
-1-lsdc_bo_clear (lbo); + ret =lsdc_bo_clear (lbo); +if (ret) { +drm_gem_object_put (gobj); +return ERR_PTR (ret); + }}
drivers/gpu/drm/loongson/lsdc_gem.c +0
-3- gobj = &lbo->tbo.base; - gobj->funcs = &lsdc_gem_object_funcs; -/* tracking the BOs we created */
mutex_lock(&ldev->gem.mutex);list_add_tail(&lbo->list, &ldev->gem.objects);drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -388,9 +388,13 @@ void lsdc_bo_kunmap(struct lsdc_bo *lbo) ttm_bo_kunmap(&lbo->kmap); }drivers/gpu/drm/loongson/lsdc_ttm.c +1
-1-void lsdc_bo_clear (struct lsdc_bo *lbo) +int lsdc_bo_clear (struct lsdc_bo *lbo){
drivers/gpu/drm/loongson/lsdc_ttm.c +5
-1-lsdc_bo_kmap (lbo); +int ret; + + ret =lsdc_bo_kmap (lbo); +if (ret) +return ret;
if (lbo->is_iomem)
memset_io((void__iomem*)lbo->kptr, 0, lbo-Quoted 1 line
size);
drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -398,6 +402,8 @@ void lsdc_bo_clear(struct lsdc_bo *lbo) memset(lbo->kptr, 0, lbo->size);
lsdc_bo_kunmap(lbo);drivers/gpu/drm/loongson/lsdc_ttm.c +2
-0+ +return 0 ;Quoted 3 lines
}
intlsdc_bo_evict_vram(struct drm_device *ddev)Well I currently don't know whether the clearing is meaningful...
Quoted 6 lines
Quoted 3 lines
It seems that
drm_gem_vram_helperdoesn't do this.Cc'ing TTM maintainers for an answer.
Natalie and Arun are TTM maintainers now, but I will try to answer here as well.
Ah I heard about TTM maintenance change, but I used the mailing addresses in v7.3-rc6.
Quoted 6 lines
OpenGL doesn't necessarily require clearing of VRAM nor isolation of VRAM data between processes.
So it is up to the driver if they want this or not. Classically a lot of drivers didn't clear VRAM allocations until explicitely asked.
Then in this case I think it's better to just remove the VRAM clearing code -- this driver is even not related to render acceleration at all now (and getting rendering to work would be so hacky because loongson DC's are paired with either Vivante GPUs with dedicated VRAM or proprietary GPUs).
Quoted 3 lines
But if you clear the memory you should have proper error handling and a kmap/vmap can fail at any time for multiple reasons.
Yes, if the other maintainers prefer to keep the memory clearing code, I will accept this specific patch.
Thanks,
Icenowy
Quoted 23 lines
Regards,
Christian.Quoted 19 lines
Thanks,
IcenowyQuoted 14 lines
drivers/gpu/drm/loongson/lsdc_ttm.h +0
-0@@ -89,7 +89,7 @@ size_t lsdc_bo_size(struct lsdc_bo *lbo);
intlsdc_bo_kmap(struct lsdc_bo *lbo);
voidlsdc_bo_kunmap(struct lsdc_bo *lbo);drivers/gpu/drm/loongson/lsdc_ttm.h +1
-1-void lsdc_bo_clear (struct lsdc_bo *lbo); +int lsdc_bo_clear (struct lsdc_bo *lbo);
intlsdc_bo_evict_vram(struct drm_device *ddev);
Icenowy Zheng
reviewerRe: [PATCH 2/2] drm/loongson: Handle buffer mapping failures when clearing a BO
In reply to Christian KönigQuoted 37 lines · 在 2026-10-09五的 16:14 +0200,Christian König写道:
Quoted 36 lines · Icenowy Zheng
Quoted 35 lines · 在 2026-10-03六的 09:34 +0000,Evanshenf写道:
lsdc_bo_clear()ignores the return value fromlsdc_bo_kmap()and writes
tolbo->kptrunconditionally. When the first mapping of a newly allocated
buffer fails, kptr is still NULL and the subsequent memset accesses
it.Return the mapping error without touching the buffer and propagate it
fromlsdc_gem_object_create(). Install the GEM object functions before
clearing so thatdrm_gem_object_put()can release the buffer correctly
on failure. Do not add the failed object to the tracking list or return
an uncleared buffer to the caller.Imported buffers still skip clearing, and successfully mapped buffers
are cleared and unmapped as before.Tested on LS7A2000 with a one-shot range error in
ttm_bo_kmap(). Its-EINVALreturn reached userspace, the object was destroyed once, and
no GEM handle was published. Normal create/map/zero/write/read/close
cycles passed, with the tracked BO count and VRAM usage unchanged.AI assistance was used for the lifetime analysis, fix, fault- injection
tools, build and test execution.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Fixes f39db26c5428 ("drm: Add kms driver for loongson displaycontroller")
I'm going to accept this patch now.
``` Reviewed-by: Icenowy Zheng <[email protected]> ```
Although I may prefer to remove the clearing routine in the future.
Thanks,
Icenowy
Quoted 107 lines
Quoted 69 lines
Quoted 63 lines
---
drivers/gpu/drm/loongson/lsdc_gem.c | 12 ++++++++---- drivers/gpu/drm/loongson/lsdc_ttm.c | 10 ++++++++-- drivers/gpu/drm/loongson/lsdc_ttm.h | 2 +- 3 files changed, 17 insertions(+), 7 deletions(-)drivers/gpu/drm/loongson/lsdc_gem.c +0
-0@@ -157,14 +157,18 @@ struct drm_gem_object *lsdc_gem_object_create(struct drm_device *ddev, return ERR_PTR(ret); }drivers/gpu/drm/loongson/lsdc_gem.c +3
-0+ gobj = &lbo->tbo.base; + gobj->funcs = &lsdc_gem_object_funcs; +if (!sg) {
/* VRAM is filled with random data */drivers/gpu/drm/loongson/lsdc_gem.c +5
-1-lsdc_bo_clear (lbo); + ret =lsdc_bo_clear (lbo); +if (ret) { +drm_gem_object_put (gobj); +return ERR_PTR (ret); + }}
drivers/gpu/drm/loongson/lsdc_gem.c +0
-3- gobj = &lbo->tbo.base; - gobj->funcs = &lsdc_gem_object_funcs; -/* tracking the BOs we created */
mutex_lock(&ldev->gem.mutex);list_add_tail(&lbo->list, &ldev->gem.objects);drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -388,9 +388,13 @@ void lsdc_bo_kunmap(struct lsdc_bo *lbo) ttm_bo_kunmap(&lbo->kmap); }drivers/gpu/drm/loongson/lsdc_ttm.c +1
-1-void lsdc_bo_clear (struct lsdc_bo *lbo) +int lsdc_bo_clear (struct lsdc_bo *lbo){
drivers/gpu/drm/loongson/lsdc_ttm.c +5
-1-lsdc_bo_kmap (lbo); +int ret; + + ret =lsdc_bo_kmap (lbo); +if (ret) +return ret;
if (lbo->is_iomem)
memset_io((void__iomem*)lbo->kptr, 0, lbo-Quoted 1 line
size);
drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -398,6 +402,8 @@ void lsdc_bo_clear(struct lsdc_bo *lbo) memset(lbo->kptr, 0, lbo->size);
lsdc_bo_kunmap(lbo);drivers/gpu/drm/loongson/lsdc_ttm.c +2
-0+ +return 0 ;Quoted 3 lines
}
intlsdc_bo_evict_vram(struct drm_device *ddev)Well I currently don't know whether the clearing is meaningful...
Quoted 3 lines
It seems that
drm_gem_vram_helperdoesn't do this.Cc'ing TTM maintainers for an answer.
Natalie and Arun are TTM maintainers now, but I will try to answer here as well.
OpenGL doesn't necessarily require clearing of VRAM nor isolation of VRAM data between processes.
So it is up to the driver if they want this or not. Classically a lot of drivers didn't clear VRAM allocations until explicitely asked.
But if you clear the memory you should have proper error handling and a kmap/vmap can fail at any time for multiple reasons.
Regards,
Christian.Quoted 19 lines
Thanks,
IcenowyQuoted 14 lines
drivers/gpu/drm/loongson/lsdc_ttm.h +0
-0@@ -89,7 +89,7 @@ size_t lsdc_bo_size(struct lsdc_bo *lbo);
intlsdc_bo_kmap(struct lsdc_bo *lbo);
voidlsdc_bo_kunmap(struct lsdc_bo *lbo);drivers/gpu/drm/loongson/lsdc_ttm.h +1
-1-void lsdc_bo_clear (struct lsdc_bo *lbo); +int lsdc_bo_clear (struct lsdc_bo *lbo);
intlsdc_bo_evict_vram(struct drm_device *ddev);
Icenowy Zheng
reviewerQuoted 53 lines · 在 2026-10-03六的 09:34 +0000,Evanshenf写道:
If
ttm_bo_init_validate()fails, it drops the buffer object's reference
and cleans it up through the supplied destroy callback.lsdc_bo_destroy()
releases the GEM object and frees the enclosinglsdc_bo, so freeing it
again inlsdc_bo_create()causes a double free on a synchronous failure
path.Let TTM own the cleanup after initialization has started and return the
error directly. Keep the explicit free ondrm_gem_object_init()failure,
which occurs before ownership is passed to TTM.Tested on LS7A2000 by making
drm_vma_offset_add()return-ENOSPCfor one
selected dumb-buffer creation. The error reached userspace, the destroy
callback ran once, and no handle was published or tracked BO retained.
Normal buffer creation, zeroing, mapping, readback and release passed.AI assistance was used for the ownership analysis, fix, fault- injection
tools, build and test execution.Fixes f39db26c5428 ("drm: Add kms driver for loongson displaycontroller")
---
drivers/gpu/drm/loongson/lsdc_ttm.c | 4 +---1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -475,10 +475,8 @@ struct lsdc_bo *lsdc_bo_create(struct drm_device *ddev,
ret = ttm_bo_init_validate(bdev, tbo,bo_type, &lbo-Quoted 1 line
placement, 0,
false, sg, resv,
lsdc_bo_destroy);drivers/gpu/drm/loongson/lsdc_ttm.c +1
-2-if (ret) { -kfree (lbo); +if (ret)
Quoted 1 line
return
ERR_PTR(ret);
It looks like this fix is valid, ttm_bo_init_reserved() (called by ttm_bo_init_validate() ) will do a ttm_bo_put() operation when failure, which leads to calling the destroy callback.
``` Reviewed-by: Icenowy Zheng <[email protected]> ```
Thanks,
Icenowy
Quoted 6 lines
drivers/gpu/drm/loongson/lsdc_ttm.c +0
-1- }
return lbo;
}base-commit:
bca45af5998a05f34b13a2ef11e639bac9c62643
The fix looks correct and the TTM ownership analysis is accurate.
Thanks,
Qianhai Wu
Quoted 73 lines · Icenowy Zheng
Quoted 44 lines · 在 2026-10-03六的 09:34 +0000,Evanshenf写道:
If
ttm_bo_init_validate()fails, it drops the buffer object's reference
and cleans it up through the supplied destroy callback.lsdc_bo_destroy()
releases the GEM object and frees the enclosinglsdc_bo, so freeing it
again inlsdc_bo_create()causes a double free on a synchronous failure
path.Let TTM own the cleanup after initialization has started and return the
error directly. Keep the explicit free ondrm_gem_object_init()failure,
which occurs before ownership is passed to TTM.Tested on LS7A2000 by making
drm_vma_offset_add()return-ENOSPCfor one
selected dumb-buffer creation. The error reached userspace, the destroy
callback ran once, and no handle was published or tracked BO retained.
Normal buffer creation, zeroing, mapping, readback and release passed.AI assistance was used for the ownership analysis, fix, fault- injection
tools, build and test execution.Fixes f39db26c5428 ("drm: Add kms driver for loongson displaycontroller")
--- drivers/gpu/drm/loongson/lsdc_ttm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0drivers/gpu/drm/loongson/lsdc_ttm.c struct lsdc_bo *lsdc_bo_create(struct drm_device · line 482
Quoted 10 lines
drivers/gpu/drm/loongson/lsdc_ttm.c +1
-2@@ -475,10 +475,8 @@ struct lsdc_bo *lsdc_bo_create(struct drm_device *ddev, ret = ttm_bo_init_validate(bdev, tbo, bo_type, &lbo- > placement, 0, false, sg, resv, lsdc_bo_destroy); -if (ret) { -kfree (lbo); +if (ret) return ERR_PTR(ret);It looks like this fix is valid,
ttm_bo_init_reserved()(called byttm_bo_init_validate()) will do attm_bo_put()operation when failure, which leads to calling the destroy callback.``` Reviewed-by: Icenowy Zheng <[email protected]> ```Thanks,
IcenowyQuoted 6 lines
drivers/gpu/drm/loongson/lsdc_ttm.c +0
-1- }return lbo;
}base-commit:
bca45af5998a05f34b13a2ef11e639bac9c62643
Quoted 16 lines · Evanshenf
If
ttm_bo_init_validate()fails, it drops the buffer object's reference and cleans it up through the supplied destroy callback.lsdc_bo_destroy()releases the GEM object and frees the enclosinglsdc_bo, so freeing it again inlsdc_bo_create()causes a double free on a synchronous failure path.Let TTM own the cleanup after initialization has started and return the error directly. Keep the explicit free on
drm_gem_object_init()failure, which occurs before ownership is passed to TTM.Tested on LS7A2000 by making
drm_vma_offset_add()return-ENOSPCfor one selected dumb-buffer creation. The error reached userspace, the destroy callback ran once, and no handle was published or tracked BO retained. Normal buffer creation, zeroing, mapping, readback and release passed.
Quoted 6 lines
AI assistance was used for the ownership analysis, fix, fault-injection tools, build and test execution.
Fixes f39db26c5428 ("drm: Add kms driver for loongson display controller")Assisted-by LLM
Quoted 26 lines
Signed-off-by Evanshenf <[email protected]>--- drivers/gpu/drm/loongson/lsdc_ttm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/loongson/lsdc_ttm.c +1
-3@@ -475,10 +475,8 @@ struct lsdc_bo *lsdc_bo_create(struct drm_device *ddev, ret =ttm_bo_init_validate (bdev, tbo, bo_type, &lbo->placement,0 , false, sg, resv, lsdc_bo_destroy); -if (ret) { -kfree (lbo); +if (ret)return ERR_PTR (ret); - }return lbo; }base-commit:
bca45af5998a05f34b13a2ef11e639bac9c62643--
2.43.0
Quoted 29 lines · 在 2026-10-03六的 09:34 +0000,Evanshenf写道:
If
ttm_bo_init_validate()fails, it drops the buffer object's reference
and cleans it up through the supplied destroy callback.lsdc_bo_destroy()
releases the GEM object and frees the enclosinglsdc_bo, so freeing it
again inlsdc_bo_create()causes a double free on a synchronous failure
path.Let TTM own the cleanup after initialization has started and return the
error directly. Keep the explicit free ondrm_gem_object_init()failure,
which occurs before ownership is passed to TTM.Tested on LS7A2000 by making
drm_vma_offset_add()return-ENOSPCfor one
selected dumb-buffer creation. The error reached userspace, the destroy
callback ran once, and no handle was published or tracked BO retained.
Normal buffer creation, zeroing, mapping, readback and release passed.AI assistance was used for the ownership analysis, fix, fault- injection
tools, build and test execution.
Quoted 5 lines
Fixes f39db26c5428 ("drm: Add kms driver for loongson displaycontroller")
Applied both to drm-misc-fixes, Thanks for your contribution!
Icenowy
Quoted 26 lines
---
drivers/gpu/drm/loongson/lsdc_ttm.c | 4 +---1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/loongson/lsdc_ttm.c +0
-0@@ -475,10 +475,8 @@ struct lsdc_bo *lsdc_bo_create(struct drm_device *ddev,
ret = ttm_bo_init_validate(bdev, tbo,bo_type, &lbo-Quoted 1 line
placement, 0,
false, sg, resv,
lsdc_bo_destroy);drivers/gpu/drm/loongson/lsdc_ttm.c +1
-2-if (ret) { -kfree (lbo); +if (ret)return
ERR_PTR(ret);drivers/gpu/drm/loongson/lsdc_ttm.c +0
-1- }
return lbo;
}base-commit:
bca45af5998a05f34b13a2ef11e639bac9c62643