Skip to contentSkip to conversation

dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

PATCH In review Jisheng Zhang 4 participants 6 messages Oct 5 – Oct 13

Subsystems (2)
Device tree bindings TTY layer and serial drivers
lore
Share & tools
lore

Jisheng Zhang

author
#0 lore raw

PATCH v2 1/1 dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

Add the compatible for the UARTs of the Synaptics SL2610, which are compatible with the Synopsys DesignWare APB UART.

Signed-off-by Jisheng Zhang <[email protected]>

---

since v1:
- use sl2610 instead of sl261x
- send as a separate patch

 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +11 -1
index 664305de4986..a40f2737e71b 100644
@@ -34,7 +34,16 @@ allOf:
       properties:
         resets:
           minItems: 2
-    else:
+
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - starfive,jh7110-uart
+                - syna,sl2610-uart
+    then:
       properties:
         resets:
           maxItems: 1

@@ -80,6 +89,7 @@ properties:
               - starfive,jh7100-hsuart
               - starfive,jh7100-uart
               - starfive,jh7110-uart
+              - syna,sl2610-uart
               - ultrarisc,dp1000-uart
           - const: snps,dw-apb-uart
       - const: snps,dw-apb-uart
Signature · 1 line
2.53.0
AI review
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: missing minItems: 2 constraint for syna,sl2610-uart resets --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing minItems: 2 constraint for syna,sl2610-uart resets --

commit d2c2a625dcf17e541f9ec792d85888075ee11605
Author: Jisheng Zhang <[email protected]>

dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

Add the compatible for the UARTs of the Synaptics SL2610, which are compatible with the Synopsys DesignWare APB UART.

Quoted 8 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +0 -0
index 664305de4986f..a40f2737e71b5 100644
@@ -34,7 +34,16 @@ allOf:
       properties:
         resets:
           minItems: 2

Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml allOf: · line 45

Quoted 10 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +9 -1
-    else:
+
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - starfive,jh7110-uart
+                - syna,sl2610-uart

[Severity: Low]
Does this compatible string also need to be added to the if-then block enforcing the minItems: 2 constraint?

This block explicitly exempts syna,sl2610-uart from the maxItems: 1 single-reset constraint, indicating it requires 2 resets. However, the block immediately above this (which enforces minItems: 2 for starfive,jh7110-uart) was not updated to include syna,sl2610-uart.

As a result, device trees for syna,sl2610-uart with only 1 reset will silently pass schema validation.

Quoted 4 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +1 -0
+    then:
       properties:
         resets:
           maxItems: 1
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#2 lore raw
In reply to Jisheng Zhang
Quoted 21 lines · Jisheng Zhang

Add the compatible for the UARTs of the Synaptics SL2610, which are compatible with the Synopsys DesignWare APB UART.

Signed-off-by Jisheng Zhang <[email protected]>

---

since v1:
- use sl2610 instead of sl261x
- send as a separate patch

 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +0 -0
index 664305de4986..a40f2737e71b 100644
@@ -34,7 +34,16 @@ allOf:
       properties:
         resets:
           minItems: 2

Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml allOf: · line 45

Quoted 10 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +9 -1
-    else:
+
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - starfive,jh7110-uart
+                - syna,sl2610-uart

Is the number of uart resets on this device variable?

Quoted 15 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +2 -0
+    then:
       properties:
         resets:
           maxItems: 1

@@ -80,6 +89,7 @@ properties:
               - starfive,jh7100-hsuart
               - starfive,jh7100-uart
               - starfive,jh7110-uart
+              - syna,sl2610-uart
               - ultrarisc,dp1000-uart
           - const: snps,dw-apb-uart
       - const: snps,dw-apb-uart
Signature · 1 line
2.53.0
author
#3 lore raw
Quoted 26 lines · Conor Dooley
Quoted 25 lines · Jisheng Zhang

Add the compatible for the UARTs of the Synaptics SL2610, which are compatible with the Synopsys DesignWare APB UART.

Signed-off-by Jisheng Zhang <[email protected]>

---

since v1:
- use sl2610 instead of sl261x
- send as a separate patch

 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +3 -1
index 664305de4986..a40f2737e71b 100644
@@ -34,7 +34,16 @@ allOf:
       properties:
         resets:
           minItems: 2
-    else:
+
+  - if:
+      not:
Quoted 8 lines

Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml allOf: · line 45

Quoted 6 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +6 -0
+        properties:
+          compatible:
+            contains:
+              enum:
+                - starfive,jh7110-uart
+                - syna,sl2610-uart

Is the number of uart resets on this device variable?

Yes, some uarts have only 1 reset, while others have two resets.

Quoted 16 lines
Quoted 16 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +2 -0
+    then:
       properties:
         resets:
           maxItems: 1

@@ -80,6 +89,7 @@ properties:
               - starfive,jh7100-hsuart
               - starfive,jh7100-uart
               - starfive,jh7110-uart
+              - syna,sl2610-uart
               - ultrarisc,dp1000-uart
           - const: snps,dw-apb-uart
       - const: snps,dw-apb-uart
Signature · 1 line
2.53.0
Acked-by
#4 lore raw
Quoted 36 lines · Jisheng Zhang
Quoted 26 lines · Conor Dooley
Quoted 25 lines · Jisheng Zhang

Add the compatible for the UARTs of the Synaptics SL2610, which are compatible with the Synopsys DesignWare APB UART.

Signed-off-by Jisheng Zhang <[email protected]>

---

since v1:
- use sl2610 instead of sl261x
- send as a separate patch

 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +3 -1
index 664305de4986..a40f2737e71b 100644
@@ -34,7 +34,16 @@ allOf:
       properties:
         resets:
           minItems: 2
-    else:
+
+  - if:
+      not:
Quoted 8 lines

Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml allOf: · line 45

Quoted 6 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +6 -0
+        properties:
+          compatible:
+            contains:
+              enum:
+                - starfive,jh7110-uart
+                - syna,sl2610-uart

Is the number of uart resets on this device variable?

Quoted 1 line

Yes, some uarts have only 1 reset, while others have two resets.

In the future, please mention this so it doesn't look like an oversight.

Acked-by Conor Dooley <[email protected]>

pw-bot: not-applicable

Thanks,
Conor.

Quoted 19 lines
Quoted 17 lines
Quoted 17 lines
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +2 -0
+    then:
       properties:
         resets:
           maxItems: 1

@@ -80,6 +89,7 @@ properties:
               - starfive,jh7100-hsuart
               - starfive,jh7100-uart
               - starfive,jh7110-uart
+              - syna,sl2610-uart
               - ultrarisc,dp1000-uart
           - const: snps,dw-apb-uart
       - const: snps,dw-apb-uart
Signature · 1 line
2.53.0
maintainer
#5 lore raw
In reply to Jisheng Zhang
Quoted 4 lines · Jisheng Zhang

Add the compatible for the UARTs of the Synaptics SL2610, which are compatible with the Synopsys DesignWare APB UART.

Signed-off-by Jisheng Zhang <[email protected]>
Quoted 8 lines

---

since v1:
- use sl2610 instead of sl261x
- send as a separate patch

 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Does not apply to the tty-testing branch :(