Skip to contentSkip to conversation

dt-bindings: bus: Add HiSilicon local bus

PATCH In review Rob Herring (Arm) 2 participants 3 messages Oct 5 – Oct 6 Device tree bindings

lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: bus: Add HiSilicon local bus

Add a schema for hisilicon,hisi-localbus which is already in use for a long time.

Assisted-by LLM
Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../bindings/bus/hisilicon,hisi-localbus.yaml | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml new file +40 -0
new file mode 100644
index 000000000000..cd9ecea88269
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/hisilicon,hisi-localbus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: HiSilicon local bus
+
+maintainers:
+  - Wei Xu <[email protected]>
+
+allOf:
+  - $ref: /schemas/simple-bus.yaml#
+
+properties:
+  compatible:
+    items:
+      - const: hisilicon,hisi-localbus
+      - const: simple-bus
+
+  reg:
+    maxItems: 1
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        local-bus@80380000 {
+            compatible = "hisilicon,hisi-localbus", "simple-bus";
+            reg = <0x0 0x80380000 0x0 0x10000>;
+            #address-cells = <2>;
+            #size-cells = <1>;
+            ranges = <0 0 0x0 0x90000000 0x08000000>,
+                     <1 0 0x0 0x98000000 0x08000000>;
+        };
+    };
Signature · 1 line
2.53.0
AI review
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: missing `required` block allows nodes without `reg` to pass --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing required block allows nodes without reg to pass --

commit 31cf8e8c992601dbcd36de1b649ef5c513febf6f
Author: Rob Herring (Arm) <[email protected]>

dt-bindings: bus: Add HiSilicon local bus

This commit introduces a new device tree binding schema for the HiSilicon local bus. It sets up validation constraints for the compatible string and registers.

Quoted 5 lines
Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml new file +0 -0
new file mode 100644
index 0000000000000..cd9ecea88269f

[ ... ]

Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml line 24

Quoted 10 lines
Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml new file +10 -0
+properties:
+  compatible:
+    items:
+      - const: hisilicon,hisi-localbus
+      - const: simple-bus
+
+  reg:
+    maxItems: 1
+
+unevaluatedProperties: false

[Severity: Low]
Should this schema include a required array to enforce the presence of the compatible and reg properties?

Because properties are optional by default, omitting an explicit required block here means that incomplete device tree nodes missing either the reg property or the compatible string will silently pass dtbs_check validation without enforcing the constraints defined above.

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
author maintainer
#2 lore raw
Quoted 20 lines · On Mon, Oct 05, 2026 at 09:00:34PM +0000, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing required block allows nodes without reg to pass --

commit 31cf8e8c992601dbcd36de1b649ef5c513febf6f
Author: Rob Herring (Arm) <[email protected]>

dt-bindings: bus: Add HiSilicon local bus

This commit introduces a new device tree binding schema for the HiSilicon local bus. It sets up validation constraints for the compatible string and registers.

Quoted 5 lines
Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml new file +0 -0
new file mode 100644
index 0000000000000..cd9ecea88269f

[ ... ]

Quoted 14 lines

Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml line 24

Quoted 10 lines
Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml new file +10 -0
+properties:
+  compatible:
+    items:
+      - const: hisilicon,hisi-localbus
+      - const: simple-bus
+
+  reg:
+    maxItems: 1
+
+unevaluatedProperties: false

[Severity: Low]
Should this schema include a required array to enforce the presence of the compatible and reg properties?

compatible is implied, but will add 'reg' when applying.

Rob