Thoughts on Sashiko reviews for linux-usb

Hi all,

I'd like to get your thoughts on having Sashiko send review results to linux-usb for patches posted to the list.

I started looking into this after receiving a reference to a Sashiko review for a dwc3 patch that I wasn't Cc'd on, which required me to track down the review separately to understand the feedback.

Sashiko is currently configured per mailing list, so any change would apply to all patches sent to linux-usb rather than a specific subsystem.

Would anyone object to enabling Sashiko reviews on linux-usb?

Hi all,

I'd like to get your thoughts on having Sashiko send review results to linux-usb for patches posted to the list.

I started looking into this after receiving a reference to a Sashiko review for a dwc3 patch that I wasn't Cc'd on, which required me to track down the review separately to understand the feedback.

Sashiko is currently configured per mailing list, so any change would apply to all patches sent to linux-usb rather than a specific subsystem.

Would anyone object to enabling Sashiko reviews on linux-usb?

Quoted 9 lines · Thinh Nguyen

Hi all,

I'd like to get your thoughts on having Sashiko send review results to linux-usb for patches posted to the list.

I started looking into this after receiving a reference to a Sashiko review for a dwc3 patch that I wasn't Cc'd on, which required me to track down the review separately to understand the feedback.

Quoted 4 lines

Sashiko is currently configured per mailing list, so any change would apply to all patches sent to linux-usb rather than a specific subsystem.

Would anyone object to enabling Sashiko reviews on linux-usb?

Not at all, want to submit the pull request to the repo to add it, or do you need/want me to?

Quoted 10 lines · Greg Kroah-Hartman

Quoted 9 lines · Thinh Nguyen

Hi all,

I'd like to get your thoughts on having Sashiko send review results to linux-usb for patches posted to the list.

I started looking into this after receiving a reference to a Sashiko review for a dwc3 patch that I wasn't Cc'd on, which required me to track down the review separately to understand the feedback.

Quoted 7 lines

Quoted 4 lines

Sashiko is currently configured per mailing list, so any change would apply to all patches sent to linux-usb rather than a specific subsystem.

Would anyone object to enabling Sashiko reviews on linux-usb?

Not at all, want to submit the pull request to the repo to add it, or do you need/want me to?

Now done:

	https://github.com/sashiko-dev/sashiko/pull/651

but I don't know if that adds a "will email back the review" workflow for patches sent to linux-usb@vger.

Roman, it looks like the sashiko.dev/email_policy.toml file isn't in the repo anymore, or at least it's not in the git checkout that I can see. Does the linux-usb list need to be configured anywhere else as well?

Quoted 19 lines · Greg Kroah-Hartman

Quoted 10 lines · Greg Kroah-Hartman

Quoted 9 lines · Thinh Nguyen

Hi all,

I'd like to get your thoughts on having Sashiko send review results to linux-usb for patches posted to the list.

I started looking into this after receiving a reference to a Sashiko review for a dwc3 patch that I wasn't Cc'd on, which required me to track down the review separately to understand the feedback.

Quoted 7 lines

Quoted 4 lines

Sashiko is currently configured per mailing list, so any change would apply to all patches sent to linux-usb rather than a specific subsystem.

Would anyone object to enabling Sashiko reviews on linux-usb?

Not at all, want to submit the pull request to the repo to add it, or do you need/want me to?

Quoted 8 lines

Now done:

	https://github.com/sashiko-dev/sashiko/pull/651

but I don't know if that adds a "will email back the review" workflow for patches sent to linux-usb@vger.

Roman, it looks like the sashiko.dev/email_policy.toml file isn't in the repo anymore, or at least it's not in the git checkout that I can see. Does the linux-usb list need to be configured anywhere else as well?

I moved it to deployment/sashiko.dev/email_policy.toml while preparing to support other projects.

You need to define the email policy to receive reviews over the email. I can help with that, just let me know who it should to/cc? It seems that the most popular option is to reply to the author and cc the mailing list.

Quoted 30 lines · Roman Gushchin

Quoted 19 lines · Greg Kroah-Hartman

Quoted 10 lines · Greg Kroah-Hartman

Quoted 9 lines · Thinh Nguyen

Hi all,

I'd like to get your thoughts on having Sashiko send review results to linux-usb for patches posted to the list.

I started looking into this after receiving a reference to a Sashiko review for a dwc3 patch that I wasn't Cc'd on, which required me to track down the review separately to understand the feedback.

Quoted 7 lines

Quoted 4 lines

Sashiko is currently configured per mailing list, so any change would apply to all patches sent to linux-usb rather than a specific subsystem.

Would anyone object to enabling Sashiko reviews on linux-usb?

Not at all, want to submit the pull request to the repo to add it, or do you need/want me to?

Quoted 8 lines

Now done:

	https://github.com/sashiko-dev/sashiko/pull/651

but I don't know if that adds a "will email back the review" workflow for patches sent to linux-usb@vger.

Roman, it looks like the sashiko.dev/email_policy.toml file isn't in the repo anymore, or at least it's not in the git checkout that I can see. Does the linux-usb list need to be configured anywhere else as well?

Quoted 7 lines

I moved it to deployment/sashiko.dev/email_policy.toml while preparing to support other projects.

You need to define the email policy to receive reviews over the email. I can help with that, just let me know who it should to/cc? It seems that the most popular option is to reply to the author and cc the mailing list.

Ah, issed that file, sorry about that. I've submitted:

	https://github.com/sashiko-dev/sashiko/pull/652

to add the default policy (to match what we have on linux-serial as that seems the most sane for now.)